diff mbox

[RFA,3/3] NEWS and documentation for new info sources [-d | -b] [--] [REGEXP] args

Message ID 20190331190803.7248-4-philippe.waroquiers@skynet.be
State New
Headers show

Commit Message

Philippe Waroquiers March 31, 2019, 7:08 p.m. UTC
gdb/ChangeLog
2019-03-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * NEWS: Mention changes to info sources.

gdb/doc/ChangeLog
2019-03-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * gdb.texinfo (info sources): Document new args.
---
 gdb/NEWS            | 8 ++++++++
 gdb/doc/gdb.texinfo | 9 +++++++++
 2 files changed, 17 insertions(+)

Comments

Eli Zaretskii March 31, 2019, 7:15 p.m. UTC | #1
> From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Date: Sun, 31 Mar 2019 21:08:03 +0200
> 
> gdb/doc/ChangeLog
> 2019-03-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
> 
>         * gdb.texinfo (info sources): Document new args.

The name in the parentheses should be the name of the @node where you
are making changes.  I don't think that's "info sources", is it?

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -16,6 +16,14 @@
>  
>  * Support for Pointer Authentication on AArch64 Linux.
>  
> +* Changed commands
> +
> +info sources [-d | -b] [--] [REGEXP]
> +  This command has now optional arguments to only print the files
> +  whose names match REGEXP.  The arguments -d and -b allow to
> +  restrict matching respectively to the dirname and basename
> +  parts of the files.

This part is OK.

> +@item info sources [-d | -b] [--] [@var{regexp}]
> +Like @samp{info sources}, but only print the names of the files
> +matching the provided regexp.
                         ^^^^^^
"@var{regexp}", to reference the command's argument.

> +By default, the regexp is used to match anywhere in the filename.
                   ^^^^^^
And here.

> +If -d, only files having a dirname matching regexp are shown.
> +If -b, only files having a basename matching regexp are shown.

And here.

OK with those fixed.

Thanks.
diff mbox

Patch

diff --git a/gdb/NEWS b/gdb/NEWS
index 4bfa15becf..04b2b45909 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -16,6 +16,14 @@ 
 
 * Support for Pointer Authentication on AArch64 Linux.
 
+* Changed commands
+
+info sources [-d | -b] [--] [REGEXP]
+  This command has now optional arguments to only print the files
+  whose names match REGEXP.  The arguments -d and -b allow to
+  restrict matching respectively to the dirname and basename
+  parts of the files.
+
 *** Changes in GDB 8.3
 
 * GDB and GDBserver now support access to additional registers on
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index bb958cf25d..66068816cd 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -17985,6 +17985,15 @@  Print the names of all source files in your program for which there is
 debugging information, organized into two lists: files whose symbols
 have already been read, and files whose symbols will be read when needed.
 
+@item info sources [-d | -b] [--] [@var{regexp}]
+Like @samp{info sources}, but only print the names of the files
+matching the provided regexp.
+By default, the regexp is used to match anywhere in the filename.
+If -d, only files having a dirname matching regexp are shown.
+If -b, only files having a basename matching regexp are shown.
+The matching is case-sensitive, except on operating systems that
+have case-insensitive filesystem (e.g., MS-Windows).
+
 @kindex info functions
 @item info functions [-q]
 Print the names and data types of all defined functions.