Message ID | 20190326171745.96435-1-alan.hayward@arm.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 73226 invoked by alias); 26 Mar 2019 17:18:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 73196 invoked by uid 89); 26 Mar 2019 17:18:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr150083.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (40.107.15.83) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Mar 2019 17:17:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BmKj0lQCgwgFZr03y71u07aWSvQIv5XpFPB1aOrD4aE=; b=Bke/9PtBQC1WrI20BHIHnfQR+ZVGlZmghtM9nwkUs8rwJ0cc6E8ErA2v4u/JJt/FgBQBv5NbUlZoQJpJY6wLmhpDUO+vuUL/V4Lyzx8EuVBylGIuRrc0SVJkAnrpBnoCD8j9ucCddnkscLpDovG2Ikhwcc7BNlIW7Ld/Oe464Ro= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2615.eurprd08.prod.outlook.com (10.172.252.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.18; Tue, 26 Mar 2019 17:17:55 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::2083:2d62:84fa:a547]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::2083:2d62:84fa:a547%3]) with mapi id 15.20.1730.019; Tue, 26 Mar 2019 17:17:55 +0000 From: Alan Hayward <Alan.Hayward@arm.com> To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org> CC: nd <nd@arm.com>, Alan Hayward <Alan.Hayward@arm.com> Subject: [OBV][PATCH] Fix powerpc build Date: Tue, 26 Mar 2019 17:17:55 +0000 Message-ID: <20190326171745.96435-1-alan.hayward@arm.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-IsSubscribed: yes |
Commit Message
Alan Hayward
March 26, 2019, 5:17 p.m. UTC
gdb/ChangeLog: 2019-03-26 Alan Hayward <alan.hayward@arm.com> * ppc-linux-nat.c: Add include --- gdb/ppc-linux-nat.c | 1 + 1 file changed, 1 insertion(+)
Comments
On Tue, 26 Mar 2019 17:17:55 +0000 Alan Hayward <Alan.Hayward@arm.com> wrote: > gdb/ChangeLog: > > 2019-03-26 Alan Hayward <alan.hayward@arm.com> > > * ppc-linux-nat.c: Add include The ChangeLog entry needs a period. It'd also be nice to mention what you're including. I.e. * ppc-linux-nat.c (linux-tdep.h): Add include. Kevin
> On 26 Mar 2019, at 22:56, Kevin Buettner <kevinb@redhat.com> wrote: > > On Tue, 26 Mar 2019 17:17:55 +0000 > Alan Hayward <Alan.Hayward@arm.com> wrote: > >> gdb/ChangeLog: >> >> 2019-03-26 Alan Hayward <alan.hayward@arm.com> >> >> * ppc-linux-nat.c: Add include > > The ChangeLog entry needs a period. Thankfully I spotted that after I sent the email, but before I pushed. It’s fixed in the actual commit. > It'd also be nice to mention > what you're including. I.e. > > * ppc-linux-nat.c (linux-tdep.h): Add include. Will do in future. Alan. > > Kevin
On Mär 27 2019, Alan Hayward <Alan.Hayward@arm.com> wrote: >> On 26 Mar 2019, at 22:56, Kevin Buettner <kevinb@redhat.com> wrote: >> >> It'd also be nice to mention >> what you're including. I.e. >> >> * ppc-linux-nat.c (linux-tdep.h): Add include. > > Will do in future. I think the convention is to write it like this: * ppc-linux-nat.c: Include "linux-tdep.h". Andreas.
diff --git a/gdb/ppc-linux-nat.c b/gdb/ppc-linux-nat.c index 3a6bbf4163..628e3d5e8f 100644 --- a/gdb/ppc-linux-nat.c +++ b/gdb/ppc-linux-nat.c @@ -51,6 +51,7 @@ #include "arch/ppc-linux-common.h" #include "arch/ppc-linux-tdesc.h" #include "nat/ppc-linux.h" +#include "linux-tdep.h" /* Similarly for the hardware watchpoint support. These requests are used when the PowerPC HWDEBUG ptrace interface is not available. */