From patchwork Thu Mar 7 20:57:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 31776 Received: (qmail 53656 invoked by alias); 7 Mar 2019 20:57:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 53440 invoked by uid 89); 7 Mar 2019 20:57:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=2172, 2.17.2, 4638, sk:coff_sy X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Mar 2019 20:57:13 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway32.websitewelcome.com (Postfix) with ESMTP id ACACC7D6B8 for ; Thu, 7 Mar 2019 14:57:11 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 204lhelgx4FKp204lhv4Ms; Thu, 07 Mar 2019 14:57:11 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LrCllq/etutF3Nd+Uu1SwKbjw0I1QbpN216DU6rcq30=; b=mGMle89mP+5XgH5TAjEe313G33 bassiZI+nOyqxKU7oSne4g/fEnHTUu3khZCuUo/qDGfTAm46aY6TMFBMmcYZijsTiswj+MF+h39BF JcKiur+BR5rPuER+fZIkAsypH; Received: from 75-166-85-218.hlrn.qwest.net ([75.166.85.218]:53182 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h204l-002TOW-E3; Thu, 07 Mar 2019 14:57:11 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 1/9] Slightly simplify minsym creation Date: Thu, 7 Mar 2019 13:57:01 -0700 Message-Id: <20190307205709.21919-2-tom@tromey.com> In-Reply-To: <20190307205709.21919-1-tom@tromey.com> References: <20190307205709.21919-1-tom@tromey.com> Only one caller of minimal_symbol_reader::record_with_info was using the return value, so this patch simplifies this code by having it return void and changing that caller to use record_full instead. gdb/ChangeLog 2019-03-07 Tom Tromey * minsyms.h (class minimal_symbol_reader) : Don't return the symbol. * coffread.c (record_minimal_symbol): Use record_full. --- gdb/ChangeLog | 6 ++++++ gdb/coffread.c | 3 ++- gdb/minsyms.h | 13 +++++++------ 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/gdb/coffread.c b/gdb/coffread.c index b89c0e2e803..8c8e0784789 100644 --- a/gdb/coffread.c +++ b/gdb/coffread.c @@ -463,7 +463,8 @@ record_minimal_symbol (minimal_symbol_reader &reader, return NULL; } - return reader.record_with_info (cs->c_name, address, type, section); + return reader.record_full (cs->c_name, strlen (cs->c_name), true, address, + type, section); } /* coff_symfile_init () diff --git a/gdb/minsyms.h b/gdb/minsyms.h index 729d3946075..532436c16c1 100644 --- a/gdb/minsyms.h +++ b/gdb/minsyms.h @@ -116,14 +116,15 @@ class minimal_symbol_reader /* Like record_full, but: - uses strlen to compute NAME_LEN, - - passes COPY_NAME = true. */ + - passes COPY_NAME = true. - struct minimal_symbol *record_with_info (const char *name, - CORE_ADDR address, - enum minimal_symbol_type ms_type, - int section) + This variant does not return the new symbol. */ + + void record_with_info (const char *name, CORE_ADDR address, + enum minimal_symbol_type ms_type, + int section) { - return record_full (name, strlen (name), true, address, ms_type, section); + record_full (name, strlen (name), true, address, ms_type, section); } private: