From patchwork Mon Mar 4 17:49:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergio Durigan Junior X-Patchwork-Id: 31711 Received: (qmail 50798 invoked by alias); 4 Mar 2019 17:49:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 50783 invoked by uid 89); 4 Mar 2019 17:49:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=gdbreplay.c, gdbreplayc, UD:gdbreplay.c X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Mar 2019 17:49:33 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ED15981106 for ; Mon, 4 Mar 2019 17:49:31 +0000 (UTC) Received: from psique.yyz.redhat.com (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 54A4B6013C; Mon, 4 Mar 2019 17:49:29 +0000 (UTC) From: Sergio Durigan Junior To: GDB Patches Cc: Sergio Durigan Junior Subject: [PATCH] Use '$enable_unittest' instead of '$development' on gdbserver/configure.srv (for 'aarch64*-*-linux*' case) Date: Mon, 4 Mar 2019 12:49:24 -0500 Message-Id: <20190304174924.27024-1-sergiodj@redhat.com> X-IsSubscribed: yes On commit 8ecfd7bd4acd69213c06fac6de9af38299123547 ("Add parameter to allow enabling/disabling selftests via configure") it seems that I forgot to use the proper '$enable_unittest' variable when checking to see whether to add selftest-related objects to 'srv_regobj'. This causes a build failure on Aarch64 when 'development=false' (which is the case for the 8.3 branch) and 'enable_unittest=true'. This patch fixes the problem by using '$enable_unittest' instead of '$development' when performing the check. As a reminder, it's important to notice that '$enable_unittest's default value (i.e., when the option '--enable-unit-tests' is not passed to configure) is the same as '$development', so this patch doesn't affect the current build. I'd like to install this patch both on master and on the 8.3 branch. OK? gdb/gdbserver/ChangeLog: 2019-03-04 Sergio Durigan Junior * configure.srv: Use '$enable_unittest' instead of '$development' when checking whether to fill 'srv_regobj' on 'aarch64*-*-linux*' case. --- gdb/gdbserver/ChangeLog | 6 ++++++ gdb/gdbserver/configure.srv | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index b6086598fa..1cdbb63b63 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,9 @@ +2019-03-04 Sergio Durigan Junior + + * configure.srv: Use '$enable_unittest' instead of '$development' + when checking whether to fill 'srv_regobj' on 'aarch64*-*-linux*' + case. + 2019-02-27 Tom Tromey * gdbreplay.c (logchar): Handle \r\n. diff --git a/gdb/gdbserver/configure.srv b/gdb/gdbserver/configure.srv index d19d22b3a3..bec72e2b19 100644 --- a/gdb/gdbserver/configure.srv +++ b/gdb/gdbserver/configure.srv @@ -43,7 +43,7 @@ srv_linux_obj="linux-low.o linux-osdata.o linux-procfs.o linux-ptrace.o linux-wa case "${target}" in aarch64*-*-linux*) srv_regobj="arm-with-neon.o" - if $development; then + if $enable_unittests; then srv_regobj="${srv_regobj} aarch64.o" srv_regobj="${srv_regobj} linux-aarch64-tdesc-selftest.o" fi