From patchwork Wed Feb 27 04:49:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 31608 Received: (qmail 84009 invoked by alias); 27 Feb 2019 04:49:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 83982 invoked by uid 89); 27 Feb 2019 04:49:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:10026 X-HELO: mail.efficios.com Received: from mail.efficios.com (HELO mail.efficios.com) (167.114.142.138) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Feb 2019 04:49:54 +0000 Received: from localhost (ip6-localhost [IPv6:::1]) by mail.efficios.com (Postfix) with ESMTP id 67F481BF1C7 for ; Tue, 26 Feb 2019 23:49:52 -0500 (EST) Received: from mail.efficios.com ([IPv6:::1]) by localhost (mail02.efficios.com [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id FRafI3f9JxMS; Tue, 26 Feb 2019 23:49:51 -0500 (EST) Received: from localhost (ip6-localhost [IPv6:::1]) by mail.efficios.com (Postfix) with ESMTP id DB6F81BF1C3; Tue, 26 Feb 2019 23:49:51 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com DB6F81BF1C3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1551242991; bh=wiZMWdNKb4pxBAA56AFts0HsX72GRg0oU1LiOAKB6O8=; h=From:To:Date:Message-Id; b=tZvj4JcVA+gZQevyYDNyuivpJr7Ypu6NaeUJAcpBd3jaLjbHWoS7U99PLocYl5qMh q42v5HJicK0PhcWwJN80CzOh4SDQxeP2BSaM34tiebAr8kFS9+IZW5tHqd888CIpEZ uxdHO2mmhQjVS/kok8w4R9Ex7gRAgOZ+oExKBghPdbu2Ep9lbKT9/uVWZ0OqbEOhLY v+mXFxcOY992byyadMZMR2aXYOdri7UOLc5BPH0pE53caDKgI1fbz05Zs0lS9VoDAt Y6ku/hKduAYbTmWw+L1KWxr6PekKxBPQnEJrGjlZWutIbsfHoJlDjGgnNDtx+qyR0y Ci6S9NJiwdn3Q== Received: from mail.efficios.com ([IPv6:::1]) by localhost (mail02.efficios.com [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id 8FffqIRCY-pO; Tue, 26 Feb 2019 23:49:51 -0500 (EST) Received: from smarchi-efficios.lan (unknown [192.222.164.54]) by mail.efficios.com (Postfix) with ESMTPSA id B4E0B1BF1B8; Tue, 26 Feb 2019 23:49:51 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [pushed] Fix build errors in aix-thread.c Date: Tue, 26 Feb 2019 23:49:43 -0500 Message-Id: <20190227044943.3758-1-simon.marchi@efficios.com> This patch fixes a few instances of unused variable and shadowed local variable errors. gdb/ChangeLog: * aix-thread.c (ptid_cmp): Remove unused variable. (get_signaled_thread): Likewise. (store_regs_user_thread): Likewise. (store_regs_kernel_thread): Likewise. (fetch_regs_kernel_thread): Remove shadowed variable. --- gdb/ChangeLog | 8 ++++++++ gdb/aix-thread.c | 7 ------- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 1d747a7ad9..6e5176c63f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,11 @@ +2019-02-26 Simon Marchi + + * aix-thread.c (ptid_cmp): Remove unused variable. + (get_signaled_thread): Likewise. + (store_regs_user_thread): Likewise. + (store_regs_kernel_thread): Likewise. + (fetch_regs_kernel_thread): Remove shadowed variable. + 2019-02-26 Andrew Burgess * features/riscv/32bit-cpu.xml: Add register numbers. diff --git a/gdb/aix-thread.c b/gdb/aix-thread.c index fe526cdc6f..655c085734 100644 --- a/gdb/aix-thread.c +++ b/gdb/aix-thread.c @@ -670,8 +670,6 @@ giter_accum (struct thread_info *thread, void *bufp) static int ptid_cmp (ptid_t ptid1, ptid_t ptid2) { - int pid1, pid2; - if (ptid1.pid () < ptid2.pid ()) return -1; else if (ptid1.pid () > ptid2.pid ()) @@ -707,7 +705,6 @@ get_signaled_thread (void) { struct thrdsinfo64 thrinf; tid_t ktid = 0; - int result = 0; while (1) { @@ -1332,8 +1329,6 @@ fetch_regs_kernel_thread (struct regcache *regcache, int regno, } else { - struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); - if (!ptrace32 (PTT_READ_SPRS, tid, (uintptr_t) &sprs32, 0, NULL)) memset (&sprs32, 0, sizeof (sprs32)); supply_sprs32 (regcache, sprs32.pt_iar, sprs32.pt_msr, sprs32.pt_cr, @@ -1501,7 +1496,6 @@ store_regs_user_thread (const struct regcache *regcache, pthdb_pthread_t pdtid) pthdb_context_t ctx; uint32_t int32; uint64_t int64; - double dbl; if (debug_aix_thread) fprintf_unfiltered (gdb_stdlog, @@ -1593,7 +1587,6 @@ store_regs_kernel_thread (const struct regcache *regcache, int regno, double fprs[ppc_num_fprs]; struct ptxsprs sprs64; struct ptsprs sprs32; - int i; if (debug_aix_thread) fprintf_unfiltered (gdb_stdlog,