From patchwork Sun Feb 24 16:51:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 31577 Received: (qmail 113848 invoked by alias); 24 Feb 2019 16:52:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 113619 invoked by uid 89); 24 Feb 2019 16:52:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 24 Feb 2019 16:51:58 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 4DC7C400CCE37 for ; Sun, 24 Feb 2019 10:51:57 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id xx0PgpfSF2qH7xx0PgLVqK; Sun, 24 Feb 2019 10:51:57 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vnncjtCApRlruXtLxX8fcMueK/8Dh3YUtCsTxBfwO3I=; b=jyn4tcQMBjmqeaSM4zkcedZtAM p//rhJn/6h/b+0sL9xcwbdYzmAhGVyMNsB2EvS5/+IqrwRChyh+ipmWKawe+glz7n1GZJ/kR1JpFz brW0/A6OnhWyLMZiF76GPum1E; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:44502 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gxx0P-001AKk-2U; Sun, 24 Feb 2019 10:51:57 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFC 07/17] Use warning in event-loop Date: Sun, 24 Feb 2019 09:51:43 -0700 Message-Id: <20190224165153.5062-8-tom@tromey.com> In-Reply-To: <20190224165153.5062-1-tom@tromey.com> References: <20190224165153.5062-1-tom@tromey.com> Change event-loop.c to avoid printf_unfiltered in favor of warning. warning is aleady available to code in common/. gdb/ChangeLog 2019-02-24 Tom Tromey * event-loop.c (handle_file_event): Use warning, not printf_unfiltered. --- gdb/ChangeLog | 5 +++++ gdb/event-loop.c | 11 +++++------ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/gdb/event-loop.c b/gdb/event-loop.c index 496111a01c6..caa910c9f82 100644 --- a/gdb/event-loop.c +++ b/gdb/event-loop.c @@ -680,11 +680,10 @@ handle_file_event (file_handler *file_ptr, int ready_mask) /* Work in progress. We may need to tell somebody what kind of error we had. */ if (mask & POLLERR) - printf_unfiltered (_("Error detected on fd %d\n"), - file_ptr->fd); + warning (_("Error detected on fd %d"), file_ptr->fd); if (mask & POLLNVAL) - printf_unfiltered (_("Invalid or non-`poll'able fd %d\n"), - file_ptr->fd); + warning (_("Invalid or non-`poll'able fd %d"), + file_ptr->fd); file_ptr->error = 1; } else @@ -698,8 +697,8 @@ handle_file_event (file_handler *file_ptr, int ready_mask) { if (ready_mask & GDB_EXCEPTION) { - printf_unfiltered (_("Exception condition detected " - "on fd %d\n"), file_ptr->fd); + warning (_("Exception condition detected on fd %d"), + file_ptr->fd); file_ptr->error = 1; } else