From patchwork Sun Feb 24 16:51:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 31584 Received: (qmail 114939 invoked by alias); 24 Feb 2019 16:52:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 114415 invoked by uid 89); 24 Feb 2019 16:52:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.62.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 24 Feb 2019 16:52:01 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway20.websitewelcome.com (Postfix) with ESMTP id BD97A400CF465 for ; Sun, 24 Feb 2019 10:51:59 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id xx0RgyptniQerxx0RgBzSg; Sun, 24 Feb 2019 10:51:59 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lP7eXdVdOCc9bQWDDMZ1Yrv6pOlIBZO8tHvydAmWri8=; b=rpmfuGYz6IUQfRFHK4cU/rJxgc 34SwkBiTzBoDnXyjOq8uv6VuECa/eosbOdkrfNxCuhMqfUstdSvinvnlCAFHomhma60udQp0quIsZ HjxFx5QrRxx41x2V2zzXlIgj+; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:44502 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gxx0R-001AKk-I4; Sun, 24 Feb 2019 10:51:59 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFC 15/17] Move gdb_notifier comment Date: Sun, 24 Feb 2019 09:51:51 -0700 Message-Id: <20190224165153.5062-16-tom@tromey.com> In-Reply-To: <20190224165153.5062-1-tom@tromey.com> References: <20190224165153.5062-1-tom@tromey.com> This moves the gdb_notifier comment a bit lower in event-loop.c, to where it belongs. gdb/ChangeLog 2019-02-24 Tom Tromey * common/event-loop.c: Move comment. --- gdb/ChangeLog | 4 ++++ gdb/common/event-loop.c | 22 +++++++++++----------- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/gdb/common/event-loop.c b/gdb/common/event-loop.c index 62de430f067..e761ebf27f6 100644 --- a/gdb/common/event-loop.c +++ b/gdb/common/event-loop.c @@ -57,17 +57,6 @@ typedef struct file_handler } file_handler; -/* Gdb_notifier is just a list of file descriptors gdb is interested in. - These are the input file descriptor, and the target file - descriptor. We have two flavors of the notifier, one for platforms - that have the POLL function, the other for those that don't, and - only support SELECT. Each of the elements in the gdb_notifier list is - basically a description of what kind of events gdb is interested - in, for each fd. */ - -/* As of 1999-04-30 only the input file descriptor is registered with the - event loop. */ - /* Do we use poll or select ? */ #ifdef HAVE_POLL #define USE_POLL 1 @@ -82,6 +71,17 @@ static unsigned char use_poll = USE_POLL; #include #endif +/* Gdb_notifier is just a list of file descriptors gdb is interested in. + These are the input file descriptor, and the target file + descriptor. We have two flavors of the notifier, one for platforms + that have the POLL function, the other for those that don't, and + only support SELECT. Each of the elements in the gdb_notifier list is + basically a description of what kind of events gdb is interested + in, for each fd. */ + +/* As of 1999-04-30 only the input file descriptor is registered with the + event loop. */ + static struct { /* Ptr to head of file handler list. */