From patchwork Fri Feb 22 18:24:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergio Durigan Junior X-Patchwork-Id: 31557 Received: (qmail 15965 invoked by alias); 22 Feb 2019 18:24:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 15853 invoked by uid 89); 22 Feb 2019 18:24:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=indicator, carrying X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Feb 2019 18:24:55 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1A090305AD92 for ; Fri, 22 Feb 2019 18:24:54 +0000 (UTC) Received: from psique.yyz.redhat.com (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 250315D9CA; Fri, 22 Feb 2019 18:24:51 +0000 (UTC) From: Sergio Durigan Junior To: GDB Patches Cc: Sergio Durigan Junior Subject: [PATCH] Use '--readnever' when invoking GDB from gcore.in Date: Fri, 22 Feb 2019 13:24:47 -0500 Message-Id: <20190222182447.15061-1-sergiodj@redhat.com> X-IsSubscribed: yes Back when I proposed the '--readnever' feature, I somehow forgot or decided not to include the bits related to gcore.in in the original patch. This patch finally updates the gcore script to invoke GDB using '--readnever'. We've been carrying this patch on Fedora GDB for quite some time, and as expected the corefiles generated by gcore on Fedora don't have problems, which I think is the best indicator that the it's safe to generate corefiles using '--readnever'. OK to check in? gdb/ChangeLog: 2019-02-21 Sergio Durigan Junior * gcore.in: Add '--readnever' option when invoking GDB. --- gdb/ChangeLog | 4 ++++ gdb/gcore.in | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b57cc87ed9..345fdf200a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2019-02-21 Sergio Durigan Junior + + * gcore.in: Add '--readnever' option when invoking GDB. + 2019-02-21 Alan Hayward * NEWS: Update style defaults. diff --git a/gdb/gcore.in b/gdb/gcore.in index 25602396d5..b9770ea415 100644 --- a/gdb/gcore.in +++ b/gdb/gcore.in @@ -97,7 +97,8 @@ for pid in "$@" do # `