From patchwork Mon Feb 18 15:07:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Buettner X-Patchwork-Id: 31501 Received: (qmail 40017 invoked by alias); 18 Feb 2019 15:07:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 39898 invoked by uid 89); 18 Feb 2019 15:07:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=runto_main, Hx-languages-length:2949, 3rd X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Feb 2019 15:07:47 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 045E3796E8 for ; Mon, 18 Feb 2019 15:07:46 +0000 (UTC) Received: from f29-4.lan (ovpn-117-11.phx2.redhat.com [10.3.117.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C99A71001944 for ; Mon, 18 Feb 2019 15:07:45 +0000 (UTC) Date: Mon, 18 Feb 2019 08:07:45 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: [PATCH 3/4] Add tests for gdb.Value(bufobj, type) constructor Message-ID: <20190218080745.7f2554e5@f29-4.lan> In-Reply-To: <20190218075816.6f67f3d9@f29-4.lan> References: <20190218075816.6f67f3d9@f29-4.lan> MIME-Version: 1.0 X-IsSubscribed: yes gdb/testsuite/ChangeLog: * gdb.python/py-value.exp (test_value_from_buffer): New proc with call from main program. --- gdb/testsuite/gdb.python/py-value.exp | 42 +++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/gdb/testsuite/gdb.python/py-value.exp b/gdb/testsuite/gdb.python/py-value.exp index 4f04aa9417..ba7de2166e 100644 --- a/gdb/testsuite/gdb.python/py-value.exp +++ b/gdb/testsuite/gdb.python/py-value.exp @@ -510,6 +510,47 @@ proc test_float_conversion {} { gdb_test "python print(float(gdb.Value(0)))" "0\\.0" } +proc test_value_from_buffer {} { + global gdb_prompt + global gdb_py_is_py3k + + gdb_py_test_silent_cmd "python tp=gdb.lookup_type('int')" "look up int type" 0 + gdb_py_test_silent_cmd "python size_a=gdb.parse_and_eval('sizeof(a)')" \ + "find size of a" 0 + gdb_py_test_silent_cmd "python size_a0=gdb.parse_and_eval('sizeof(a\[0\])')" \ + "find size of element of a" 0 + gdb_py_test_silent_cmd "python addr=gdb.parse_and_eval('&a')" \ + "find address of a" 0 + gdb_py_test_silent_cmd "python b=gdb.selected_inferior().read_memory(addr,size_a)" \ + "read buffer from memory" 1 + gdb_test "python v=gdb.Value(b,tp); print(v)" "1" \ + "construct value from buffer" + gdb_test "python v=gdb.Value(b\[size_a0:\],tp); print(v)" "2" \ + "convert 2nd elem of buffer to value" + gdb_test "python v=gdb.Value(b\[2*size_a0:\],tp); print(v)" "3" \ + "convert 3rd elem of buffer to value" + gdb_test "python v=gdb.Value(b\[2*size_a0+1:\],tp); print(v)" \ + "TypeError: Size of type is larger than that of buffer object\..*" \ + "attempt to convert smaller buffer than size of type" + gdb_py_test_silent_cmd "python atp=tp.array(2) ; print(atp)" \ + "make array type" 0 + gdb_py_test_silent_cmd "python va=gdb.Value(b,atp)" \ + "construct array value from buffer" 0 + gdb_test "python print(va)" "\\{1, 2, 3\\}" "print array value" + gdb_test "python print(va\[0\])" "1" "print first array element" + gdb_test "python print(va\[1\])" "2" "print second array element" + gdb_test "python print(va\[2\])" "3" "print third array element" + gdb_test "python print(va\[3\])" "gdb\.error: no such vector element.*" \ + "print out of bounds array element" + gdb_py_test_silent_cmd "python atpbig=tp.array(3)" "make bigger array type" 0 + gdb_test "python vabig=gdb.Value(b,atpbig)" \ + "TypeError: Size of type is larger than that of buffer object\..*" \ + "attempt to construct large value with small buffer" + gdb_test "python v=gdb.Value(2048,tp)" \ + "TypeError: Object must support the python buffer protocol\..*" \ + "attempt to construct value from buffer with non-buffer object" +} + # Build C version of executable. C++ is built later. if { [build_inferior "${binfile}" "c"] < 0 } { return -1 @@ -538,6 +579,7 @@ if ![runto_main] then { } test_value_in_inferior +test_value_from_buffer test_inferior_function_call test_value_after_death