From patchwork Thu Dec 27 01:16:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 30850 Received: (qmail 111852 invoked by alias); 27 Dec 2018 01:16:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 111841 invoked by uid 89); 27 Dec 2018 01:16:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_SOFTFAIL, TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: barracuda.ebox.ca Received: from barracuda.ebox.ca (HELO barracuda.ebox.ca) (96.127.255.19) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Dec 2018 01:16:20 +0000 Received: from smtp.ebox.ca (smtp.electronicbox.net [96.127.255.82]) by barracuda.ebox.ca with ESMTP id OUkuqMhHWqj7vaoW (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 26 Dec 2018 20:16:18 -0500 (EST) Received: from simark.lan (unknown [192.222.164.54]) by smtp.ebox.ca (Postfix) with ESMTP id 846F7441D64; Wed, 26 Dec 2018 20:16:18 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [pushed] target.c: Remove struct keyword in range-based for Date: Wed, 26 Dec 2018 20:16:17 -0500 Message-Id: <20181227011617.32432-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 X-IsSubscribed: yes I get this when compiling with a gcc 6.3.0-based cross-compiler: CXX target.o /home/simark/src/binutils-gdb/gdb/target.c: In static member function 'static void target_terminal::restore_inferior()': /home/simark/src/binutils-gdb/gdb/target.c:396:10: error: types may not be defined in a for-range-declaration [-Werror] for (struct inferior *inf : all_inferiors ()) ^~~~~~ Accomodate it by dropping the unnecessary struct keyword. Actually, I used "::inferior", otherwise it resolves to the inferior method of the target_terminal class. gdb/ChangeLog: * target.c (target_terminal::restore_inferior): Remove struct keyword. --- gdb/ChangeLog | 4 ++++ gdb/target.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 425429e07f86..397ee0458af2 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2018-12-26 Simon Marchi + + * target.c (target_terminal::restore_inferior): Remove struct keyword. + 2018-12-26 Simon Marchi * build-id.c (build_id_to_debug_bfd): Enhance debug output. diff --git a/gdb/target.c b/gdb/target.c index 6c63255d03c4..0a6747be10e6 100644 --- a/gdb/target.c +++ b/gdb/target.c @@ -393,7 +393,7 @@ target_terminal::restore_inferior (void) { scoped_restore_current_inferior restore_inferior; - for (struct inferior *inf : all_inferiors ()) + for (::inferior *inf : all_inferiors ()) { if (inf->terminal_state == target_terminal_state::is_ours_for_output) {