[3/3] sim/common: Fix warnings: "warning: implicit declaration of function..."
Commit Message
During building of several cgen simulator's I notices the below
warnings. Adding includes fixes these.
Including config.h allows stdio.h to properly configure itself to expose
asprintf().
The other warnings for abort, free, memset, strlen are trivial.
Warnings:
../../../binutils-gdb/sim/or1k/../common/sim-watch.c: In function ‘sim_watchpoint_install’:
../../../binutils-gdb/sim/or1k/../common/sim-watch.c:415:10: warning: implicit declaration of function ‘asprintf’; did you mean ‘vasprintf’? [-Wimplicit-function-declaration]
if (asprintf (&name, "watch-%s-%s",
^~~~~~~~
vasprintf
../../../binutils-gdb/sim/lm32/../common/hw-device.c: In function ‘hw_strdup’:
../../../binutils-gdb/sim/lm32/../common/hw-device.c:59:34: warning: implicit declaration of function ‘strlen’ [-Wimplicit-function-declaration]
char *dup = hw_zalloc (me, strlen (str) + 1);
^~~~~~
../../../binutils-gdb/sim/lm32/../common/hw-events.c: In function ‘hw_event_queue_schedule’:
../../../binutils-gdb/sim/lm32/../common/hw-events.c:92:3: warning: implicit declaration of function ‘memset’ [-Wimplicit-function-declaration]
memset (&dummy, 0, sizeof dummy);
^~~~~~
../../../binutils-gdb/sim/lm32/../common/hw-handles.c: In function ‘hw_handle_remove_ihandle’:
../../../binutils-gdb/sim/lm32/../common/hw-handles.c:211:4: warning: implicit declaration of function ‘free’ [-Wimplicit-function-declaration]
free (delete);
^~~~
../../../binutils-gdb/sim/lm32/../common/sim-fpu.c: In function ‘pack_fpu’:
../../../binutils-gdb/sim/lm32/../common/sim-fpu.c:292:7: warning: implicit declaration of function ‘abort’ [-Wimplicit-function-declaration]
abort ();
^~~~~
sim/common/ChangeLog:
* sim-options.c: Include "config.h".
Include <stdio.h>.
* sim-watch.c: Include "config.h".
Include <stdio.h>.
* hw-device.c: Include "string.h".
* hw-events.c: Include "string.h".
* hw-handles.c: Include <stdlib.h>.
* sim-fpu.c: Include <stdlib.h>.
---
sim/common/hw-device.c | 4 ++++
sim/common/hw-events.c | 3 +++
sim/common/hw-handles.c | 3 +++
sim/common/sim-fpu.c | 3 +++
sim/common/sim-options.c | 2 ++
sim/common/sim-watch.c | 2 ++
6 files changed, 17 insertions(+)
@@ -27,6 +27,10 @@
#include <stdlib.h>
#endif
+#if HAVE_STRING_H
+#include <string.h>
+#endif
+
/* Address methods */
const hw_unit *
@@ -23,6 +23,9 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "sim-events.h"
+#if HAVE_STRING_H
+#include <string.h>
+#endif
/* The hw-events object is implemented using sim-events */
@@ -23,6 +23,9 @@
#include "hw-main.h"
#include "hw-base.h"
+#if HAVE_STDLIB_H
+#include <stdlib.h>
+#endif
struct hw_handle_mapping
{
@@ -41,6 +41,9 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "sim-io.h"
#include "sim-assert.h"
+#ifdef HAVE_STDLIB_H
+#include <stdlib.h>
+#endif
/* Debugging support.
If digits is -1, then print all digits. */
@@ -17,6 +17,7 @@ GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
+#include "config.h"
#include "sim-main.h"
#ifdef HAVE_STRING_H
#include <string.h>
@@ -29,6 +30,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include <stdlib.h>
#endif
#include <ctype.h>
+#include <stdio.h>
#include "libiberty.h"
#include "sim-options.h"
#include "sim-io.h"
@@ -17,12 +17,14 @@ GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
+#include "config.h"
#include "sim-main.h"
#include "sim-options.h"
#include "sim-assert.h"
#include <ctype.h>
+#include <stdio.h>
#ifdef HAVE_STRING_H
#include <string.h>