From patchwork Wed Nov 28 00:14:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 30355 Received: (qmail 50927 invoked by alias); 28 Nov 2018 00:19:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 50916 invoked by uid 89); 28 Nov 2018 00:19:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=fancy X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.180.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Nov 2018 00:19:05 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway30.websitewelcome.com (Postfix) with ESMTP id C02981310C for ; Tue, 27 Nov 2018 18:14:37 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id RnUzgtWQBRPojRnUzg2CYA; Tue, 27 Nov 2018 18:14:37 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lj+eacA1dXxFMZqtrJ9Pax3Aprv7KYbhivc91ZdWUBk=; b=c6IL80IrTiAsBe2T+zvuiB2Z+k M+vYe5pCYytYai6SpGxSFRgDIEc4y3VRtpukjSzNTgQ13xvtPZMgVMFawuqQ5xL4nQ/plPf4xyla3 omKwKcuvMhMenvDSFRVw7/VJx; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:33804 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gRnUz-004MMp-IM; Tue, 27 Nov 2018 18:14:37 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 01/16] Change wrap buffering to use a std::string Date: Tue, 27 Nov 2018 17:14:20 -0700 Message-Id: <20181128001435.12703-2-tom@tromey.com> In-Reply-To: <20181128001435.12703-1-tom@tromey.com> References: <20181128001435.12703-1-tom@tromey.com> Currently wrap buffering is implemented by allocating a string that is the same width as the window, and then writing characters into it. However, if gdb emits terminal escapes, then these could possibly overflow the buffer. To prevent this, change the wrap buffer to be a std::string and update the various uses. This also changes utils.c to always emit characters to the wrap buffer. This simplifies future patches which emit terminal escape sequences, and also makes it possible for the "echo" and "printf" commands to be used to emit terminal escapes and have these work in the TUI. gdb/ChangeLog 2018-11-27 Tom Tromey * utils.c (filter_initalized): New global. (wrap_buffer): Now a std::string. (wrap_pointer): Remove. (flush_wrap_buffer): New function. (filtered_printing_initialized, set_width, wrap_here) (fputs_maybe_filtered): Update. --- gdb/ChangeLog | 9 ++++++++ gdb/utils.c | 63 +++++++++++++++++++++------------------------------ 2 files changed, 35 insertions(+), 37 deletions(-) diff --git a/gdb/utils.c b/gdb/utils.c index 0577e64ea8..0f1953a66d 100644 --- a/gdb/utils.c +++ b/gdb/utils.c @@ -1268,13 +1268,11 @@ static bool pagination_disabled_for_command; the end of the line, we spit out a newline, the indent, and then the buffered output. */ -/* Malloc'd buffer with chars_per_line+2 bytes. Contains characters which - are waiting to be output (they have already been counted in chars_printed). - When wrap_buffer[0] is null, the buffer is empty. */ -static char *wrap_buffer; +static bool filter_initalized = false; -/* Pointer in wrap_buffer to the next character to fill. */ -static char *wrap_pointer; +/* Contains characters which are waiting to be output (they have + already been counted in chars_printed). */ +static std::string wrap_buffer; /* String to indent by if the wrap occurs. Must not be NULL if wrap_column is non-zero. */ @@ -1347,7 +1345,7 @@ init_page_info (void) int filtered_printing_initialized (void) { - return wrap_buffer != NULL; + return filter_initalized; } set_batch_flag_and_restore_page_info::set_batch_flag_and_restore_page_info () @@ -1387,8 +1385,7 @@ set_screen_size (void) rl_set_screen_size (rows, cols); } -/* Reinitialize WRAP_BUFFER according to the current value of - CHARS_PER_LINE. */ +/* Reinitialize WRAP_BUFFER. */ static void set_width (void) @@ -1396,14 +1393,8 @@ set_width (void) if (chars_per_line == 0) init_page_info (); - if (!wrap_buffer) - { - wrap_buffer = (char *) xmalloc (chars_per_line + 2); - wrap_buffer[0] = '\0'; - } - else - wrap_buffer = (char *) xrealloc (wrap_buffer, chars_per_line + 2); - wrap_pointer = wrap_buffer; /* Start it at the beginning. */ + wrap_buffer.clear (); + filter_initalized = true; } static void @@ -1521,6 +1512,18 @@ reinitialize_more_filter (void) pagination_disabled_for_command = false; } +/* Flush the wrap buffer to STREAM, if necessary. */ + +static void +flush_wrap_buffer (struct ui_file *stream) +{ + if (!wrap_buffer.empty ()) + { + fputs_unfiltered (wrap_buffer.c_str (), stream); + wrap_buffer.clear (); + } +} + /* Indicate that if the next sequence of characters overflows the line, a newline should be inserted here rather than when it hits the end. If INDENT is non-null, it is a string to be printed to indent the @@ -1546,17 +1549,11 @@ void wrap_here (const char *indent) { /* This should have been allocated, but be paranoid anyway. */ - if (!wrap_buffer) + if (!filter_initalized) internal_error (__FILE__, __LINE__, _("failed internal consistency check")); - if (wrap_buffer[0]) - { - *wrap_pointer = '\0'; - fputs_unfiltered (wrap_buffer, gdb_stdout); - } - wrap_pointer = wrap_buffer; - wrap_buffer[0] = '\0'; + flush_wrap_buffer (gdb_stdout); if (chars_per_line == UINT_MAX) /* No line overflow checking. */ { wrap_column = 0; @@ -1669,6 +1666,7 @@ fputs_maybe_filtered (const char *linebuffer, struct ui_file *stream, || top_level_interpreter () == NULL || top_level_interpreter ()->interp_ui_out ()->is_mi_like_p ()) { + flush_wrap_buffer (stream); fputs_unfiltered (linebuffer, stream); return; } @@ -1692,10 +1690,7 @@ fputs_maybe_filtered (const char *linebuffer, struct ui_file *stream, /* Print a single line. */ if (*lineptr == '\t') { - if (wrap_column) - *wrap_pointer++ = '\t'; - else - fputc_unfiltered ('\t', stream); + wrap_buffer.push_back ('\t'); /* Shifting right by 3 produces the number of tab stops we have already passed, and then adding one and shifting left 3 advances to the next tab stop. */ @@ -1704,10 +1699,7 @@ fputs_maybe_filtered (const char *linebuffer, struct ui_file *stream, } else { - if (wrap_column) - *wrap_pointer++ = *lineptr; - else - fputc_unfiltered (*lineptr, stream); + wrap_buffer.push_back (*lineptr); chars_printed++; lineptr++; } @@ -1735,8 +1727,7 @@ fputs_maybe_filtered (const char *linebuffer, struct ui_file *stream, if (wrap_column) { fputs_unfiltered (wrap_indent, stream); - *wrap_pointer = '\0'; /* Null-terminate saved stuff, */ - fputs_unfiltered (wrap_buffer, stream); /* and eject it. */ + flush_wrap_buffer (stream); /* FIXME, this strlen is what prevents wrap_indent from containing tabs. However, if we recurse to print it and count its chars, we risk trouble if wrap_indent is @@ -1745,8 +1736,6 @@ fputs_maybe_filtered (const char *linebuffer, struct ui_file *stream, if we are printing a long string. */ chars_printed = strlen (wrap_indent) + (save_chars - wrap_column); - wrap_pointer = wrap_buffer; /* Reset buffer */ - wrap_buffer[0] = '\0'; wrap_column = 0; /* And disable fancy wrap */ } }