From patchwork Sun Nov 25 22:35:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 30304 Received: (qmail 41673 invoked by alias); 25 Nov 2018 22:35:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 41645 invoked by uid 89); 25 Nov 2018 22:35:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=tui, obsolete X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.187.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 25 Nov 2018 22:35:49 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 55518400C7488 for ; Sun, 25 Nov 2018 15:45:13 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id R30Ggjd6cFxNhR30GgvOTo; Sun, 25 Nov 2018 16:35:48 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version :Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=QZ4E7iHeYe8sbvYZpHYM0zokdaEf20qtxl4dIwKjxZc=; b=U6uyky4TfUKz9sJF4hlZ0POx2t ED8r4ZljnA3Xe0v7l7bPCTcfsqc+BHnujEb9FvZd7xisX9fS/nWjUPSPOYaTsjv4s1qnc5IFSuD+V RwybLMbpN57tzheI+OTdj+Qoq; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:52706 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gR30G-0022cs-7x; Sun, 25 Nov 2018 16:35:48 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [FYI] Remove obsolete comments from field_fmt Date: Sun, 25 Nov 2018 15:35:42 -0700 Message-Id: <20181125223542.23245-1-tom@tromey.com> This removes some comments that I believe were made obsolete by the recent change to cli_ui_out::do_field_fmt. The comment in mi_ui_out probably was just copy/paste, because I think aligning never made sense in an MI context. gdb/ChangeLog 2018-11-25 Tom Tromey * ui-out.c (ui_out::field_fmt): Remove comment. * tui/tui-out.c (tui_ui_out::do_field_fmt): Remove comment. * mi/mi-out.c (mi_ui_out::do_field_fmt): Remove comment. --- gdb/ChangeLog | 6 ++++++ gdb/mi/mi-out.c | 2 -- gdb/tui/tui-out.c | 2 -- gdb/ui-out.c | 1 - 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/gdb/mi/mi-out.c b/gdb/mi/mi-out.c index ea39fe29a1..39b18b03a0 100644 --- a/gdb/mi/mi-out.c +++ b/gdb/mi/mi-out.c @@ -124,8 +124,6 @@ mi_ui_out::do_field_string (int fldno, int width, ui_align align, fprintf_unfiltered (stream, "\""); } -/* This is the only field function that does not align. */ - void mi_ui_out::do_field_fmt (int fldno, int width, ui_align align, const char *fldname, const char *format, diff --git a/gdb/tui/tui-out.c b/gdb/tui/tui-out.c index 40f736fcb2..6d4e2363f3 100644 --- a/gdb/tui/tui-out.c +++ b/gdb/tui/tui-out.c @@ -71,8 +71,6 @@ tui_ui_out::do_field_string (int fldno, int width, ui_align align, cli_ui_out::do_field_string (fldno, width, align, fldname, string); } -/* This is the only field function that does not align. */ - void tui_ui_out::do_field_fmt (int fldno, int width, ui_align align, const char *fldname, const char *format, diff --git a/gdb/ui-out.c b/gdb/ui-out.c index ebe0285b49..3d74f78543 100644 --- a/gdb/ui-out.c +++ b/gdb/ui-out.c @@ -523,7 +523,6 @@ ui_out::field_fmt (const char *fldname, const char *format, ...) int width; ui_align align; - /* Will not align, but has to call anyway. */ verify_field (&fldno, &width, &align); va_start (args, format);