From patchwork Fri Nov 23 14:11:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Hayward X-Patchwork-Id: 30269 Received: (qmail 110803 invoked by alias); 23 Nov 2018 14:11:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 110670 invoked by uid 89); 23 Nov 2018 14:11:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:229 X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr150087.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (40.107.15.87) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Nov 2018 14:11:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Wyj9oxgfcd37LUZQDmNiC5o9CpF/SKEaU2W7RJx/fc=; b=Jbo2MLJB7+fX8opQ5lTBCjpyCqgwdQV1h40ebHirTc6evbALsXoLCXjBxP5pCPM2Uzce6/QEzxOrFfufnFNWULar4erm70MzJdEmkznSQy6TeNOEoJoQdRu1d9v3OLfUebQhS+9NiBbb0Ytwwx/jJwKPKhn0w6Ksb5lyb7uAGLM= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.226.148) by DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.226.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1361.15; Fri, 23 Nov 2018 14:11:24 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::fd61:f010:9962:229]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::fd61:f010:9962:229%8]) with mapi id 15.20.1361.018; Fri, 23 Nov 2018 14:11:24 +0000 From: Alan Hayward To: "gdb-patches@sourceware.org" CC: nd , Alan Hayward Subject: [PUSHED/OBV][PATCH] GDBserver: AArch64: Remove cannot_fetch/store_register Date: Fri, 23 Nov 2018 14:11:24 +0000 Message-ID: <20181123141117.36739-1-alan.hayward@arm.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) MIME-Version: 1.0 X-IsSubscribed: yes The cannot store/fetch register functions are only used for checking if a register can be accessed using PEEKUSER/POKEUSER. The AArch64 port doesn't support this method of access, so remove the unused functions. 2018-11-23 Alan Hayward * linux-aarch64-low.c (aarch64_cannot_store_register): Remove. (aarch64_cannot_fetch_register): Likewise. (struct linux_target_ops): Update references. --- gdb/gdbserver/linux-aarch64-low.c | 20 ++------------------ 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c index 1d34e319df..181e2666ab 100644 --- a/gdb/gdbserver/linux-aarch64-low.c +++ b/gdb/gdbserver/linux-aarch64-low.c @@ -84,22 +84,6 @@ is_sve_tdesc (void) return regcache->tdesc->reg_defs.size () == AARCH64_SVE_NUM_REGS; } -/* Implementation of linux_target_ops method "cannot_store_register". */ - -static int -aarch64_cannot_store_register (int regno) -{ - return regno >= AARCH64_NUM_REGS; -} - -/* Implementation of linux_target_ops method "cannot_fetch_register". */ - -static int -aarch64_cannot_fetch_register (int regno) -{ - return regno >= AARCH64_NUM_REGS; -} - static void aarch64_fill_gregset (struct regcache *regcache, void *buf) { @@ -3041,8 +3025,8 @@ struct linux_target_ops the_low_target = { aarch64_arch_setup, aarch64_regs_info, - aarch64_cannot_fetch_register, - aarch64_cannot_store_register, + NULL, /* cannot_fetch_register */ + NULL, /* cannot_store_register */ NULL, /* fetch_register */ aarch64_get_pc, aarch64_set_pc,