diff mbox

[RFAv2,2/2] Test case for 'info variables|functions' with minimal symbols.

Message ID 20181110150048.21031-3-philippe.waroquiers@skynet.be
State New
Headers show

Commit Message

Philippe Waroquiers Nov. 10, 2018, 3 p.m. UTC
2018-11-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

	* gdb.base/info_minsym.c: New file.
	* gdb.base/info_minsym.exp: New file.
---
 gdb/testsuite/gdb.base/info_minsym.c   | 29 +++++++++++++++++++++
 gdb/testsuite/gdb.base/info_minsym.exp | 36 ++++++++++++++++++++++++++
 2 files changed, 65 insertions(+)
 create mode 100644 gdb/testsuite/gdb.base/info_minsym.c
 create mode 100644 gdb/testsuite/gdb.base/info_minsym.exp

Comments

Tom Tromey Nov. 19, 2018, 10:11 p.m. UTC | #1
>>>>> "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:

Philippe> 2018-11-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
Philippe> 	* gdb.base/info_minsym.c: New file.
Philippe> 	* gdb.base/info_minsym.exp: New file.

...

Philippe> +gdb_test_no_output "info variables -q -t int minsym" "minsym variables do not match type"
Philippe> +gdb_test_no_output "info functions -q -t int minsym" "minsym functions do not match type"

I think these lines are too long and should be split.
Otherwise the patch is ok.

Tom
Philippe Waroquiers Nov. 20, 2018, 9:19 p.m. UTC | #2
On Mon, 2018-11-19 at 15:11 -0700, Tom Tromey wrote:
> > > > > > "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
> 
> Philippe> 2018-11-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
> Philippe> 	* gdb.base/info_minsym.c: New file.
> Philippe> 	* gdb.base/info_minsym.exp: New file.
> 
> ...
> 
> Philippe> +gdb_test_no_output "info variables -q -t int minsym" "minsym variables do not match type"
> Philippe> +gdb_test_no_output "info functions -q -t int minsym" "minsym functions do not match type"
> 
> I think these lines are too long and should be split.
> Otherwise the patch is ok.
Thanks, pushed after having split the linesĀ 
(and re-run the tests on debian/x86_64).

Philippe
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.base/info_minsym.c b/gdb/testsuite/gdb.base/info_minsym.c
new file mode 100644
index 0000000000..3e28fe1b78
--- /dev/null
+++ b/gdb/testsuite/gdb.base/info_minsym.c
@@ -0,0 +1,29 @@ 
+/* This testcase is part of GDB, the GNU debugger.
+
+   Copyright 2018 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+static int minsym_var;
+
+static int minsym_fun (void)
+{
+   minsym_var++;
+}
+
+int
+main (void)
+{
+  return minsym_fun ();
+}
diff --git a/gdb/testsuite/gdb.base/info_minsym.exp b/gdb/testsuite/gdb.base/info_minsym.exp
new file mode 100644
index 0000000000..be4e33132f
--- /dev/null
+++ b/gdb/testsuite/gdb.base/info_minsym.exp
@@ -0,0 +1,36 @@ 
+# Copyright (C) 2018 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+
+# Verify 'info variables|functions'
+#    shows minimal symbols when no type matching is requested
+#    does not show minimal symbols when type matching is requested.
+
+set testfile info_minsym
+
+standard_testfile info_minsym.c
+
+# Compile the program without debugging information, to have minimal symbols.
+if {[prepare_for_testing "failed to prepare" $testfile $srcfile {c}]} {
+    return -1
+}
+
+clean_restart ${testfile}
+
+gdb_test_no_output "info variables -q -t int minsym" "minsym variables do not match type"
+gdb_test_no_output "info functions -q -t int minsym" "minsym functions do not match type"
+
+gdb_test "info variables -q minsym" "$hex  minsym_var" "minsym variables found"
+gdb_test "info functions -q minsym" "$hex  minsym_fun" "minsym functions found"