From patchwork Sun Sep 23 15:09:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 29511 Received: (qmail 33353 invoked by alias); 23 Sep 2018 15:10:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 33213 invoked by uid 89); 23 Sep 2018 15:10:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 23 Sep 2018 15:10:03 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway32.websitewelcome.com (Postfix) with ESMTP id D5D0C113312 for ; Sun, 23 Sep 2018 10:10:01 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 461Jg5krqaSey461JgV4HT; Sun, 23 Sep 2018 10:10:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kEAf7zkz+2124sVL5H/dLedr7w/MLoBmoeFfErZqdXg=; b=wqMmuNueds/JSjEbKO/vkZ7P8S tpUQrYYAx2hjyTuxwGeAzH0AcysPEiqilY9n0bAXgEjOOUDBCZaHzu0QzFmyWL97hYIdvAOFeFcNH kZoPLkam9dotlYe1fE+xd0q+x; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:38858 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g461J-000MFc-KR; Sun, 23 Sep 2018 10:10:01 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 2/7] Fix off-by-one error in complaint_internal Date: Sun, 23 Sep 2018 09:09:52 -0600 Message-Id: <20180923150957.5798-3-tom@tromey.com> In-Reply-To: <20180923150957.5798-1-tom@tromey.com> References: <20180923150957.5798-1-tom@tromey.com> complaint_internal had an off-by-one error, where it would allow one extra complaint to be issued. gdb/ChangeLog 2018-09-23 Tom Tromey * complaints.c (complaint_internal): Correctly check complaint count. --- gdb/ChangeLog | 5 +++++ gdb/complaints.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/complaints.c b/gdb/complaints.c index 03102f13ab..43ea7a18a7 100644 --- a/gdb/complaints.c +++ b/gdb/complaints.c @@ -56,7 +56,7 @@ complaint_internal (const char *fmt, ...) { va_list args; - if (counters[fmt]++ > stop_whining) + if (++counters[fmt] > stop_whining) return; va_start (args, fmt);