From patchwork Sun Sep 23 04:08:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 29506 Received: (qmail 84483 invoked by alias); 23 Sep 2018 04:08:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 84098 invoked by uid 89); 23 Sep 2018 04:08:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_RP_RNBL, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=pointed, gdb_exception X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.46.156) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 23 Sep 2018 04:08:21 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway22.websitewelcome.com (Postfix) with ESMTP id DFDD98512 for ; Sat, 22 Sep 2018 23:08:19 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 3vgxgdBEL79N33vgxgmrLF; Sat, 22 Sep 2018 23:08:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KxA5sFRFu9puXR9wCQpOnD5Wsa5tdWdUmln0Lram7pQ=; b=hb9MN+o9W/GgiF7yWWBbRowdra 3Kf3o2QvK0nG5Wb8jWKu57a7KlPIQTlpLeUkinfQZgvqA50yTBNr2BoJ6vKchP2GgzdP4yBdW6PBz 6P7u/3q5wz2SN1tuB4SZrcLvk; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:37440 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g3vgx-002UJa-KV; Sat, 22 Sep 2018 23:08:19 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 7/8] Shadowing fix in gdbscm_frame_read_var Date: Sat, 22 Sep 2018 22:08:13 -0600 Message-Id: <20180923040814.27941-8-tom@tromey.com> In-Reply-To: <20180923040814.27941-1-tom@tromey.com> References: <20180923040814.27941-1-tom@tromey.com> -Wshadow=local pointed out that the shadowing in gdbscm_frame_read_var means that the ultimate call to read_var_value will always be passed block==NULL. The fix is to remove the outer declaration. gdb/ChangeLog 2018-09-22 Tom Tromey * guile/scm-frame.c (gdbscm_frame_read_var): Remove inner declaration of "block". --- gdb/ChangeLog | 5 +++++ gdb/guile/scm-frame.c | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/guile/scm-frame.c b/gdb/guile/scm-frame.c index 3d27907e19..5a056de332 100644 --- a/gdb/guile/scm-frame.c +++ b/gdb/guile/scm-frame.c @@ -878,7 +878,6 @@ gdbscm_frame_read_var (SCM self, SCM symbol_scm, SCM rest) } else if (scm_is_string (symbol_scm)) { - const struct block *block = NULL; struct gdb_exception except = exception_none; if (! SCM_UNBNDP (block_scm))