Message ID | 20180917213334.4468-1-sergiodj@redhat.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 113036 invoked by alias); 17 Sep 2018 21:33:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 113024 invoked by uid 89); 17 Sep 2018 21:33:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=az, AZ X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Sep 2018 21:33:41 +0000 Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1D8523082E65 for <gdb-patches@sourceware.org>; Mon, 17 Sep 2018 21:33:40 +0000 (UTC) Received: from psique.yyz.redhat.com (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id E75633091376; Mon, 17 Sep 2018 21:33:36 +0000 (UTC) From: Sergio Durigan Junior <sergiodj@redhat.com> To: GDB Patches <gdb-patches@sourceware.org> Cc: Sergio Durigan Junior <sergiodj@redhat.com> Subject: [PATCH] Expect for "@" when doing "complete break ada" on gdb.ada/complete.exp Date: Mon, 17 Sep 2018 17:33:34 -0400 Message-Id: <20180917213334.4468-1-sergiodj@redhat.com> X-IsSubscribed: yes |
Commit Message
Sergio Durigan Junior
Sept. 17, 2018, 9:33 p.m. UTC
Currently, gdb.ada/complete.exp's "complete break ada" test fails because the regexp used to match the command's output doesn't expect "@", but we have an output like: ... complete break ada break ada.assertions.assert break ada.calendar.arithmetic.difference break ada.calendar.arithmetic_operations.add break ada.calendar.arithmetic_operations.add.cold break ada.calendar.arithmetic_operations.add@plt break ada.calendar.arithmetic_operations.difference break ada.calendar.arithmetic_operations.difference@plt ... This patch adds "@" to the regexp, unbreaking the test. OK? gdb/testsuite/ChangeLog: 2018-09-17 Sergio Durigan Junior <sergiodj@redhat.com> * gdb.ada/complete.exp: Expect for "@" when doing "complete break ada". --- gdb/testsuite/gdb.ada/complete.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Sergio, Thanks for the patch! > Currently, gdb.ada/complete.exp's "complete break ada" test fails > because the regexp used to match the command's output doesn't expect > "@", but we have an output like: > > ... > complete break ada > break ada.assertions.assert > break ada.calendar.arithmetic.difference > break ada.calendar.arithmetic_operations.add > break ada.calendar.arithmetic_operations.add.cold > break ada.calendar.arithmetic_operations.add@plt > break ada.calendar.arithmetic_operations.difference > break ada.calendar.arithmetic_operations.difference@plt > ... > > This patch adds "@" to the regexp, unbreaking the test. > > OK? > > gdb/testsuite/ChangeLog: > 2018-09-17 Sergio Durigan Junior <sergiodj@redhat.com> > > * gdb.ada/complete.exp: Expect for "@" when doing "complete > break ada". I can see this behavior, but only when I link with the shared version of libgnat. For us at least, on x86_64-linux, this is not the default. That's probably why I wasn't seeing this. This is OK. > gdb/testsuite/gdb.ada/complete.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.ada/complete.exp b/gdb/testsuite/gdb.ada/complete.exp > index cb9e4ae7ff..ac2bf85077 100644 > --- a/gdb/testsuite/gdb.ada/complete.exp > +++ b/gdb/testsuite/gdb.ada/complete.exp > @@ -218,7 +218,7 @@ gdb_test_no_output "set max-completions unlimited" > > set test "complete break ada" > gdb_test_multiple "$test" $test { > - -re "^$test$eol\(break ada(\[a-z0-9._\])*$eol\)+$gdb_prompt $" { > + -re "^$test$eol\(break ada(\[a-z0-9._@\])*$eol\)+$gdb_prompt $" { > pass $test > } > -re "\[A-Z\].*$gdb_prompt $" { > -- > 2.17.1
On Tuesday, September 18 2018, Joel Brobecker wrote: > Hi Sergio, Hey Joel, > Thanks for the patch! My pleasure :-). >> Currently, gdb.ada/complete.exp's "complete break ada" test fails >> because the regexp used to match the command's output doesn't expect >> "@", but we have an output like: >> >> ... >> complete break ada >> break ada.assertions.assert >> break ada.calendar.arithmetic.difference >> break ada.calendar.arithmetic_operations.add >> break ada.calendar.arithmetic_operations.add.cold >> break ada.calendar.arithmetic_operations.add@plt >> break ada.calendar.arithmetic_operations.difference >> break ada.calendar.arithmetic_operations.difference@plt >> ... >> >> This patch adds "@" to the regexp, unbreaking the test. >> >> OK? >> >> gdb/testsuite/ChangeLog: >> 2018-09-17 Sergio Durigan Junior <sergiodj@redhat.com> >> >> * gdb.ada/complete.exp: Expect for "@" when doing "complete >> break ada". > > I can see this behavior, but only when I link with the shared > version of libgnat. For us at least, on x86_64-linux, this is not > the default. That's probably why I wasn't seeing this. Ah, I see. TBH, I haven't investigate this further. I'm glad you can reproduce it there. > This is OK. Thanks, pushed. 7a6d2b458f95030f433a0dcdabd5cda7ee695a9b
diff --git a/gdb/testsuite/gdb.ada/complete.exp b/gdb/testsuite/gdb.ada/complete.exp index cb9e4ae7ff..ac2bf85077 100644 --- a/gdb/testsuite/gdb.ada/complete.exp +++ b/gdb/testsuite/gdb.ada/complete.exp @@ -218,7 +218,7 @@ gdb_test_no_output "set max-completions unlimited" set test "complete break ada" gdb_test_multiple "$test" $test { - -re "^$test$eol\(break ada(\[a-z0-9._\])*$eol\)+$gdb_prompt $" { + -re "^$test$eol\(break ada(\[a-z0-9._@\])*$eol\)+$gdb_prompt $" { pass $test } -re "\[A-Z\].*$gdb_prompt $" {