From patchwork Tue Sep 4 10:55:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 29185 Received: (qmail 89488 invoked by alias); 4 Sep 2018 10:59:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 53236 invoked by uid 89); 4 Sep 2018 10:55:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=violation X-HELO: mail-wr1-f67.google.com Received: from mail-wr1-f67.google.com (HELO mail-wr1-f67.google.com) (209.85.221.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Sep 2018 10:55:47 +0000 Received: by mail-wr1-f67.google.com with SMTP id v17-v6so3444049wrr.9 for ; Tue, 04 Sep 2018 03:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=puwsqEaMGcK3fZw5JO1f/ITLII/RbJUNAHyRUNHqWBA=; b=SNhBncslsYKlzeLn7rEXXfIW9/ZfOSs7UG7f9AArTfWBFBVP+Jeaf5ic5ghps2ydWv 9QuogDw8xVHiccErfSi7LLPV4eENz3l2YRZqhF7tko+/iOG3liP7px0c+OitrTfhumZv zweTHZZtgv1hLlhaopDzfs3g8U0MPXmBEWJ2LKF+cVfAiVYZg4/n1DhV+FblOPkElEAQ Bvmm1iK6JAWOZrySQGm5PiISzyhsbiAaEUmB7gYevSwkOs1SDwPGf9woqpoPioYKcB/M pYIHMhhX0oYaiWZDyAXPIQJhMOD74bP3uYGvUVblz2fsD9J/eRhZkAgWDr/27SkEPH9m WM2A== Return-Path: Received: from localhost ([81.141.199.36]) by smtp.gmail.com with ESMTPSA id b189-v6sm13727889wmd.39.2018.09.04.03.55.44 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Sep 2018 03:55:44 -0700 (PDT) Date: Tue, 4 Sep 2018 11:55:44 +0100 From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: New ARI warning Tue Sep 4 01:56:28 UTC 2018 Message-ID: <20180904105544.GC22193@embecosm.com> References: <20180904015628.GA88813@sourceware.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180904015628.GA88813@sourceware.org> X-Fortune: You will be recognized and honored as a community leader. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes * GDB Administrator [2018-09-04 01:56:28 +0000]: > 474a475 > > gdb/riscv-tdep.c:2560: code: OP eol: Do not use &&, or || at the end of a line > gdb/riscv-tdep.c:2560: = (get_frame_register_signed (this_frame, cache->frame_base_reg) + Sorry for that. Pushed the patch below to fix this issue. Thanks, Andrew --- gdb/riscv: Fix an ARI warning This patch fixes an ARI violation in riscv-tdep.c (line ends with '+'). gdb/ChangeLog: * riscv-tdep.c (riscv_frame_cache): Fix ARI warning, don't end a line with '+'. --- gdb/ChangeLog | 5 +++++ gdb/riscv-tdep.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c index b2247b59f6f..254914c9c7e 100644 --- a/gdb/riscv-tdep.c +++ b/gdb/riscv-tdep.c @@ -2557,8 +2557,8 @@ riscv_frame_cache (struct frame_info *this_frame, void **this_cache) /* We can now calculate the frame base address. */ cache->frame_base - = (get_frame_register_signed (this_frame, cache->frame_base_reg) + - cache->frame_base_offset); + = (get_frame_register_signed (this_frame, cache->frame_base_reg) + + cache->frame_base_offset); if (riscv_debug_unwinder) fprintf_unfiltered (gdb_stdlog, "Frame base is %s ($%s + 0x%x)\n", core_addr_to_string (cache->frame_base),