From patchwork Mon Sep 3 19:03:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 29175 Received: (qmail 69133 invoked by alias); 3 Sep 2018 19:04:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 69117 invoked by uid 89); 3 Sep 2018 19:04:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=simplifies, flex, INTL X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.119) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Sep 2018 19:04:24 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 6316E1786E7 for ; Mon, 3 Sep 2018 14:04:23 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id wu8pfPoJSaSeywu91fstte; Mon, 03 Sep 2018 14:04:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yRfzglezsJ3yhE/rM/vFIcv/hVvtWUi01h+pxCfX7so=; b=HATdHUT8wXgj41a1knTauhconU ZRjaLxTZTxhamEoY7y5JDHP+UHqzGhGageaXML7biQ5UeKoeUJYg10WZNVVtnpzo1qxYcVSahL4rp KtLGXtY4BJ7Hu640UxQWbdVXs; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:58122 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fwu8p-002kCu-4T; Mon, 03 Sep 2018 14:04:03 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 3/4] Simplify ada-exp.o rule Date: Mon, 3 Sep 2018 13:03:58 -0600 Message-Id: <20180903190359.12817-4-tom@tromey.com> In-Reply-To: <20180903190359.12817-1-tom@tromey.com> References: <20180903190359.12817-1-tom@tromey.com> The ada-exp.o rule no longer needs to pass -Wno-old-style-definition to the compiler, as this option has no meaning in C++. So, This patch simplifies the explicit ada-exp.o rule in the Makefile. The rule is still needed because, according to the comment, ada-exp.c may appear in the srcdir. gdb/ChangeLog 2018-09-03 Tom Tromey * Makefile.in (GDB_WARN_CFLAGS_NO_DEFS): Remove. (ada-exp.o): Update. --- gdb/ChangeLog | 5 +++++ gdb/Makefile.in | 8 +------- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/gdb/Makefile.in b/gdb/Makefile.in index 16aac9dadf2..c76a4e4394c 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -199,9 +199,6 @@ WERROR_CFLAGS = @WERROR_CFLAGS@ GDB_WARN_CFLAGS = $(WARN_CFLAGS) GDB_WERROR_CFLAGS = $(WERROR_CFLAGS) -GDB_WARN_CFLAGS_NO_DEFS = `echo " $(GDB_WARN_CFLAGS) " \ - | sed "s/ -Wold-style-definition / -Wno-old-style-definition /g"` - RDYNAMIC = @RDYNAMIC@ # Where is the INTL library? Typically in ../intl. @@ -2385,11 +2382,8 @@ ALLDEPFILES = \ # development builds. ADA_EXP_C = `if test -f ada-exp.c; then echo ada-exp.c; else echo $(srcdir)/ada-exp.c; fi` -# Some versions of flex give output that triggers -# -Wold-style-definition. ada-exp.o: ada-exp.c - $(ECHO_CXX) $(COMPILE.pre) $(INTERNAL_CFLAGS) \ - $(GDB_WARN_CFLAGS_NO_DEFS) $(COMPILE.post) $(ADA_EXP_C) + $(COMPILE) $(ADA_EXP_C) $(POSTCOMPILE) # Message files. Based on code in gcc/Makefile.in.