From patchwork Wed Aug 29 21:34:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 29116 Received: (qmail 123992 invoked by alias); 29 Aug 2018 21:34:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 123732 invoked by uid 89); 29 Aug 2018 21:34:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1879 X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Aug 2018 21:34:45 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 08878265C9D for ; Wed, 29 Aug 2018 16:34:44 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id v86tf1cmt79N3v86ufFwd0; Wed, 29 Aug 2018 16:34:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version :Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cmjLyy102AQmTWYL7TF/OTi4q9tXvXhCYfjVJWext7M=; b=oKSubHB65Sc+UZyFsieluJ1Fu4 KELsAczumGMVCqUJwMcSz5pamTJHEFbtLHC3k5HgQxSdD2gW6JaBJPITeyuGLtK3GkTUMdP3V6nJi Rjo5zyrj3nzEltatilL/FLdcD; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:36628 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fv86t-003lsu-Oj; Wed, 29 Aug 2018 16:34:43 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [FYI] Use core_addr_to_string_nz in csky_analyze_prologue Date: Wed, 29 Aug 2018 15:34:30 -0600 Message-Id: <20180829213430.21317-1-tom@tromey.com> One of the buildbot builders had a failure on a recent try run: ../../binutils-gdb/gdb/csky-tdep.c: In function CORE_ADDR csky_analyze_prologue(gdbarch*, CORE_ADDR, CORE_ADDR, CORE_ADDR, frame_info*, csky_unwind_cache*, lr_type_t): ../../binutils-gdb/gdb/csky-tdep.c:1107:23: error: format %lx expects argument of type long unsigned int, but argument 3 has type CORE_ADDR {aka long long unsigned int} [-Werror=format=] "0x%lx\n", addr); ^ ../../binutils-gdb/gdb/csky-tdep.c:1419:12: error: format %lx expects argument of type long unsigned int, but argument 3 has type CORE_ADDR {aka long long unsigned int} [-Werror=format=] addr); ^ The fix is to use core_addr_to_string_nz rather than %lx in csky-tdep.c. Tested by rebuilding. I'm checking this in. gdb/ChangeLog 2018-08-29 Tom Tromey * csky-tdep.c (csky_analyze_prologue): Use core_addr_to_string_nz. --- gdb/ChangeLog | 5 +++++ gdb/csky-tdep.c | 8 ++++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/gdb/csky-tdep.c b/gdb/csky-tdep.c index 972ac59affe..95bcead8771 100644 --- a/gdb/csky-tdep.c +++ b/gdb/csky-tdep.c @@ -1103,8 +1103,8 @@ csky_analyze_prologue (struct gdbarch *gdbarch, "csky: found stack adjustment of" " 0x%x bytes.\n", adjust); fprintf_unfiltered (gdb_stdlog, - "csky: skipping to new address " - "0x%lx\n", addr); + "csky: skipping to new address %s\n", + core_addr_to_string_nz (addr)); fprintf_unfiltered (gdb_stdlog, "csky: continuing\n"); } @@ -1415,8 +1415,8 @@ csky_analyze_prologue (struct gdbarch *gdbarch, "found stack adjustment of 0x%x" " bytes.\n", adjust); fprintf_unfiltered (gdb_stdlog, "csky: " - "skipping to new address 0x%lx\n", - addr); + "skipping to new address %s\n", + core_addr_to_string_nz (addr)); fprintf_unfiltered (gdb_stdlog, "csky: continuing\n"); } continue;