diff mbox

[RFAv2,5/6] Announce changes in NEWS to info [args|functions|locals|variables]

Message ID 20180826165359.1600-6-philippe.waroquiers@skynet.be
State New
Headers show

Commit Message

Philippe Waroquiers Aug. 26, 2018, 4:53 p.m. UTC
Announce changes in NEWS to info [args|functions|locals|variables]

gdb/ChangeLog
2018-08-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

        * NEWS: Mention changes to 'info [args|functions|locals|variables]'
---
 gdb/NEWS | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Eli Zaretskii Aug. 26, 2018, 6:21 p.m. UTC | #1
> From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Date: Sun, 26 Aug 2018 18:53:58 +0200
> 
> +info args [-q] [-t TYPEREGEXP] [NAMEREGEXP]
> +info functions [-q] [-t TYPEREGEXP] [NAMEREGEXP]
> +info locals [-q] [-t TYPEREGEXP] [NAMEREGEXP]
> +info variables [-q] [-t TYPEREGEXP] [NAMEREGEXP]
> +  These commands can now print only the searched entities
> +  matching the provided regexp(s), giving a condition
> +  on the entity names or entity types.

I'd lose "searched".  How about the following?

  These commands can now print only the entities whose names and/or
  types match the specified regular expressions.

> +                                         The flag -q
> +  disables printing headers or informations messages.

"informative messages", I guess?

Thanks.
Philippe Waroquiers Aug. 27, 2018, 4:39 a.m. UTC | #2
Thanks for the review, I will do the updates as suggested
in this and the other mail.

One question below.

Philippe


On Sun, 2018-08-26 at 21:21 +0300, Eli Zaretskii wrote:
> > From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> > Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> > Date: Sun, 26 Aug 2018 18:53:58 +0200
> > 
> > +info args [-q] [-t TYPEREGEXP] [NAMEREGEXP]
> > +info functions [-q] [-t TYPEREGEXP] [NAMEREGEXP]
> > +info locals [-q] [-t TYPEREGEXP] [NAMEREGEXP]
> > +info variables [-q] [-t TYPEREGEXP] [NAMEREGEXP]
> > +  These commands can now print only the searched entities
> > +  matching the provided regexp(s), giving a condition
> > +  on the entity names or entity types.
> 
> I'd lose "searched".  How about the following?
> 
>   These commands can now print only the entities whose names and/or
>   types match the specified regular expressions.
> 
> > +                                         The flag -q
> > +  disables printing headers or informations messages.
> 
> "informative messages", I guess?
These are the messages explaining why no entity was printed, e.g
  (gdb) info arg -t xxxx yyyy
  No matching arguments.
  (gdb) info arg -q -t xxxx yyyy
  (gdb) 

  (gdb) info arg -t xxxx yyyy   
  No symbol table info available.
  (gdb) info arg -q -t xxxx yyyy
  (gdb) 

So, what about (like in the texinfo doc):          The flag -q
   disables printing headers or messages explaining why no entities
   have been printed.
?

Philippe
Eli Zaretskii Aug. 27, 2018, 2:58 p.m. UTC | #3
> From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Cc: gdb-patches@sourceware.org
> Date: Mon, 27 Aug 2018 06:39:20 +0200
> 
> > > +  disables printing headers or informations messages.
> > 
> > "informative messages", I guess?
> These are the messages explaining why no entity was printed, e.g
>   (gdb) info arg -t xxxx yyyy
>   No matching arguments.
>   (gdb) info arg -q -t xxxx yyyy
>   (gdb) 
> 
>   (gdb) info arg -t xxxx yyyy   
>   No symbol table info available.
>   (gdb) info arg -q -t xxxx yyyy
>   (gdb) 
> 
> So, what about (like in the texinfo doc):          The flag -q
>    disables printing headers or messages explaining why no entities
>    have been printed.
> ?

Fine with me, thanks.
diff mbox

Patch

diff --git a/gdb/NEWS b/gdb/NEWS
index a7a3674375..d2ff55db2c 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -36,6 +36,15 @@  maint show dwarf unwinders
 
 * Changed commands
 
+info args [-q] [-t TYPEREGEXP] [NAMEREGEXP]
+info functions [-q] [-t TYPEREGEXP] [NAMEREGEXP]
+info locals [-q] [-t TYPEREGEXP] [NAMEREGEXP]
+info variables [-q] [-t TYPEREGEXP] [NAMEREGEXP]
+  These commands can now print only the searched entities
+  matching the provided regexp(s), giving a condition
+  on the entity names or entity types.  The flag -q
+  disables printing headers or informations messages.
+
 thread apply [all | COUNT | -COUNT] [FLAG]... COMMAND
   The 'thread apply' command accepts new FLAG arguments.
   FLAG arguments allow to control what output to produce and how to handle