diff mbox

[3/9] Change `label_symbols' to std::vector in linespec.c structures

Message ID 20180810232534.481-4-keiths@redhat.com
State New
Headers show

Commit Message

Keith Seitz Aug. 10, 2018, 11:25 p.m. UTC
This patch converts linespec.c's linespec.label_symbols member from a
VEC to a std::vector.

gdb/ChangeLog:

	* linespec.c (struct linespec) <label_symbols>: Change type to
	std::vector.  Update all users.
	(find_label_symbols_in_block): Change `result' parameter to
	std::vector.  Update all callers.
	(find_label_symbols): Return std::vector.  Update all callers.
---
 gdb/ChangeLog  |  8 ++++++++
 gdb/linespec.c | 54 +++++++++++++++++++++++++++---------------------------
 2 files changed, 35 insertions(+), 27 deletions(-)

Comments

Tom Tromey Aug. 11, 2018, 2:50 p.m. UTC | #1
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> This patch converts linespec.c's linespec.label_symbols member from a
Keith> VEC to a std::vector.

Keith> gdb/ChangeLog:

Keith> 	* linespec.c (struct linespec) <label_symbols>: Change type to
Keith> 	std::vector.  Update all users.
Keith> 	(find_label_symbols_in_block): Change `result' parameter to
Keith> 	std::vector.  Update all callers.
Keith> 	(find_label_symbols): Return std::vector.  Update all callers.

Thanks.  This is ok.

Tom
diff mbox

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5a71381262..b3f5a5d039 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,13 @@ 
 YYYY-MM-DD  Keith Seitz  <keiths@redhat.com>
 
+	* linespec.c (struct linespec) <label_symbols>: Change type to
+	std::vector.  Update all users.
+	(find_label_symbols_in_block): Change `result' parameter to
+	std::vector.  Update all callers.
+	(find_label_symbols): Return std::vector.  Update all callers.
+
+YYYY-MM-DD  Keith Seitz  <keiths@redhat.com>
+
 	* linespec.c (struct linespec) <function_symbols>: Change type to
 	std::vector.  Update all users.
 	(struct collect_info) <function_symbols>: Likewise.
diff --git a/gdb/linespec.c b/gdb/linespec.c
index 8070db68ec..4e7f9b08b0 100644
--- a/gdb/linespec.c
+++ b/gdb/linespec.c
@@ -123,7 +123,7 @@  struct linespec
      or both must be non-NULL.  */
   struct
   {
-    VEC (symbolp) *label_symbols;
+    std::vector<symbol *> *label_symbols;
     std::vector<symbol *> *function_symbols;
   } labels;
 };
@@ -352,7 +352,7 @@  static std::vector<symtab_and_line> decode_objc (struct linespec_state *self,
 static std::vector<symtab *> *symtabs_from_filename
   (const char *, struct program_space *pspace);
 
-static VEC (symbolp) *find_label_symbols
+static std::vector<symbol *> *find_label_symbols
   (struct linespec_state *self, std::vector<symbol *> *function_symbols,
    std::vector<symbol *> *label_funcs_ret, const char *name,
    bool completion_mode = false);
@@ -1767,7 +1767,7 @@  linespec_parse_basic (linespec_parser *parser)
   gdb::unique_xmalloc_ptr<char> name;
   linespec_token token;
   std::vector<symbol *> symbols;
-  VEC (symbolp) *labels;
+  std::vector<symbol *> *labels;
   VEC (bound_minimal_symbol_d) *minimal_symbols;
 
   /* Get the next token.  */
@@ -2241,12 +2241,9 @@  convert_linespec_to_sals (struct linespec_state *state, linespec_p ls)
   if (ls->labels.label_symbols != NULL)
     {
       /* We have just a bunch of functions/methods or labels.  */
-      int i;
-      struct symtab_and_line sal;
-      struct symbol *sym;
-
-      for (i = 0; VEC_iterate (symbolp, ls->labels.label_symbols, i, sym); ++i)
+      for (const auto &sym : *ls->labels.label_symbols)
 	{
+	  struct symtab_and_line sal;
 	  struct program_space *pspace = SYMTAB_PSPACE (symbol_symtab (sym));
 
 	  if (symbol_to_sal (&sal, state->funfirstline, sym)
@@ -2388,7 +2385,7 @@  convert_explicit_location_to_linespec (struct linespec_state *self,
 				       struct line_offset line_offset)
 {
   std::vector<symbol *> symbols;
-  VEC (symbolp) *labels;
+  std::vector<symbol *> *labels;
   VEC (bound_minimal_symbol_d) *minimal_symbols;
 
   result->explicit_loc.func_name_match_type = fname_match_type;
@@ -2780,9 +2777,7 @@  linespec_parser_delete (void *arg)
   if (PARSER_RESULT (parser)->minimal_symbols != NULL)
     VEC_free (bound_minimal_symbol_d, PARSER_RESULT (parser)->minimal_symbols);
 
-  if (PARSER_RESULT (parser)->labels.label_symbols != NULL)
-    VEC_free (symbolp, PARSER_RESULT (parser)->labels.label_symbols);
-
+  delete PARSER_RESULT (parser)->labels.label_symbols;
   delete PARSER_RESULT (parser)->labels.function_symbols;
 
   linespec_state_destructor (PARSER_STATE (parser));
@@ -2917,20 +2912,21 @@  complete_label (completion_tracker &tracker,
 		const char *label_name)
 {
   std::vector<symbol *> label_function_symbols;
-  VEC (symbolp) *labels
+  std::vector<symbol *> *labels
     = find_label_symbols (PARSER_STATE (parser),
 			  PARSER_RESULT (parser)->function_symbols,
 			  &label_function_symbols,
 			  label_name, true);
 
-  symbol *label;
-  for (int ix = 0;
-       VEC_iterate (symbolp, labels, ix, label); ++ix)
+  if (labels != nullptr)
     {
-      char *match = xstrdup (SYMBOL_SEARCH_NAME (label));
-      tracker.add_completion (gdb::unique_xmalloc_ptr<char> (match));
+      for (const auto &label : *labels)
+	{
+	  char *match = xstrdup (SYMBOL_SEARCH_NAME (label));
+	  tracker.add_completion (gdb::unique_xmalloc_ptr<char> (match));
+	}
+      delete labels;
     }
-  VEC_free (symbolp, labels);
 }
 
 /* See linespec.h.  */
@@ -4045,7 +4041,7 @@  static void
 find_label_symbols_in_block (const struct block *block,
 			     const char *name, struct symbol *fn_sym,
 			     bool completion_mode,
-			     VEC (symbolp) **result,
+			     std::vector<symbol *> *result,
 			     std::vector<symbol *> *label_funcs_ret)
 {
   if (completion_mode)
@@ -4063,7 +4059,7 @@  find_label_symbols_in_block (const struct block *block,
 				     SYMBOL_DOMAIN (sym), LABEL_DOMAIN)
 	      && cmp (SYMBOL_SEARCH_NAME (sym), name, name_len) == 0)
 	    {
-	      VEC_safe_push (symbolp, *result, sym);
+	      result->push_back (sym);
 	      label_funcs_ret->push_back (fn_sym);
 	    }
 	}
@@ -4074,19 +4070,21 @@  find_label_symbols_in_block (const struct block *block,
 
       if (sym != NULL)
 	{
-	  VEC_safe_push (symbolp, *result, sym);
+	  result->push_back (sym);
 	  label_funcs_ret->push_back (fn_sym);
 	}
     }
 }
 
-/* Return all labels that match name NAME in FUNCTION_SYMBOLS.  Return
-   the actual function symbol in which the label was found in
+/* Return all labels that match name NAME in FUNCTION_SYMBOLS or NULL
+   if no matches were found.
+
+   Return the actual function symbol in which the label was found in
    LABEL_FUNC_RET.  If COMPLETION_MODE is true, then NAME is
    interpreted as a label name prefix.  Otherwise, only labels named
    exactly NAME match.  */
 
-static VEC (symbolp) *
+static std::vector<symbol *> *
 find_label_symbols (struct linespec_state *self,
 		    std::vector<symbol *> *function_symbols,
 		    std::vector<symbol *> *label_funcs_ret, const char *name,
@@ -4094,7 +4092,7 @@  find_label_symbols (struct linespec_state *self,
 {
   const struct block *block;
   struct symbol *fn_sym;
-  VEC (symbolp) *result = NULL;
+  std::vector<symbol *> result;
 
   if (function_symbols == NULL)
     {
@@ -4124,7 +4122,9 @@  find_label_symbols (struct linespec_state *self,
 	}
     }
 
-  return result;
+  if (!result.empty ())
+    return new std::vector<symbol *> (std::move (result));
+  return nullptr;
 }