From patchwork Sat Jul 21 18:47:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 28561 Received: (qmail 19868 invoked by alias); 21 Jul 2018 18:47:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 19106 invoked by uid 89); 21 Jul 2018 18:47:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 21 Jul 2018 18:47:24 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway33.websitewelcome.com (Postfix) with ESMTP id CB5361592 for ; Sat, 21 Jul 2018 13:47:22 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id gwuYfYBbO79N3gwuYftsht; Sat, 21 Jul 2018 13:47:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aVbuMrbyZ2myXjIiQGrqZ/C1lXBmUjfOcA4gOTuOGkw=; b=tg5nOeGBQlg5rv3YZKrWlJO/Rj whAM5pO4fvKNDn4x8J0OCF+w2bMMzt6d1QMVowSJ6v5Sux/DO8+EQjrSSOoztGoAHJ2C8t7s++GV4 KWiS1W7go+7jbpbX3f3+E1Y9c; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:44394 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fgwuY-002Auc-Jd; Sat, 21 Jul 2018 13:47:22 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA v2 02/13] Remove an unused variable from spu_get_overlay_table Date: Sat, 21 Jul 2018 12:47:09 -0600 Message-Id: <20180721184720.3263-3-tom@tromey.com> In-Reply-To: <20180721184720.3263-1-tom@tromey.com> References: <20180721184720.3263-1-tom@tromey.com> This removes an unused variable from spu_get_overlay_table, replacing it with an explanatory comment. gdb/ChangeLog 2018-07-21 Tom Tromey * spu-tdep.c (spu_get_overlay_table): Remove unused variable. --- gdb/ChangeLog | 4 ++++ gdb/spu-tdep.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/gdb/spu-tdep.c b/gdb/spu-tdep.c index c85a7407871..6ae37f58c7a 100644 --- a/gdb/spu-tdep.c +++ b/gdb/spu-tdep.c @@ -1820,8 +1820,8 @@ spu_get_overlay_table (struct objfile *objfile) { CORE_ADDR vma = extract_unsigned_integer (ovly_table + 16*i + 0, 4, byte_order); - CORE_ADDR size = extract_unsigned_integer (ovly_table + 16*i + 4, - 4, byte_order); + /* Note that this skips the "size" entry, which is at offset + 4. */ CORE_ADDR pos = extract_unsigned_integer (ovly_table + 16*i + 8, 4, byte_order); CORE_ADDR buf = extract_unsigned_integer (ovly_table + 16*i + 12,