diff mbox

[RFA,v2,02/13] Remove an unused variable from spu_get_overlay_table

Message ID 20180721184720.3263-3-tom@tromey.com
State New, archived
Headers

Commit Message

Tom Tromey July 21, 2018, 6:47 p.m. UTC 
  This removes an unused variable from spu_get_overlay_table, replacing
it with an explanatory comment.

gdb/ChangeLog
2018-07-21  Tom Tromey  <tom@tromey.com>

	* spu-tdep.c (spu_get_overlay_table): Remove unused variable.
---
 gdb/ChangeLog  | 4 ++++
 gdb/spu-tdep.c | 4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)

Comments

Simon Marchi July 22, 2018, 2:06 a.m. UTC | #1 
On 2018-07-21 02:47 PM, Tom Tromey wrote:
> This removes an unused variable from spu_get_overlay_table, replacing
> it with an explanatory comment.

LGTM, but let's ping Ulrich just to be sure.

Simon
diff mbox

Patch

diff --git a/gdb/spu-tdep.c b/gdb/spu-tdep.c
index c85a7407871..6ae37f58c7a 100644
--- a/gdb/spu-tdep.c
+++ b/gdb/spu-tdep.c
@@ -1820,8 +1820,8 @@  spu_get_overlay_table (struct objfile *objfile)
     {
       CORE_ADDR vma  = extract_unsigned_integer (ovly_table + 16*i + 0,
 						 4, byte_order);
-      CORE_ADDR size = extract_unsigned_integer (ovly_table + 16*i + 4,
-						 4, byte_order);
+      /* Note that this skips the "size" entry, which is at offset
+	 4.  */
       CORE_ADDR pos  = extract_unsigned_integer (ovly_table + 16*i + 8,
 						 4, byte_order);
       CORE_ADDR buf  = extract_unsigned_integer (ovly_table + 16*i + 12,