From patchwork Fri Jul 20 04:27:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 28500 Received: (qmail 11497 invoked by alias); 20 Jul 2018 04:27:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 11388 invoked by uid 89); 20 Jul 2018 04:27:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=tus X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (50.116.127.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Jul 2018 04:27:53 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 21666CB4F for ; Thu, 19 Jul 2018 23:27:52 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id gN1EfQgJySjJAgN1EfDGbm; Thu, 19 Jul 2018 23:27:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RHZE80qPrq2R6F4vOfKROtXeXzqd1HWb5MpBrGq/c/8=; b=GhX6wOzAiAuiGZ9+7R9K0nDBdS SrUi3ngNwWAMeeV0y0lXYnBeDHG1oGx+DIijfXATmMvH107mZRscsxUDYKcgIEu6FI5EBglnRaSJB zCBkqSM0+9UZ9tcyef8eaq/Z3; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:39336 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fgN1D-003pgz-Tk; Thu, 19 Jul 2018 23:27:52 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA v2 07/23] Do not look at file symbols when reading psymtabs Date: Thu, 19 Jul 2018 22:27:31 -0600 Message-Id: <20180720042747.18473-8-tom@tromey.com> In-Reply-To: <20180720042747.18473-1-tom@tromey.com> References: <20180720042747.18473-1-tom@tromey.com> The DWARF reader was setting the list_in_scope member when reading partial symbols. however, this member is only useful when reading full symbols. Future patches will make this assert, so remove these unneeded initializations. gdb/ChangeLog 2018-07-19 Tom Tromey * dwarf2read.c (process_psymtab_comp_unit_reader) (build_type_psymtabs_reader): Do not set list_in_scope. --- gdb/ChangeLog | 5 +++++ gdb/dwarf2read.c | 3 --- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index e6a8a188b19..bdd1c9a3b44 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -7908,8 +7908,6 @@ process_psymtab_comp_unit_reader (const struct die_reader_specs *reader, prepare_one_comp_unit (cu, comp_unit_die, info->pretend_language); - cu->list_in_scope = &file_symbols; - /* Allocate a new partial symbol table structure. */ filename = dwarf2_string_attr (comp_unit_die, DW_AT_name, cu); if (filename == NULL) @@ -8077,7 +8075,6 @@ build_type_psymtabs_reader (const struct die_reader_specs *reader, VEC_safe_push (sig_type_ptr, tu_group->tus, sig_type); prepare_one_comp_unit (cu, type_unit_die, language_minimal); - cu->list_in_scope = &file_symbols; pst = create_partial_symtab (per_cu, ""); pst->anonymous = 1;