From patchwork Wed May 23 04:58:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 27423 Received: (qmail 113998 invoked by alias); 23 May 2018 04:59:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 113405 invoked by uid 89); 23 May 2018 04:59:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.119) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 May 2018 04:59:04 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway32.websitewelcome.com (Postfix) with ESMTP id ABA7FC4BDB for ; Tue, 22 May 2018 23:59:03 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id LLrbflVDrlAdrLLrbfGSw3; Tue, 22 May 2018 23:59:03 -0500 X-Authority-Reason: nr=8 Received: from 174-29-44-154.hlrn.qwest.net ([174.29.44.154]:56108 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fLLrb-003S5D-Ek; Tue, 22 May 2018 23:59:03 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 16/42] Use gdb_assert in two places in buildsym.c Date: Tue, 22 May 2018 22:58:25 -0600 Message-Id: <20180523045851.11660-17-tom@tromey.com> In-Reply-To: <20180523045851.11660-1-tom@tromey.com> References: <20180523045851.11660-1-tom@tromey.com> X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fLLrb-003S5D-Ek X-Source-Sender: 174-29-44-154.hlrn.qwest.net (bapiya.Home) [174.29.44.154]:56108 X-Source-Auth: tom+tromey.com X-Email-Count: 17 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes This changes buildsym.c to use gdb_assert rather than internal_error in a couple of spots. gdb/ChangeLog 2018-05-22 Tom Tromey * buildsym.c (push_subfile): Use gdb_assert. (pop_subfile): Use gdb_assert. --- gdb/ChangeLog | 5 +++++ gdb/buildsym.c | 12 ++---------- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/gdb/buildsym.c b/gdb/buildsym.c index 4744d510c3..4823fb383d 100644 --- a/gdb/buildsym.c +++ b/gdb/buildsym.c @@ -896,11 +896,7 @@ push_subfile (void) tem->next = subfile_stack; subfile_stack = tem; - if (current_subfile == NULL || current_subfile->name == NULL) - { - internal_error (__FILE__, __LINE__, - _("failed internal consistency check")); - } + gdb_assert (! (current_subfile == NULL || current_subfile->name == NULL)); tem->name = current_subfile->name; } @@ -910,11 +906,7 @@ pop_subfile (void) char *name; struct subfile_stack *link = subfile_stack; - if (link == NULL) - { - internal_error (__FILE__, __LINE__, - _("failed internal consistency check")); - } + gdb_assert (link != NULL); name = link->name; subfile_stack = link->next; xfree ((void *) link);