[RFA,1/6] Remove dead code in end_psymtab
Commit Message
I noticed that there is a bit of dead code in end_psymtab.
This deletes it.
Normally I would investigate a fix for the code. However, considering
that the code has been this way a long time (since the first import to
sourceware) and considering that dbxread.c is not as important any
more, I think it's safe to just consider that there's no bug.
ChangeLog
2018-05-03 Tom Tromey <tromey@redhat.com>
* dbxread.c (end_psymtab): Remove dead code.
---
gdb/ChangeLog | 4 ++++
gdb/dbxread.c | 8 +-------
2 files changed, 5 insertions(+), 7 deletions(-)
Comments
On 05/03/2018 03:36 PM, Tom Tromey wrote:
> Normally I would investigate a fix for the code. However, considering
> that the code has been this way a long time (since the first import to
> sourceware) and considering that dbxread.c is not as important any
> more, I think it's safe to just consider that there's no bug.
I agree. If it's not tested and the comments aren't clear about what problem it is trying to solve, wait for a new bug report. :-)
IANAMBLGTM*
Keith
* "I am not a maintainer, but looks good to me."
On 2018-06-01 14:55, Keith Seitz wrote:
> On 05/03/2018 03:36 PM, Tom Tromey wrote:
>> Normally I would investigate a fix for the code. However, considering
>> that the code has been this way a long time (since the first import to
>> sourceware) and considering that dbxread.c is not as important any
>> more, I think it's safe to just consider that there's no bug.
>
> I agree. If it's not tested and the comments aren't clear about what
> problem it is trying to solve, wait for a new bug report. :-)
>
> IANAMBLGTM*
>
> Keith
>
> * "I am not a maintainer, but looks good to me."
Thanks Keith for taking a look. LGTM too.
Simon
@@ -2105,13 +2105,7 @@ dbx_end_psymtab (struct objfile *objfile, struct partial_symtab *pst,
ALL_OBJFILE_PSYMTABS (objfile, p1)
{
if (p1->texthigh == 0 && p1->textlow != 0 && p1 != pst)
- {
- p1->texthigh = pst->textlow;
- /* If this file has only data, then make textlow match
- texthigh. */
- if (p1->textlow == 0)
- p1->textlow = p1->texthigh;
- }
+ p1->texthigh = pst->textlow;
}
}