From patchwork Mon Apr 30 05:12:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 27027 Received: (qmail 113526 invoked by alias); 30 Apr 2018 05:12:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 113503 invoked by uid 89); 30 Apr 2018 05:12:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.95) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Apr 2018 05:12:11 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 6EBA7400D15EE for ; Mon, 30 Apr 2018 00:12:10 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id D16gfIoMQA3CSD16gfNjbM; Mon, 30 Apr 2018 00:12:10 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:35688 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fD16g-0025zZ-6k; Mon, 30 Apr 2018 00:12:10 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 2/4] Change the as_*_interp functions to use dynamic_cast Date: Sun, 29 Apr 2018 23:12:05 -0600 Message-Id: <20180430051207.19979-3-tom@tromey.com> In-Reply-To: <20180430051207.19979-1-tom@tromey.com> References: <20180430051207.19979-1-tom@tromey.com> X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fD16g-0025zZ-6k X-Source-Sender: 97-122-176-117.hlrn.qwest.net (bapiya.Home) [97.122.176.117]:35688 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes This changes the various as_*_interp functions to be implemented using dynamic_cast. I believe this is a small improvement, because it is more typesafe -- the C++ runtime does the type-checking for us. ChangeLog 2018-04-29 Tom Tromey * tui/tui-interp.c (as_tui_interp): Use dynamic_cast. * mi/mi-interp.c (as_mi_interp): Use dynamic_cast. * cli/cli-interp.c (as_cli_interp): Use dynamic_cast. --- gdb/ChangeLog | 6 ++++++ gdb/cli/cli-interp.c | 4 +--- gdb/mi/mi-interp.c | 4 +--- gdb/tui/tui-interp.c | 4 +--- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/gdb/cli/cli-interp.c b/gdb/cli/cli-interp.c index 0663301c19..e12d45b4b7 100644 --- a/gdb/cli/cli-interp.c +++ b/gdb/cli/cli-interp.c @@ -73,9 +73,7 @@ struct cli_suppress_notification cli_suppress_notification = static struct cli_interp * as_cli_interp (struct interp *interp) { - if (strcmp (interp_name (interp), INTERP_CONSOLE) == 0) - return (struct cli_interp *) interp; - return NULL; + return dynamic_cast (interp); } /* Longjmp-safe wrapper for "execute_command". */ diff --git a/gdb/mi/mi-interp.c b/gdb/mi/mi-interp.c index 8bfb1298a5..7536817f43 100644 --- a/gdb/mi/mi-interp.c +++ b/gdb/mi/mi-interp.c @@ -106,9 +106,7 @@ display_mi_prompt (struct mi_interp *mi) static struct mi_interp * as_mi_interp (struct interp *interp) { - if (interp_ui_out (interp)->is_mi_like_p ()) - return (struct mi_interp *) interp; - return NULL; + return dynamic_cast (interp); } void diff --git a/gdb/tui/tui-interp.c b/gdb/tui/tui-interp.c index cf32c905c5..aa5e328ded 100644 --- a/gdb/tui/tui-interp.c +++ b/gdb/tui/tui-interp.c @@ -58,9 +58,7 @@ public: static tui_interp * as_tui_interp (struct interp *interp) { - if (strcmp (interp_name (interp), INTERP_TUI) == 0) - return (tui_interp *) interp; - return NULL; + return dynamic_cast (interp); } /* Cleanup the tui before exiting. */