From patchwork Sat Apr 21 18:30:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 26888 Received: (qmail 83709 invoked by alias); 21 Apr 2018 18:31:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 83683 invoked by uid 89); 21 Apr 2018 18:31:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=throws X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 21 Apr 2018 18:31:01 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 4CAED8B118 for ; Sat, 21 Apr 2018 13:31:00 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9xHofycQB5CKD9xHofXCuB; Sat, 21 Apr 2018 13:31:00 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:50954 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1f9xHo-002rFx-2o; Sat, 21 Apr 2018 13:31:00 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 2/9] Add missing ATTRIBUTE_NORETURNs Date: Sat, 21 Apr 2018 12:30:49 -0600 Message-Id: <20180421183056.29292-3-tom@tromey.com> In-Reply-To: <20180421183056.29292-1-tom@tromey.com> References: <20180421183056.29292-1-tom@tromey.com> X-BWhitelist: no X-Source-L: No X-Exim-ID: 1f9xHo-002rFx-2o X-Source-Sender: 97-122-176-117.hlrn.qwest.net (bapiya.Home) [97.122.176.117]:50954 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes This patch adds a missing ATTRIBUTE_NORETURN. This lets -Wimplicit-fallthrough recognize that a given case does not fall through. ChangeLog 2018-04-21 Tom Tromey * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN. --- gdb/ChangeLog | 4 ++++ gdb/dwarf2loc.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c index 6c84e4ad7e..f7eff7d6a5 100644 --- a/gdb/dwarf2loc.c +++ b/gdb/dwarf2loc.c @@ -2865,7 +2865,7 @@ dwarf2_loc_desc_get_symbol_read_needs (const gdb_byte *data, size_t size, /* A helper function that throws an unimplemented error mentioning a given DWARF operator. */ -static void +static void ATTRIBUTE_NORETURN unimplemented (unsigned int op) { const char *name = get_DW_OP_name (op);