From patchwork Thu Apr 19 21:24:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philippe Waroquiers X-Patchwork-Id: 26869 Received: (qmail 40467 invoked by alias); 19 Apr 2018 21:24:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 40216 invoked by uid 89); 19 Apr 2018 21:24:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-27.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=H*F:D*be, UD:be, H*Ad:D*be X-HELO: mailsec110.isp.belgacom.be Received: from mailsec110.isp.belgacom.be (HELO mailsec110.isp.belgacom.be) (195.238.20.106) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Apr 2018 21:24:46 +0000 IronPort-PHdr: =?us-ascii?q?9a23=3AXOIkvhBLl2nz1eM4VT4QUyQJP3N1i/DPJgcQr6Af?= =?us-ascii?q?oPdwSPT4pcbcNUDSrc9gkEXOFd2Cra4c0KyO6+jJYi8p2d65qncMcZhBBVcuqP?= =?us-ascii?q?49uEgeOvODElDxN/XwbiY3T4xoXV5h+GynYwAOQJ6tL1LdrWev4jEMBx7xKRR6?= =?us-ascii?q?JvjvGo7Vks+7y/2+94fcbglUijexe69+IAmrpgjNq8cahpdvJLwswRXTuHtIfO?= =?us-ascii?q?pWxWJsJV2Nmhv3+9m98p1+/SlOovwt78FPX7n0cKQ+VrxYES8pM3sp683xtBnM?= =?us-ascii?q?VhWA630BWWgLiBVIAgzF7BbnXpfttybxq+Rw1DWGMcDwULs5Xymp4aV2Rx/ykC?= =?us-ascii?q?oJNyA3/nzZhMJzi6xWuw6tqwBlzoLIeoyZKOZyc6XAdt0aX2pBWcNRWjRbDIO8?= =?us-ascii?q?bosPC+sBPf5Ar4bjulABrQGxBROrBOP21z9Ih2H53bch0+88FgzGxAwgH9MKsH?= =?us-ascii?q?TVtNX1LLkdXfq7zabS1zXDaOpW2Sr86IfWaBAhuuqBXalzccvRz0kgCR/Fgk+L?= =?us-ascii?q?poP7Jj6Y0PkGvWuD7+d4Vu+jlnQrpx9+rzSx3MshhYvEipgbx1za8yhy3Zw7Ks?= =?us-ascii?q?eiSEFhZN6pCJ5QtyaHOIRoWs4iWGRouDoiyr0BpJ67YDAGyJQ5yB7bbPyKa42I?= =?us-ascii?q?7Q/5WOaRJjd4gWxqdKq+hxa070eg1vXxW8qp3FpQsCZIncfAumoC2hHR8MSKRO?= =?us-ascii?q?Vx8l+k2TmV1gDT7u9EIVozlareM5Mh2r4wlpsXsUTCBi/2gFv5gLWYd0o+4Oio?= =?us-ascii?q?7P3nYqjnppCCLY90kRrzMr8tms2/B+Q3LBQOU3KA9uuizLHj51H2QK1Wjv0qla?= =?us-ascii?q?nUqJ/aKtkAqaKgGw9ayJoj5Aq/Dzi4y9QVhmIHLFVYeBKdk4fmJV/PL+riDfih?= =?us-ascii?q?mVisly1rx//eNL37HprNNmTDkKvmfbtl805cyAszzdRe55JMErEOPuj/W0Hru9?= =?us-ascii?q?zCCR85KhG0w+f5B9VnzYMTQnmPAqyZMaPUr1CI+vgjLPKSa9xdhDGoJPQvoubn?= =?us-ascii?q?kXQ5lEQ1Zq60x5Aad3miE7JhOUrKT2Drh4I5EWYOvxImQaTVgUeFSCNSamypF/?= =?us-ascii?q?Yk5jA/CZq+AMHcT5qqmaGA0T2gNoZVd2ZLFhaGHCG7JM2/R/4QZXfKcYdamTse?= =?us-ascii?q?WO35Rg=3D=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2AkBgD0B9la/yAv8lFbg3N4YyiMSIwYA?= =?us-ascii?q?YIkAV2Sc4F4C4RpgkIiNBgBAgEBAQEBAQIBayiCNSKCeS8jT0s3hRGpCTOEWIN?= =?us-ascii?q?qghuJWj+JWYUIApdtCIFhjFELjEwBkCeBJRw4gVJtU4JDgiAXjhk9MJBBAQE?= X-IPAS-Result: =?us-ascii?q?A2AkBgD0B9la/yAv8lFbg3N4YyiMSIwYAYIkAV2Sc4F4C4R?= =?us-ascii?q?pgkIiNBgBAgEBAQEBAQIBayiCNSKCeS8jT0s3hRGpCTOEWINqghuJWj+JWYUIA?= =?us-ascii?q?pdtCIFhjFELjEwBkCeBJRw4gVJtU4JDgiAXjhk9MJBBAQE?= Received: from 32.47-242-81.adsl-dyn.isp.belgacom.be (HELO md.home) ([81.242.47.32]) by relay.skynet.be with ESMTP/TLS/DHE-RSA-AES128-GCM-SHA256; 19 Apr 2018 23:24:44 +0200 From: Philippe Waroquiers To: gdb-patches@sourceware.org Cc: Philippe Waroquiers Subject: [PATCH] [OB PATCH] Fix some comments in thread.c Date: Thu, 19 Apr 2018 23:24:32 +0200 Message-Id: <20180419212432.4023-1-philippe.waroquiers@skynet.be> X-IsSubscribed: yes Fix some typos. Remove obsolete comment about dispatch to thread_apply_command, rather tell that thread_command either switches to a thread, or prints the current thread. 2018-04-19 Philippe Waroquiers * thread.c (thread_apply_all_command): Fix comment. (thread_command): Fix comment. --- gdb/ChangeLog | 5 +++++ gdb/thread.c | 9 ++++----- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 5c8742450e..0db5c46f6c 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-04-19 Philippe Waroquiers + + * thread.c (thread_apply_all_command): Fix comment. + (thread_command): Fix comment. + 2018-04-10 Alan Hayward * common/tdesc.h (tdesc_create_feature): Remove xml filename diff --git a/gdb/thread.c b/gdb/thread.c index c1a8174e96..23aa5ba117 100644 --- a/gdb/thread.c +++ b/gdb/thread.c @@ -1582,12 +1582,12 @@ tp_array_compar (const thread_info *a, const thread_info *b) } /* Apply a GDB command to a list of threads. List syntax is a whitespace - seperated list of numbers, or ranges, or the keyword `all'. Ranges consist - of two numbers seperated by a hyphen. Examples: + separated list of numbers, or ranges, or the keyword `all'. Ranges consist + of two numbers separated by a hyphen. Examples: thread apply 1 2 7 4 backtrace Apply backtrace cmd to threads 1,2,7,4 thread apply 2-7 9 p foo(1) Apply p foo(1) cmd to threads 2->7 & 9 - thread apply all p x/i $pc Apply x/i $pc cmd to all threads. */ + thread apply all x/i $pc Apply x/i $pc cmd to all threads. */ static void thread_apply_all_command (const char *cmd, int from_tty) @@ -1733,8 +1733,7 @@ thread_apply_command (const char *tidlist, int from_tty) } } -/* Switch to the specified thread. Will dispatch off to thread_apply_command - if prefix of arg is `apply'. */ +/* Switch to the specified thread, or print the current thread. */ void thread_command (const char *tidstr, int from_tty)