From patchwork Fri Mar 23 20:36:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Keith Seitz X-Patchwork-Id: 26442 Received: (qmail 57274 invoked by alias); 23 Mar 2018 20:36:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 56711 invoked by uid 89); 23 Mar 2018 20:36:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=reveals, addrs X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Mar 2018 20:36:10 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0AE0B7FEAC for ; Fri, 23 Mar 2018 20:36:09 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id CABD55D9D6 for ; Fri, 23 Mar 2018 20:36:08 +0000 (UTC) From: Keith Seitz To: gdb-patches@sourceware.org Subject: [PATCH] Remove struct keyword from section_addr_info Date: Fri, 23 Mar 2018 13:36:08 -0700 Message-Id: <20180323203608.8939-1-keiths@redhat.com> X-IsSubscribed: yes Buildbot pointed out a failiure in windows-nat.c: ../../binutils-gdb/gdb/windows-nat.c:582:10: error: using typedef-name 'section_addr_info' after 'struct' struct section_addr_info *addrs; ^~~~~~~~~~~~~~~~~ In file included from ../../binutils-gdb/gdb/windows-nat.c:49:0: ../../binutils-gdb/gdb/symfile.h:75:37: note: 'section_addr_info' has a previous declaration here typedef std::vector section_addr_info; ^~~~~~~~~~~~~~~~~ A recursive grep of the sources for "struct section_addr_info" reveals one additional reference in a comment. In both cases, this patch simply removes the struct keyword. gdb/ChangeLog: * symfile.c (place_section): Remove "struct" from section_addr_info in comment. * windows-nat.c (struct safe_symbol_file_add_args) : Likewise. --- gdb/ChangeLog | 6 ++++++ gdb/symfile.c | 2 +- gdb/windows-nat.c | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b543904db2..70d182d624 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2018-MM-DD Keith Seitz + + * symfile.c (place_section): Remove "struct" from section_addr_info + in comment. + * windows-nat.c (struct safe_symbol_file_add_args) : Likewise. + 2018-03-23 Keith Seitz PR c++/22968 diff --git a/gdb/symfile.c b/gdb/symfile.c index 9571664776..1e5297ee29 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -412,7 +412,7 @@ place_section (bfd *abfd, asection *sect, void *obj) arg->lowest = start_addr + bfd_get_section_size (sect); } -/* Store struct section_addr_info as prepared (made relative and with SECTINDEX +/* Store section_addr_info as prepared (made relative and with SECTINDEX filled-in) by addr_info_make_relative into SECTION_OFFSETS of NUM_SECTIONS entries. */ diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index f849f1f322..430cc60993 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -579,7 +579,7 @@ struct safe_symbol_file_add_args { char *name; int from_tty; - struct section_addr_info *addrs; + section_addr_info *addrs; int mainline; int flags; struct ui_file *err, *out;