From patchwork Sun Feb 25 16:32:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 26046 Received: (qmail 41618 invoked by alias); 25 Feb 2018 16:33:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 41489 invoked by uid 89); 25 Feb 2018 16:32:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_SOFTFAIL autolearn=ham version=3.3.2 spammy= X-HELO: barracuda.ebox.ca Received: from barracuda.ebox.ca (HELO barracuda.ebox.ca) (96.127.255.19) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 25 Feb 2018 16:32:54 +0000 X-ASG-Debug-ID: 1519576371-0c856e6189e3b10001-fS2M51 Received: from smtp.ebox.ca (smtp.electronicbox.net [96.127.255.82]) by barracuda.ebox.ca with ESMTP id 1jExS13KliH6Z1kh (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 25 Feb 2018 11:32:51 -0500 (EST) X-Barracuda-Envelope-From: simon.marchi@polymtl.ca X-Barracuda-RBL-Trusted-Forwarder: 96.127.255.82 Received: from simark.lan (192-222-251-162.qc.cable.ebox.net [192.222.251.162]) by smtp.ebox.ca (Postfix) with ESMTP id 893A9441D70; Sun, 25 Feb 2018 11:32:51 -0500 (EST) From: Simon Marchi X-Barracuda-Effective-Source-IP: 192-222-251-162.qc.cable.ebox.net[192.222.251.162] X-Barracuda-Apparent-Source-IP: 192.222.251.162 X-Barracuda-RBL-IP: 192.222.251.162 To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 5/5] Remove free_char_ptr_vec Date: Sun, 25 Feb 2018 11:32:47 -0500 X-ASG-Orig-Subj: [PATCH 5/5] Remove free_char_ptr_vec Message-Id: <20180225163247.20157-5-simon.marchi@polymtl.ca> In-Reply-To: <20180225163247.20157-1-simon.marchi@polymtl.ca> References: <20180225163247.20157-1-simon.marchi@polymtl.ca> X-Barracuda-Connect: smtp.electronicbox.net[96.127.255.82] X-Barracuda-Start-Time: 1519576371 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://96.127.255.19:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 1644 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=8.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.48309 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-IsSubscribed: yes Nothing is using it anymore. gdb/ChangeLog: * common/gdb_vecs.c (free_char_ptr_vec): Remove. * common/gdb_vecs.h (free_char_ptr_vec): Remove. --- gdb/common/gdb_vecs.c | 18 ------------------ gdb/common/gdb_vecs.h | 2 -- 2 files changed, 20 deletions(-) diff --git a/gdb/common/gdb_vecs.c b/gdb/common/gdb_vecs.c index a19d238b3e..445793e420 100644 --- a/gdb/common/gdb_vecs.c +++ b/gdb/common/gdb_vecs.c @@ -21,24 +21,6 @@ #include "gdb_vecs.h" #include "host-defs.h" -/* Call xfree for each element of CHAR_PTR_VEC and final VEC_free for - CHAR_PTR_VEC itself. - - You must not modify CHAR_PTR_VEC after it got registered with this function - by make_cleanup as the CHAR_PTR_VEC base address may change on its updates. - Contrary to VEC_free this function does not (cannot) clear the pointer. */ - -void -free_char_ptr_vec (VEC (char_ptr) *char_ptr_vec) -{ - int ix; - char *name; - - for (ix = 0; VEC_iterate (char_ptr, char_ptr_vec, ix, name); ++ix) - xfree (name); - VEC_free (char_ptr, char_ptr_vec); -} - /* Worker function to split character delimiter separated string of fields STR into a char pointer vector. */ diff --git a/gdb/common/gdb_vecs.h b/gdb/common/gdb_vecs.h index 17ed06c253..29db27a892 100644 --- a/gdb/common/gdb_vecs.h +++ b/gdb/common/gdb_vecs.h @@ -29,8 +29,6 @@ DEF_VEC_P (char_ptr); DEF_VEC_P (const_char_ptr); -extern void free_char_ptr_vec (VEC (char_ptr) *char_ptr_vec); - /* Split STR, a list of DELIMITER-separated fields, into a char pointer vector. You may modify the returned strings. */