From patchwork Wed Jan 17 10:56:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 25425 Received: (qmail 36656 invoked by alias); 17 Jan 2018 10:56:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 36626 invoked by uid 89); 17 Jan 2018 10:56:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=dear, Hx-spam-relays-external:209.85.192.194, H*RU:209.85.192.194 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-pf0-f194.google.com Received: from mail-pf0-f194.google.com (HELO mail-pf0-f194.google.com) (209.85.192.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Jan 2018 10:56:34 +0000 Received: by mail-pf0-f194.google.com with SMTP id t5so5207251pfi.0; Wed, 17 Jan 2018 02:56:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6X21ybhryjB04OaFOptjBNcXQKNpbTdaANtFPiMo3ig=; b=I5kQ5TH+VOe4J5OAUgA7yPovKLSCsz6wWXRucIeKTqNQ5YTuDeghIqHS94cnY36VhE yC7MkMxCqIKYKOrjGtQA82/gCa4O0FhSVVh2k4fZFD/MqvM3JZGElJtRcncriheBOnr9 fu3qB1RpzKnm9iD7MUHMbzzOsbTMCVuwCdbOkfCN+iyFlnH8/Yj2v/ZI/xsh7c6afEqV WDt7i1L9u8eSZYVwSw+ys+5M4gZq3fIURO2+mYgd9ai/M3N8C+amjx80rDUIVQjiEt4t JURXV1vx3agtSgCXvbPAqfZN5suzpWP+nAgK3q9biomhSJo2StRmqXFaIZ4AfjmoBgPl T8HQ== X-Gm-Message-State: AKGB3mLsJCoMoY80NHbk8rloeyQa8zzoATb9srGRnGJ0k+qxZk9B36lU /hhRrTz0spgPbY33DmvD+rzqDg== X-Google-Smtp-Source: ACJfBosARHEpYa/evyXrDbjWtJMNEWJW4nj4GH2hi4stiWlXNp6G+teVL+VH7EfYjUV4Uo+nLBninQ== X-Received: by 10.99.159.9 with SMTP id g9mr32080386pge.174.1516186592274; Wed, 17 Jan 2018 02:56:32 -0800 (PST) Received: from bubble.grove.modra.org (CPE-58-175-244-173.hdcz1.win.bigpond.net.au. [58.175.244.173]) by smtp.gmail.com with ESMTPSA id c83sm8568129pfk.8.2018.01.17.02.56.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Jan 2018 02:56:31 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id EA3CAC1726; Wed, 17 Jan 2018 21:26:26 +1030 (ACDT) Date: Wed, 17 Jan 2018 21:26:26 +1030 From: Alan Modra To: binutils@sourceware.org Cc: gdb-patches@sourceware.org Subject: Re: Oh dear. I regret to inform you that commit 9e390558cef76767a98123994c422d0642d86cf8 might be unfortunate Message-ID: <20180117105626.GY20622@bubble.grove.modra.org> References: <9e390558cef76767a98123994c422d0642d86cf8-master-breakage@gdb-build> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9e390558cef76767a98123994c422d0642d86cf8-master-breakage@gdb-build> User-Agent: Mutt/1.5.24 (2015-08-30) On Wed, Jan 17, 2018 at 03:29:33AM -0500, gdb-buildbot@sergiodj.net wrote: > My lords, ladies, gentlemen, members of the public. > > It is a matter of great regret and sadness to inform you that commit: > > PowerPC PLT stub tidy > 9e390558cef76767a98123994c422d0642d86cf8 > > might have made GDB unwell. Hmm, not seen with my gcc-7 but this ought to cure the warning. * elf64-ppc.c (ppc64_elf_build_stubs): Silence gcc warning. diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c index 1b4404c..65cf7fe 100644 --- a/bfd/elf64-ppc.c +++ b/bfd/elf64-ppc.c @@ -13211,7 +13211,7 @@ ppc64_elf_build_stubs (struct bfd_link_info *info, p += 4; } p = output_bctr (htab, htab->glink->owner, p); - BFD_ASSERT (p - htab->glink->contents == GLINK_PLTRESOLVE_SIZE (htab)); + BFD_ASSERT (p == htab->glink->contents + GLINK_PLTRESOLVE_SIZE (htab)); /* Build the .glink lazy link call stubs. */ indx = 0;