From patchwork Tue Jan 16 20:32:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergio Durigan Junior X-Patchwork-Id: 25422 Received: (qmail 11637 invoked by alias); 16 Jan 2018 20:32:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 11498 invoked by uid 89); 16 Jan 2018 20:32:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=technically X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Jan 2018 20:32:46 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1C31DC057FA6; Tue, 16 Jan 2018 20:32:45 +0000 (UTC) Received: from psique.yyz.redhat.com (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTP id 955DC60C18; Tue, 16 Jan 2018 20:32:41 +0000 (UTC) From: Sergio Durigan Junior To: GDB Patches Cc: Eli Zaretskii , Sergio Durigan Junior Subject: [PATCH] Fix unitialized warning on gdb/typeprint.c:whatis_exp Date: Tue, 16 Jan 2018 15:32:39 -0500 Message-Id: <20180116203239.27787-1-sergiodj@redhat.com> In-Reply-To: <87po69zkxe.fsf@redhat.com> References: <87po69zkxe.fsf@redhat.com> X-IsSubscribed: yes This simple patch initializes "struct value *val" to NULL, which silences a when compiling GDB with certain GCC versions. This warning is technically incorrect, because there is now way that "val" will be used unitialized if you look at the code flow, but it's a simple "fix" and doesn't do any harm. Is it OK to push this to master and 8.1? I believe I will still need to create a bug with the 8.1 milestone set, even for this simple patch. gdb/ChangeLog: 2017-01-16 Sergio Durigan Junior * typeprint.c (whatis_exp): Initialize "val" to NULL. --- gdb/typeprint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/typeprint.c b/gdb/typeprint.c index 9a125076a1..bf9aec5436 100644 --- a/gdb/typeprint.c +++ b/gdb/typeprint.c @@ -405,7 +405,7 @@ error_unknown_type (const char *sym_print_name) static void whatis_exp (const char *exp, int show) { - struct value *val; + struct value *val = NULL; struct cleanup *old_chain; struct type *real_type = NULL; struct type *type;