From patchwork Thu Nov 23 15:37:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Rudo X-Patchwork-Id: 24467 Received: (qmail 30664 invoked by alias); 23 Nov 2017 15:37:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 30529 invoked by uid 89); 23 Nov 2017 15:37:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, KB_WAM_FROM_NAME_SINGLEWORD, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=3186, LONGEST, 8958, 7548 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Nov 2017 15:37:45 +0000 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vANFabgW008317 for ; Thu, 23 Nov 2017 10:37:43 -0500 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ee13gg3ww-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 23 Nov 2017 10:37:43 -0500 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 23 Nov 2017 15:37:41 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 23 Nov 2017 15:37:39 -0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id vANFbdLl42139708; Thu, 23 Nov 2017 15:37:39 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8605AAE045; Thu, 23 Nov 2017 15:30:53 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 52435AE04D; Thu, 23 Nov 2017 15:30:53 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Thu, 23 Nov 2017 15:30:53 +0000 (GMT) From: Philipp Rudo To: gdb-patches@sourceware.org Cc: Andreas Arnez , Ulrich Weigand Subject: [PATCH 4/4] Add comments to uncommented functions in s390-linux-tdep.c Date: Thu, 23 Nov 2017 16:37:33 +0100 In-Reply-To: <20171123153733.31261-1-prudo@linux.vnet.ibm.com> References: <20171123153733.31261-1-prudo@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 17112315-0040-0000-0000-00000411DD98 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17112315-0041-0000-0000-000020B4AF8E Message-Id: <20171123153733.31261-5-prudo@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-11-23_06:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1711230212 X-IsSubscribed: yes Moving common functions from s390-linux-tdep to s390-tdep showed that some of the left functions are lacking a description. Fix that now. gdb/ChangeLog: * s390-linux-tdep.c: Add comments to uncommented functions --- gdb/s390-linux-tdep.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/gdb/s390-linux-tdep.c b/gdb/s390-linux-tdep.c index c27c1f4799..30910a5364 100644 --- a/gdb/s390-linux-tdep.c +++ b/gdb/s390-linux-tdep.c @@ -60,6 +60,8 @@ #define XML_SYSCALL_FILENAME_S390 "syscalls/s390-linux.xml" #define XML_SYSCALL_FILENAME_S390X "syscalls/s390x-linux.xml" +/* Register handling. */ + /* The "guess_tracepoint_registers" gdbarch method. */ static void @@ -271,6 +273,8 @@ s390_iterate_over_regset_sections (struct gdbarch *gdbarch, } } +/* Implement core_read_description gdbarch method. */ + static const struct target_desc * s390_core_read_description (struct gdbarch *gdbarch, struct target_ops *target, bfd *abfd) @@ -318,6 +322,11 @@ s390_core_read_description (struct gdbarch *gdbarch, } } +/* Frame unwinding. */ + +/* Wrapper for trad_frame_get_prev_register to allow for s390 pseudo + register translation. */ + static struct value * s390_trad_frame_prev_register (struct frame_info *this_frame, struct trad_frame_saved_reg saved_regs[], @@ -340,6 +349,9 @@ struct s390_unwind_cache { struct trad_frame_saved_reg *saved_regs; }; +/* Unwind THIS_FRAME and write the information into unwind cache INFO using + prologue analysis. Helper for s390_frame_unwind_cache. */ + static int s390_prologue_frame_unwind_cache (struct frame_info *this_frame, struct s390_unwind_cache *info) @@ -524,6 +536,9 @@ s390_prologue_frame_unwind_cache (struct frame_info *this_frame, return 1; } +/* Unwind THIS_FRAME and write the information into unwind cache INFO using + back chain unwinding. Helper for s390_frame_unwind_cache. */ + static void s390_backchain_frame_unwind_cache (struct frame_info *this_frame, struct s390_unwind_cache *info) @@ -578,6 +593,9 @@ s390_backchain_frame_unwind_cache (struct frame_info *this_frame, info->func = get_frame_pc (this_frame); } +/* Unwind THIS_FRAME and return the corresponding unwind cache for + s390_frame_unwind and s390_frame_base. */ + static struct s390_unwind_cache * s390_frame_unwind_cache (struct frame_info *this_frame, void **this_prologue_cache) @@ -611,6 +629,8 @@ s390_frame_unwind_cache (struct frame_info *this_frame, return info; } +/* Implement this_id frame_unwind method for s390_frame_unwind. */ + static void s390_frame_this_id (struct frame_info *this_frame, void **this_prologue_cache, @@ -629,6 +649,8 @@ s390_frame_this_id (struct frame_info *this_frame, *this_id = frame_id_build (info->frame_base, info->func); } +/* Implement prev_register frame_unwind method for s390_frame_unwind. */ + static struct value * s390_frame_prev_register (struct frame_info *this_frame, void **this_prologue_cache, int regnum) @@ -639,6 +661,8 @@ s390_frame_prev_register (struct frame_info *this_frame, return s390_trad_frame_prev_register (this_frame, info->saved_regs, regnum); } +/* Default S390 frame unwinder. */ + static const struct frame_unwind s390_frame_unwind = { NORMAL_FRAME, default_frame_unwind_stop_reason, @@ -658,6 +682,9 @@ struct s390_stub_unwind_cache struct trad_frame_saved_reg *saved_regs; }; +/* Unwind THIS_FRAME and return the corresponding unwind cache for + s390_stub_frame_unwind. */ + static struct s390_stub_unwind_cache * s390_stub_frame_unwind_cache (struct frame_info *this_frame, void **this_prologue_cache) @@ -684,6 +711,8 @@ s390_stub_frame_unwind_cache (struct frame_info *this_frame, return info; } +/* Implement this_id frame_unwind method for s390_stub_frame_unwind. */ + static void s390_stub_frame_this_id (struct frame_info *this_frame, void **this_prologue_cache, @@ -694,6 +723,8 @@ s390_stub_frame_this_id (struct frame_info *this_frame, *this_id = frame_id_build (info->frame_base, get_frame_pc (this_frame)); } +/* Implement prev_register frame_unwind method for s390_stub_frame_unwind. */ + static struct value * s390_stub_frame_prev_register (struct frame_info *this_frame, void **this_prologue_cache, int regnum) @@ -703,6 +734,8 @@ s390_stub_frame_prev_register (struct frame_info *this_frame, return s390_trad_frame_prev_register (this_frame, info->saved_regs, regnum); } +/* Implement sniffer frame_unwind method for s390_stub_frame_unwind. */ + static int s390_stub_frame_sniffer (const struct frame_unwind *self, struct frame_info *this_frame, @@ -721,6 +754,8 @@ s390_stub_frame_sniffer (const struct frame_unwind *self, return 0; } +/* S390 stub frame unwinder. */ + static const struct frame_unwind s390_stub_frame_unwind = { NORMAL_FRAME, default_frame_unwind_stop_reason, @@ -737,6 +772,9 @@ struct s390_sigtramp_unwind_cache { struct trad_frame_saved_reg *saved_regs; }; +/* Unwind THIS_FRAME and return the corresponding unwind cache for + s390_sigtramp_frame_unwind. */ + static struct s390_sigtramp_unwind_cache * s390_sigtramp_frame_unwind_cache (struct frame_info *this_frame, void **this_prologue_cache) @@ -845,6 +883,8 @@ s390_sigtramp_frame_unwind_cache (struct frame_info *this_frame, return info; } +/* Implement this_id frame_unwind method for s390_sigtramp_frame_unwind. */ + static void s390_sigtramp_frame_this_id (struct frame_info *this_frame, void **this_prologue_cache, @@ -855,6 +895,8 @@ s390_sigtramp_frame_this_id (struct frame_info *this_frame, *this_id = frame_id_build (info->frame_base, get_frame_pc (this_frame)); } +/* Implement prev_register frame_unwind method for sigtramp frames. */ + static struct value * s390_sigtramp_frame_prev_register (struct frame_info *this_frame, void **this_prologue_cache, int regnum) @@ -864,6 +906,8 @@ s390_sigtramp_frame_prev_register (struct frame_info *this_frame, return s390_trad_frame_prev_register (this_frame, info->saved_regs, regnum); } +/* Implement sniffer frame_unwind method for sigtramp frames. */ + static int s390_sigtramp_frame_sniffer (const struct frame_unwind *self, struct frame_info *this_frame, @@ -885,6 +929,8 @@ s390_sigtramp_frame_sniffer (const struct frame_unwind *self, return 1; } +/* S390 sigtramp frame unwinder. */ + static const struct frame_unwind s390_sigtramp_frame_unwind = { SIGTRAMP_FRAME, default_frame_unwind_stop_reason, @@ -992,6 +1038,9 @@ s390_all_but_pc_registers_record (struct regcache *regcache) return 0; } +/* Canonicalize system call SYSCALL belonging to ABI. Helper for + s390_linux_syscall_record. */ + static enum gdb_syscall s390_canonicalize_syscall (int syscall, enum s390_abi_kind abi) { @@ -1160,6 +1209,9 @@ s390_canonicalize_syscall (int syscall, enum s390_abi_kind abi) } } +/* Record a system call. Returns 0 on success, -1 otherwise. + Helper function for s390_process_record. */ + static int s390_linux_syscall_record (struct regcache *regcache, LONGEST syscall_native) { @@ -1208,6 +1260,8 @@ s390_linux_syscall_record (struct regcache *regcache, LONGEST syscall_native) return 0; } +/* Implement process_record_signal gdbarch method. */ + static int s390_linux_record_signal (struct gdbarch *gdbarch, struct regcache *regcache, enum gdb_signal signal) @@ -1411,6 +1465,8 @@ s390_record_vr (struct gdbarch *gdbarch, struct regcache *regcache, int i) return 0; } +/* Implement process_record gdbarch method. */ + static int s390_process_record (struct gdbarch *gdbarch, struct regcache *regcache, CORE_ADDR addr)