From patchwork Thu Sep 21 05:10:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 23016 Received: (qmail 49464 invoked by alias); 21 Sep 2017 05:39:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 49392 invoked by uid 89); 21 Sep 2017 05:39:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=Junk X-HELO: gproxy8-pub.mail.unifiedlayer.com Received: from gproxy8-pub.mail.unifiedlayer.com (HELO gproxy8-pub.mail.unifiedlayer.com) (67.222.33.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Sep 2017 05:39:37 +0000 Received: from cmgw2 (unknown [10.0.90.83]) by gproxy8.mail.unifiedlayer.com (Postfix) with ESMTP id 91C451AB15C for ; Wed, 20 Sep 2017 23:39:36 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id C5fZ1w01d2f2jeq015fcEB; Wed, 20 Sep 2017 23:39:36 -0600 X-Authority-Analysis: v=2.2 cv=dZfw5Tfe c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=2JCJgTwv5E4A:10 a=zstS-IiYAAAA:8 a=p9EWkgf-usl1U0jGp6cA:9 a=Pbfxji8IAPap8m90:21 a=Upo6GxdmObsvmz3s:21 a=4G6NA9xxw8l3yy4pmD5M:22 Received: from 75-166-76-94.hlrn.qwest.net ([75.166.76.94]:36574 helo=bapiya.Home) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dutkz-00118R-9A; Wed, 20 Sep 2017 23:10:37 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 49/67] Constify some commands in btrace.c Date: Wed, 20 Sep 2017 23:10:05 -0600 Message-Id: <20170921051023.19023-50-tom@tromey.com> In-Reply-To: <20170921051023.19023-1-tom@tromey.com> References: <20170921051023.19023-1-tom@tromey.com> X-BWhitelist: no X-Exim-ID: 1dutkz-00118R-9A X-Source-Sender: 75-166-76-94.hlrn.qwest.net (bapiya.Home) [75.166.76.94]:36574 X-Source-Auth: tom+tromey.com X-Email-Count: 32 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes ChangeLog 2017-09-20 Tom Tromey * btrace.c (get_uint, get_context_size, no_chunk) (maint_btrace_packet_history_cmd) (maint_btrace_clear_packet_history_cmd, maint_btrace_clear_cmd) (maint_info_btrace_cmd): Constify. --- gdb/ChangeLog | 7 +++++++ gdb/btrace.c | 24 ++++++++++++++---------- 2 files changed, 21 insertions(+), 10 deletions(-) diff --git a/gdb/btrace.c b/gdb/btrace.c index 8527c6f..b42e68e 100644 --- a/gdb/btrace.c +++ b/gdb/btrace.c @@ -3180,9 +3180,10 @@ btrace_maint_print_packets (struct btrace_thread_info *btinfo, /* Read a number from an argument string. */ static unsigned int -get_uint (char **arg) +get_uint (const char **arg) { - char *begin, *end, *pos; + const char *begin, *pos; + char *end; unsigned long number; begin = *arg; @@ -3203,9 +3204,9 @@ get_uint (char **arg) /* Read a context size from an argument string. */ static int -get_context_size (char **arg) +get_context_size (const char **arg) { - char *pos; + const char *pos; int number; pos = skip_spaces (*arg); @@ -3213,13 +3214,16 @@ get_context_size (char **arg) if (!isdigit (*pos)) error (_("Expected positive number, got: %s."), pos); - return strtol (pos, arg, 10); + char *end; + long result = strtol (pos, &end, 10); + *arg = end; + return result; } /* Complain about junk at the end of an argument string. */ static void -no_chunk (char *arg) +no_chunk (const char *arg) { if (*arg != 0) error (_("Junk after argument: %s."), arg); @@ -3228,7 +3232,7 @@ no_chunk (char *arg) /* The "maintenance btrace packet-history" command. */ static void -maint_btrace_packet_history_cmd (char *arg, int from_tty) +maint_btrace_packet_history_cmd (const char *arg, int from_tty) { struct btrace_thread_info *btinfo; struct thread_info *tp; @@ -3333,7 +3337,7 @@ maint_btrace_packet_history_cmd (char *arg, int from_tty) /* The "maintenance btrace clear-packet-history" command. */ static void -maint_btrace_clear_packet_history_cmd (char *args, int from_tty) +maint_btrace_clear_packet_history_cmd (const char *args, int from_tty) { struct btrace_thread_info *btinfo; struct thread_info *tp; @@ -3355,7 +3359,7 @@ maint_btrace_clear_packet_history_cmd (char *args, int from_tty) /* The "maintenance btrace clear" command. */ static void -maint_btrace_clear_cmd (char *args, int from_tty) +maint_btrace_clear_cmd (const char *args, int from_tty) { struct btrace_thread_info *btinfo; struct thread_info *tp; @@ -3418,7 +3422,7 @@ maint_btrace_pt_show_cmd (char *args, int from_tty) /* The "maintenance info btrace" command. */ static void -maint_info_btrace_cmd (char *args, int from_tty) +maint_info_btrace_cmd (const char *args, int from_tty) { struct btrace_thread_info *btinfo; struct thread_info *tp;