From patchwork Thu Sep 21 05:09:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 23048 Received: (qmail 73500 invoked by alias); 21 Sep 2017 05:42:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 73236 invoked by uid 89); 21 Sep 2017 05:42:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=AFTER, 4510 X-HELO: gproxy5-pub.mail.unifiedlayer.com Received: from gproxy5-pub.mail.unifiedlayer.com (HELO gproxy5-pub.mail.unifiedlayer.com) (67.222.38.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Sep 2017 05:42:07 +0000 Received: from CMOut01 (unknown [10.0.90.82]) by gproxy5.mail.unifiedlayer.com (Postfix) with ESMTP id 797111406F6 for ; Wed, 20 Sep 2017 23:41:03 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id C5h01w00H2f2jeq015h3DY; Wed, 20 Sep 2017 23:41:03 -0600 X-Authority-Analysis: v=2.2 cv=K4VSJ2eI c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=2JCJgTwv5E4A:10 a=zstS-IiYAAAA:8 a=wSWBPpzAiYvh_wXMoxAA:9 a=4G6NA9xxw8l3yy4pmD5M:22 Received: from 75-166-76-94.hlrn.qwest.net ([75.166.76.94]:36574 helo=bapiya.Home) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dutkx-00118R-OB; Wed, 20 Sep 2017 23:10:35 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 42/67] Constify some commands in exec.c, plus symbol_file_command Date: Wed, 20 Sep 2017 23:09:58 -0600 Message-Id: <20170921051023.19023-43-tom@tromey.com> In-Reply-To: <20170921051023.19023-1-tom@tromey.com> References: <20170921051023.19023-1-tom@tromey.com> X-BWhitelist: no X-Exim-ID: 1dutkx-00118R-OB X-Source-Sender: 75-166-76-94.hlrn.qwest.net (bapiya.Home) [75.166.76.94]:36574 X-Source-Auth: tom+tromey.com X-Email-Count: 60 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes Note that this commit also changes deprecated_file_changed_hook -- not used in the tree, but Insight will require a (presumably minor) change. ChangeLog 2017-09-20 Tom Tromey * symfile.c (symbol_file_command): Constify. * gdbcore.h (deprecated_file_changed_hook): Constify. * exec.c (deprecated_file_changed_hook, exec_file_command) (file_command): Constify. * defs.h (symbol_file_command): Constify. --- gdb/ChangeLog | 8 ++++++++ gdb/defs.h | 2 +- gdb/exec.c | 8 +++----- gdb/gdbcore.h | 2 +- gdb/symfile.c | 2 +- 5 files changed, 14 insertions(+), 8 deletions(-) diff --git a/gdb/defs.h b/gdb/defs.h index af9e32e..a25ebf6 100644 --- a/gdb/defs.h +++ b/gdb/defs.h @@ -304,7 +304,7 @@ EXTERN_C char *re_comp (const char *); /* From symfile.c */ -extern void symbol_file_command (char *, int); +extern void symbol_file_command (const char *, int); /* * Remote targets may wish to use this as their load function. */ extern void generic_load (const char *name, int from_tty); diff --git a/gdb/exec.c b/gdb/exec.c index d20afdc..6eda9b2 100644 --- a/gdb/exec.c +++ b/gdb/exec.c @@ -45,12 +45,10 @@ #include "solist.h" #include -void (*deprecated_file_changed_hook) (char *); +void (*deprecated_file_changed_hook) (const char *); /* Prototypes for local functions */ -static void file_command (char *, int); - static void set_section_command (char *, int); static void exec_files_info (struct target_ops *); @@ -398,7 +396,7 @@ exec_file_attach (const char *filename, int from_tty) If ARGS is NULL, we just want to close the exec file. */ static void -exec_file_command (char *args, int from_tty) +exec_file_command (const char *args, int from_tty) { char *filename; @@ -433,7 +431,7 @@ exec_file_command (char *args, int from_tty) command was added? */ static void -file_command (char *arg, int from_tty) +file_command (const char *arg, int from_tty) { /* FIXME, if we lose on reading the symbol file, we should revert the exec file, but that's rough. */ diff --git a/gdb/gdbcore.h b/gdb/gdbcore.h index 7554245..5c86e98 100644 --- a/gdb/gdbcore.h +++ b/gdb/gdbcore.h @@ -127,7 +127,7 @@ extern void (*deprecated_exec_file_display_hook) (const char *filename); /* Hook for "file_command", which is more useful than above (because it is invoked AFTER symbols are read, not before). */ -extern void (*deprecated_file_changed_hook) (char *filename); +extern void (*deprecated_file_changed_hook) (const char *filename); extern void specify_exec_file_hook (void (*hook) (const char *filename)); diff --git a/gdb/symfile.c b/gdb/symfile.c index c6e3b90..c6d657b 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -1617,7 +1617,7 @@ find_separate_debug_file_by_debuglink (struct objfile *objfile) conventions (because it is confusing and inconvenient). */ void -symbol_file_command (char *args, int from_tty) +symbol_file_command (const char *args, int from_tty) { dont_repeat ();