From patchwork Thu Sep 21 05:09:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 23049 Received: (qmail 73552 invoked by alias); 21 Sep 2017 05:42:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 73391 invoked by uid 89); 21 Sep 2017 05:42:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=OTHER X-HELO: gproxy5-pub.mail.unifiedlayer.com Received: from gproxy5-pub.mail.unifiedlayer.com (HELO gproxy5-pub.mail.unifiedlayer.com) (67.222.38.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Sep 2017 05:42:07 +0000 Received: from cmgw2 (unknown [10.0.90.83]) by gproxy5.mail.unifiedlayer.com (Postfix) with ESMTP id 912FB140718 for ; Wed, 20 Sep 2017 23:41:06 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id C5h31w00z2f2jeq015h69K; Wed, 20 Sep 2017 23:41:06 -0600 X-Authority-Analysis: v=2.2 cv=dZfw5Tfe c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=2JCJgTwv5E4A:10 a=zstS-IiYAAAA:8 a=bQWHf_1SwRPG-ZXvGVEA:9 a=F3docbZQo-WKLBWz:21 a=PYxlA3IQTitxHwU8:21 a=4G6NA9xxw8l3yy4pmD5M:22 Received: from 75-166-76-94.hlrn.qwest.net ([75.166.76.94]:36574 helo=bapiya.Home) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dutkx-00118R-AF; Wed, 20 Sep 2017 23:10:35 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 40/67] Constify some commands in tracepoint.c Date: Wed, 20 Sep 2017 23:09:56 -0600 Message-Id: <20170921051023.19023-41-tom@tromey.com> In-Reply-To: <20170921051023.19023-1-tom@tromey.com> References: <20170921051023.19023-1-tom@tromey.com> X-BWhitelist: no X-Exim-ID: 1dutkx-00118R-AF X-Source-Sender: 75-166-76-94.hlrn.qwest.net (bapiya.Home) [75.166.76.94]:36574 X-Source-Auth: tom+tromey.com X-Email-Count: 61 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes ChangeLog 2017-09-20 Tom Tromey * tracepoint.c (delete_trace_variable_command) (tfind_end_command, tfind_start_command, tfind_pc_command) (tfind_tracepoint_command, tfind_line_command) (tfind_range_command, tfind_outside_command): Constify. --- gdb/ChangeLog | 7 +++++++ gdb/tracepoint.c | 42 ++++++++++++++++-------------------------- 2 files changed, 23 insertions(+), 26 deletions(-) diff --git a/gdb/tracepoint.c b/gdb/tracepoint.c index 52a449a..30e3a3a 100644 --- a/gdb/tracepoint.c +++ b/gdb/tracepoint.c @@ -165,18 +165,6 @@ char *trace_notes = NULL; char *trace_stop_notes = NULL; -/* ======= Important command functions: ======= */ -static void actions_command (char *, int); -static void tstart_command (char *, int); -static void tstop_command (char *, int); -static void tstatus_command (char *, int); -static void tfind_pc_command (char *, int); -static void tfind_tracepoint_command (char *, int); -static void tfind_line_command (char *, int); -static void tfind_range_command (char *, int); -static void tfind_outside_command (char *, int); -static void tdump_command (char *, int); - /* support routines */ struct collection_list; @@ -442,7 +430,7 @@ trace_variable_command (char *args, int from_tty) } static void -delete_trace_variable_command (char *args, int from_tty) +delete_trace_variable_command (const char *args, int from_tty) { if (args == NULL) { @@ -2362,21 +2350,21 @@ tfind_command (char *args, int from_tty) /* tfind end */ static void -tfind_end_command (char *args, int from_tty) +tfind_end_command (const char *args, int from_tty) { tfind_command_1 ("-1", from_tty); } /* tfind start */ static void -tfind_start_command (char *args, int from_tty) +tfind_start_command (const char *args, int from_tty) { tfind_command_1 ("0", from_tty); } /* tfind pc command */ static void -tfind_pc_command (char *args, int from_tty) +tfind_pc_command (const char *args, int from_tty) { CORE_ADDR pc; @@ -2392,7 +2380,7 @@ tfind_pc_command (char *args, int from_tty) /* tfind tracepoint command */ static void -tfind_tracepoint_command (char *args, int from_tty) +tfind_tracepoint_command (const char *args, int from_tty) { int tdp; struct tracepoint *tp; @@ -2428,7 +2416,7 @@ tfind_tracepoint_command (char *args, int from_tty) corresponding to a source line OTHER THAN THE CURRENT ONE. */ static void -tfind_line_command (char *args, int from_tty) +tfind_line_command (const char *args, int from_tty) { check_trace_running (current_trace_status ()); @@ -2486,10 +2474,10 @@ tfind_line_command (char *args, int from_tty) /* tfind range command */ static void -tfind_range_command (char *args, int from_tty) +tfind_range_command (const char *args, int from_tty) { static CORE_ADDR start, stop; - char *tmp; + const char *tmp; check_trace_running (current_trace_status ()); @@ -2501,9 +2489,10 @@ tfind_range_command (char *args, int from_tty) if (0 != (tmp = strchr (args, ','))) { - *tmp++ = '\0'; /* Terminate start address. */ + std::string start_addr (args, tmp); + ++tmp; tmp = skip_spaces (tmp); - start = parse_and_eval_address (args); + start = parse_and_eval_address (start_addr.c_str ()); stop = parse_and_eval_address (tmp); } else @@ -2517,10 +2506,10 @@ tfind_range_command (char *args, int from_tty) /* tfind outside command */ static void -tfind_outside_command (char *args, int from_tty) +tfind_outside_command (const char *args, int from_tty) { CORE_ADDR start, stop; - char *tmp; + const char *tmp; if (current_trace_status ()->running && current_trace_status ()->filename == NULL) @@ -2534,9 +2523,10 @@ tfind_outside_command (char *args, int from_tty) if (0 != (tmp = strchr (args, ','))) { - *tmp++ = '\0'; /* Terminate start address. */ + std::string start_addr (args, tmp); + ++tmp; tmp = skip_spaces (tmp); - start = parse_and_eval_address (args); + start = parse_and_eval_address (start_addr.c_str ()); stop = parse_and_eval_address (tmp); } else