From patchwork Thu Sep 21 05:09:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 23005 Received: (qmail 77604 invoked by alias); 21 Sep 2017 05:15:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 36592 invoked by uid 89); 21 Sep 2017 05:10:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Sep 2017 05:10:35 +0000 Received: from cmgw3 (unknown [10.0.90.84]) by gproxy6.mail.unifiedlayer.com (Postfix) with ESMTP id B0FF01E08A3 for ; Wed, 20 Sep 2017 23:10:33 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id C5AW1w00Y2f2jeq015AZMD; Wed, 20 Sep 2017 23:10:33 -0600 X-Authority-Analysis: v=2.2 cv=K/VSJ2eI c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=2JCJgTwv5E4A:10 a=zstS-IiYAAAA:8 a=JxuPPchkNJM38_Dmy6wA:9 a=4G6NA9xxw8l3yy4pmD5M:22 Received: from 75-166-76-94.hlrn.qwest.net ([75.166.76.94]:36574 helo=bapiya.Home) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dutks-00118R-Ki; Wed, 20 Sep 2017 23:10:30 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 21/67] Constify commands in cli-dump.c Date: Wed, 20 Sep 2017 23:09:37 -0600 Message-Id: <20170921051023.19023-22-tom@tromey.com> In-Reply-To: <20170921051023.19023-1-tom@tromey.com> References: <20170921051023.19023-1-tom@tromey.com> X-BWhitelist: no X-Exim-ID: 1dutks-00118R-Ki X-Source-Sender: 75-166-76-94.hlrn.qwest.net (bapiya.Home) [75.166.76.94]:36574 X-Source-Auth: tom+tromey.com X-Email-Count: 22 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes ChangeLog 2017-09-20 Tom Tromey * cli/cli-dump.c (dump_memory_command, dump_value_command) (dump_srec_memory, dump_srec_value, dump_ihex_memory) (dump_ihex_value, dump_verilog_memory, dump_verilog_value) (dump_tekhex_memory, dump_tekhex_value, dump_binary_memory) (dump_binary_value, append_binary_memory, append_binary_value): Constify. (struct dump_context) : Constify. (add_dump_command): Update. --- gdb/ChangeLog | 11 +++++++++++ gdb/cli/cli-dump.c | 32 ++++++++++++++++---------------- 2 files changed, 27 insertions(+), 16 deletions(-) diff --git a/gdb/cli/cli-dump.c b/gdb/cli/cli-dump.c index 550548a..f4ea2d7 100644 --- a/gdb/cli/cli-dump.c +++ b/gdb/cli/cli-dump.c @@ -215,7 +215,7 @@ dump_memory_to_file (const char *cmd, const char *mode, const char *file_format) } static void -dump_memory_command (char *cmd, const char *mode) +dump_memory_command (const char *cmd, const char *mode) { dump_memory_to_file (cmd, mode, "binary"); } @@ -260,86 +260,86 @@ dump_value_to_file (const char *cmd, const char *mode, const char *file_format) } static void -dump_value_command (char *cmd, const char *mode) +dump_value_command (const char *cmd, const char *mode) { dump_value_to_file (cmd, mode, "binary"); } static void -dump_srec_memory (char *args, int from_tty) +dump_srec_memory (const char *args, int from_tty) { dump_memory_to_file (args, FOPEN_WB, "srec"); } static void -dump_srec_value (char *args, int from_tty) +dump_srec_value (const char *args, int from_tty) { dump_value_to_file (args, FOPEN_WB, "srec"); } static void -dump_ihex_memory (char *args, int from_tty) +dump_ihex_memory (const char *args, int from_tty) { dump_memory_to_file (args, FOPEN_WB, "ihex"); } static void -dump_ihex_value (char *args, int from_tty) +dump_ihex_value (const char *args, int from_tty) { dump_value_to_file (args, FOPEN_WB, "ihex"); } static void -dump_verilog_memory (char *args, int from_tty) +dump_verilog_memory (const char *args, int from_tty) { dump_memory_to_file (args, FOPEN_WB, "verilog"); } static void -dump_verilog_value (char *args, int from_tty) +dump_verilog_value (const char *args, int from_tty) { dump_value_to_file (args, FOPEN_WB, "verilog"); } static void -dump_tekhex_memory (char *args, int from_tty) +dump_tekhex_memory (const char *args, int from_tty) { dump_memory_to_file (args, FOPEN_WB, "tekhex"); } static void -dump_tekhex_value (char *args, int from_tty) +dump_tekhex_value (const char *args, int from_tty) { dump_value_to_file (args, FOPEN_WB, "tekhex"); } static void -dump_binary_memory (char *args, int from_tty) +dump_binary_memory (const char *args, int from_tty) { dump_memory_to_file (args, FOPEN_WB, "binary"); } static void -dump_binary_value (char *args, int from_tty) +dump_binary_value (const char *args, int from_tty) { dump_value_to_file (args, FOPEN_WB, "binary"); } static void -append_binary_memory (char *args, int from_tty) +append_binary_memory (const char *args, int from_tty) { dump_memory_to_file (args, FOPEN_AB, "binary"); } static void -append_binary_value (char *args, int from_tty) +append_binary_value (const char *args, int from_tty) { dump_value_to_file (args, FOPEN_AB, "binary"); } struct dump_context { - void (*func) (char *cmd, const char *mode); + void (*func) (const char *cmd, const char *mode); const char *mode; }; @@ -353,7 +353,7 @@ call_dump_func (struct cmd_list_element *c, char *args, int from_tty) static void add_dump_command (const char *name, - void (*func) (char *args, const char *mode), + void (*func) (const char *args, const char *mode), const char *descr) {