From patchwork Tue Sep 12 18:57:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 22854 Received: (qmail 117274 invoked by alias); 12 Sep 2017 18:57:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 117148 invoked by uid 89); 12 Sep 2017 18:57:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Sep 2017 18:57:47 +0000 Received: from CMOut01 (unknown [10.0.90.82]) by gproxy6.mail.unifiedlayer.com (Postfix) with ESMTP id E2B1E1E06AD for ; Tue, 12 Sep 2017 12:57:44 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id 8ixh1w00e2f2jeq01ixko1; Tue, 12 Sep 2017 12:57:44 -0600 X-Authority-Analysis: v=2.2 cv=K4VSJ2eI c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=2JCJgTwv5E4A:10 a=zstS-IiYAAAA:8 a=GZM7enTt6mGJrk3XGwkA:9 a=4G6NA9xxw8l3yy4pmD5M:22 Received: from 75-166-76-94.hlrn.qwest.net ([75.166.76.94]:46142 helo=bapiya.Home) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1drqNR-001eRR-9R; Tue, 12 Sep 2017 12:57:41 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 04/11] Don't copy a string in mi_cmd_disassemble Date: Tue, 12 Sep 2017 12:57:29 -0600 Message-Id: <20170912185736.20436-5-tom@tromey.com> In-Reply-To: <20170912185736.20436-1-tom@tromey.com> References: <20170912185736.20436-1-tom@tromey.com> X-BWhitelist: no X-Exim-ID: 1drqNR-001eRR-9R X-Source-Sender: 75-166-76-94.hlrn.qwest.net (bapiya.Home) [75.166.76.94]:46142 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes This string copy in mi_cmd_disassemble seems not to be needed, so don't do it. ChangeLog 2017-09-12 Tom Tromey * mi/mi-cmd-disas.c (mi_cmd_disassemble): Don't copy "oarg". --- gdb/ChangeLog | 4 ++++ gdb/mi/mi-cmd-disas.c | 6 +----- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b1fdcda..c981c7e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2017-09-12 Tom Tromey + * mi/mi-cmd-disas.c (mi_cmd_disassemble): Don't copy "oarg". + +2017-09-12 Tom Tromey + * varobj.h (varobj_gen_name): Return std::string. * varobj.c (varobj_gen_name): Return std::string. * mi/mi-cmd-var.c (mi_cmd_var_create): Use std::string. diff --git a/gdb/mi/mi-cmd-disas.c b/gdb/mi/mi-cmd-disas.c index d0f9b0b..b3d6245 100644 --- a/gdb/mi/mi-cmd-disas.c +++ b/gdb/mi/mi-cmd-disas.c @@ -74,7 +74,6 @@ mi_cmd_disassemble (const char *command, char **argv, int argc) int how_many = -1; CORE_ADDR low = 0; CORE_ADDR high = 0; - struct cleanup *cleanups = make_cleanup (null_cleanup, NULL); /* Options processing stuff. */ int oind = 0; @@ -104,9 +103,8 @@ mi_cmd_disassemble (const char *command, char **argv, int argc) switch ((enum opt) opt) { case FILE_OPT: - file_string = xstrdup (oarg); + file_string = oarg; file_seen = 1; - make_cleanup (xfree, file_string); break; case LINE_OPT: line_num = atoi (oarg); @@ -190,6 +188,4 @@ mi_cmd_disassemble (const char *command, char **argv, int argc) gdb_disassembly (gdbarch, uiout, disasm_flags, how_many, low, high); - - do_cleanups (cleanups); }