From patchwork Tue Aug 1 09:20:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Terekhov, Mikhail via Gdb-patches" X-Patchwork-Id: 21838 Received: (qmail 66191 invoked by alias); 1 Aug 2017 09:20:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 65987 invoked by uid 89); 1 Aug 2017 09:20:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=H*MI:google X-HELO: mail-wm0-f74.google.com Received: from mail-wm0-f74.google.com (HELO mail-wm0-f74.google.com) (74.125.82.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Aug 2017 09:20:46 +0000 Received: by mail-wm0-f74.google.com with SMTP id a186so52286wmh.6 for ; Tue, 01 Aug 2017 02:20:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:date:message-id:subject:from:to:cc; bh=4C078Nm6DdKxgPsEQSqb+cBazTGYDPHOwsSPx/pkbsw=; b=p/3ktyD6KdSCA6dI3Mxsc6m/IfBN29KBYV57GYjtGOir5OF15Hrtu0b0tKXF/WolX7 oxVkWYJ8371xk5s6BcAHp8qHOs0y+Brxo6ckOSZRtXX+VZFftb4lRUb5BxERT04yzhtG Xh9MpoeAsjg8xgz0ftHhnSQdQjSP9Hl6Abq2nFccKgQzUWny7RVa3h+Z1fgWGaI1ALbd b/n6IegUHCczPkASsJOIWkSLaXTGSZPcH1fScsbFQybDsx33QV0IjQ8cj0f1hsAR/oHs IOo/05JasuFCFdFP1CjgtndagWB+r+aGOgUnppiHcCBOgAvLDSP2KBtjy5qO4el5aZvY fRUA== X-Gm-Message-State: AIVw113EHJNTqg7geGlslYLEWXxJeiOeeKqrrJJ3SM3VQjILp/fb+57Q RHc8VpLytONLJ0VHJCsPtwVRQHrqUa1WXsU0PNEQwC+tRhZwMQ3y6LaYo1L65zKAPUwCqzf3Ij0 F5JhiQvGd0n/76WyzptqhDt7LAQzspw6wehu7ErlDFYEtS5+UNTkDcX7orKrQ MIME-Version: 1.0 X-Received: by 10.28.92.208 with SMTP id q199mr54582wmb.2.1501579244035; Tue, 01 Aug 2017 02:20:44 -0700 (PDT) Date: Tue, 1 Aug 2017 10:20:30 +0100 Message-Id: <20170801092030.70676-1-leszeks@google.com> Subject: [PATCH] Fix dwarf2_string_attr for -gsplit-dwarf X-Patchwork-Original-From: "Leszek Swirski via gdb-patches" From: "Terekhov, Mikhail via Gdb-patches" Reply-To: Leszek Swirski To: gdb-patches@sourceware.org Cc: Leszek Swirski The dwarf2_string_attr did not allow DW_FORM_GNU_str_index as a form for string types. This manifested as null strings in the namespace_name lookup (replaced with "(anonymous namespace)") when debugging Fission-compiled code. gdb/doc/ChangeLog: * dwarf2read.c: Fix dwarf2_string_attr to allow DW_FORM_GNU_str_index --- gdb/dwarf2read.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index 2c2ecda7fc..f5bed09116 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -17623,7 +17623,8 @@ dwarf2_string_attr (struct die_info *die, unsigned int name, struct dwarf2_cu *c if (attr != NULL) { if (attr->form == DW_FORM_strp || attr->form == DW_FORM_line_strp - || attr->form == DW_FORM_string || attr->form == DW_FORM_GNU_strp_alt) + || attr->form == DW_FORM_string || DW_FORM_GNU_str_index + || attr->form == DW_FORM_GNU_strp_alt) str = DW_STRING (attr); else complaint (&symfile_complaints,