From patchwork Tue May 2 19:32:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 20226 Received: (qmail 123283 invoked by alias); 2 May 2017 19:32:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 123253 invoked by uid 89); 2 May 2017 19:32:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=forever X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 May 2017 19:32:57 +0000 Received: from ESESSHC009.ericsson.se (Unknown_Domain [153.88.183.45]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id C6.F1.00351.8EED8095; Tue, 2 May 2017 21:32:57 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.45) with Microsoft SMTP Server (TLS) id 14.3.339.0; Tue, 2 May 2017 21:32:55 +0200 Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=ericsson.com; Received: from elxcz23q12-y4.ca.am.ericsson.se (192.75.88.130) by VI1PR07MB1725.eurprd07.prod.outlook.com (10.166.143.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1075.1; Tue, 2 May 2017 19:32:53 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH] gdbarch.sh: Remove commented out TARGET_CHAR_BIT definition Date: Tue, 2 May 2017 15:32:40 -0400 Message-ID: <20170502193240.17920-1-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: CY4PR20CA0012.namprd20.prod.outlook.com (10.173.116.150) To VI1PR07MB1725.eurprd07.prod.outlook.com (10.166.143.21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a35720e1-99e0-4c18-c4fb-08d49192079f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:VI1PR07MB1725; X-Microsoft-Exchange-Diagnostics: 1; VI1PR07MB1725; 3:g5UISTcQRMj6VA4rKPRq9vcRoEyPc1Sak5KWtbNQrQXr7wB0XvzyqtFHH5DsPIq/B1NFyJBX9BzWgERTqnx8fzFTPRlD60SeQrbTzhJPr88xKUQ3UwBJUleb3fVm9puifNvEHaJNeuYWgTDM241k4LrAd+ul5DeeuvZi4aCmT8usgAKgJWr57uf97r/2/q4s3iBxCXfU9vBH+R+lkH8usdRch9gOMf6Rr2kpDntBHQwVsxdseFXoy/SXnExqENm/wl0YzzJ7T7wfRiApOz7QFv/vSRpKN0GiWkXijmjnQz5Z19FYtrB3Kot54El2LOf2Vt35UldCPsT1ktark9QC9g==; 25:G7NcKz7QYVcI/j8KgksZP4/5nnxsnGYHLMs4RhH9x40+soDuKdNHMnT0ZIMpqm+K7keXlCw7VbMzRNekqlGendmYNHDmYOrEm+oFwwAHGJrfa6gtfeslBof8WG7dgV2ZRxXKrdQWYO3/xijtNyRjGFIzM+zmBpBj4IX2ky23InE/yh78Gpar54FqKXM5xFCORk50+UkYOg2nYtbKDIOO12qcCJhThaWXh9vi9aXsJajV1RcxSWAhPtCL2lsexpbZeqDCC4bk1ZavfCh31m5N/7m4QZKDHE5/uCmKXWtlitPU8N+MP3e9jgi8t/WOkbpnqIgFiwcNGB6CiPUxMn1yslsMX+JBTTMEu0Ij7gFU87TfXeYDgIQZGf9RlVlUf4cd/tAQd95J9+S9EwvD65GIuCqtu38v6vDpAF27FpyMhtpJYx66VW062sbMY1LTyIBvQ7q8lrKHDRgjLlQbzTIt+5pCQovGGKZ4MSAC4RskveQ= X-Microsoft-Exchange-Diagnostics: 1; VI1PR07MB1725; 31:UWB/bCqHWsfh4nHN88kUuSiSIqGq5DGE4YXEC5dwbYG36KuGtRsg9AhueL865O0rOMhmu0rEn7bhsjoaCH92B9Vfo35QM9C/B4wNWygBr7DaIY1dINU3p3/w5qN1tNSN8culVGeTV2dWTOWOyezPdyZVj0QiqOYjEBh9Rt2fKPL+eHsUjpOHGFh4+REP4lxVDBo/UGP/cvtXeNPV+68epmARuCDbB9NYfscGC1HEccCnPBggjEl86HawpZIVOyjF; 20:0owumV3bTp9PkgfohzouwIS002rkoO+5Ml5ZwvxuojsVR1EhdFZI6JpSTd5SzK1/59m4gafrs2+2coL0jGEUVBvGqYNgJsUm2clW/R8xsZ31fofAEp4huDELh62ObZGx/kIpEQ8kCa57OJ+vVZtNjJNPn0tCiGUZVEEcKK1Ks77w4/2PKEMOWqiBC5iJKVIdSQP1t6gQt1HDZmdKAju/9Dj4pbHL9JlXW5ftlzwl9ygQ31a/3C2KBRspCwD1oDcYxV3dhBL6UUaMj2EkwpWqr3A3O1iCqYAlMZrr8GCismO5nIETgugWxB4ejbueas6BwIeZBdSwyoKgZ/wGqgL3xYtbjFVD4y9ehX4B2oZSjMbcwRCZWm6HhmO36qXbGe//nFU1QVCPJ0T0ru3xeIyk6RQPB2mhX5FIeL10kNVyLFNrsIiO8LLJFPg7+SSq1gEEtejRteYN3wrwnjkxZslKPrYcbkxK/NpUmBteyZbecfBwjaj92HdUmxov495ODCxR X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(6041248)(20161123555025)(20161123562025)(20161123564025)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148); SRVR:VI1PR07MB1725; BCL:0; PCL:0; RULEID:; SRVR:VI1PR07MB1725; X-Microsoft-Exchange-Diagnostics: 1; VI1PR07MB1725; 4:njwFwrrAuc4uxk0ZWWcp97pxFmYn/OshBzg+3jEaqGwrMYwMa3yZ5stpfpe3lQ594IHIbQUzYTbi0w5SmEqFHntkc2MpNou1Sv1n5T2w4KogX7sjHOymU+nED10+fbRhUzOCV/uVoR6v3+JrkIMZQFoHZnCdu7D6DvCurH15+JFipxvqvizCqeH9swMngrm7kdCjEuL30LkxMb9hBxQ/i2/EdQtwF8QUzf+q76T/kP8h7/dQAYYoSOqIrd6EPh3+cnxVUq9spO6cldk/mHUnzNWdWXPUPyNiWXPnm2MywXqjkliB6z/TnkgWcYqbnIThm/TaaGn7vyIPVUZiYdpHLHSkcTK8GO3c+lhErnoFyzJosEdU0cYHFLBtSVjb9d5veOPL9uTzivN2CEcm54BwvOzhdTTaA8L1WqsvW6vzT9B059ipbQdG8O93hr/WolLS7MFY0cznmxjAxgD5ChzEJCvheMhd6y/zeyWSNvShYrLgsrYlZC/jZRg8jIaULI95qKXHjUm1QXlFbz7HVXMuIBuYMljqnQ+lbO8JiPWx2hphIHiV/yRKfu7e7UfxVpedX8Nj6H6/cXF9SSv/YizgtxqaHYHg3yFRCuR18JEQyZz39NU1/Z0mTtWhzfTUDGQIDyE3UMRGclZG9CTYmAtST1dsf4K5C9p9+7znTz0uae7xjqbZvLxcHoMTWGeFNNi+VhBG/T0Ko4MOe1mojxBZ+3nXG6sD2bzWUFt0hZJ7MUhspGeT0BPsaI30UQqHbui3L7J+1CF97ikpEHfTN98PqrON1JBNikhE85PQASvHwoQ= X-Forefront-PRVS: 02951C14DC X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39400400002)(39410400002)(39840400002)(39860400002)(39850400002)(54534003)(50226002)(5003940100001)(2351001)(107886003)(110136004)(6512007)(86362001)(478600001)(81166006)(33646002)(4326008)(38730400002)(189998001)(53936002)(42186005)(6486002)(6506006)(8676002)(5660300001)(6916009)(66066001)(36756003)(50466002)(50986999)(25786009)(7736002)(6116002)(3846002)(1076002)(305945005)(6666003)(2906002)(48376002)(47776003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR07MB1725; H:elxcz23q12-y4.ca.am.ericsson.se; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR07MB1725; 23:z2xT+EkbAk1OznkwR8GEf2YqwcHzSWlQNTal3SQ0R?= =?us-ascii?Q?RnROszcGFf9FlrCzbpmadr+UTegmaEb8sBlAT7jOnSZZsUuYFYJ3uU17eKEH?= =?us-ascii?Q?TZt11mTu0BDc3CAFI/wHC8IgMVNAUo339GYRSu/jniNfAoNxL0oshcsC4HIo?= =?us-ascii?Q?AdSJIzk/XGf6r5acd5Xna5CR17VvbEzSqLTtqcLF22zI3ThK++mpwVO0/8kP?= =?us-ascii?Q?WGG/cR4x+aT5CVfEQFBTqzAtShpPcDiqhdzalxxR8MH8cUWejqX9Tvf7xTgz?= =?us-ascii?Q?zXf2cZBa5kepwz2UU0XYj2WCLRfPYf+oB7L/c5fU8GrqB+wdygcow3MdRvzz?= =?us-ascii?Q?+UhJPRjz9bWnqi8CaRz5Wigpawwxc4GXv1bGn6ZQjsYzMeY1nLzQjprJ9iU7?= =?us-ascii?Q?PsMHP+DYtPZgQLXWAaFgJB/EHJfpBLQn+VvPmFGOTuV6oO+4G1tVoqbBAR7l?= =?us-ascii?Q?hJlO3lVUmxjY5EHzDc/vRGwURIGC9jnK56CJobOLFFWOiPAI/z3IWvGpFj1n?= =?us-ascii?Q?11l2q3AeYFEF7TbDVyJ0jCifHEquXnpqsdx5f7X6Ar56TipPvNe4igDfv5ha?= =?us-ascii?Q?2UdFopcVHGMA8HCW1lXZ3IF5kljL04+SGBb7Mkum93DQ7j2KGJ6WRVGFVRtf?= =?us-ascii?Q?hAo8WuvvEgyxcHIsAdt0hLpou7XSwu88RX8JHUHw0whKQitdDCqt5TDB0Vei?= =?us-ascii?Q?JfKfCkH3Nyr7oWMPtOuD5pQp+1415vi8meU2a3yyewSqz8L0VQ8eEE6W8hNY?= =?us-ascii?Q?hN/+3g+XlTeJCzzlGzLhd8BctPoAIKVd6qTsI/EbeVVhXNTuQrg+z+oLAm6k?= =?us-ascii?Q?Fwn7QDqVpo/VQrfs8wuIBoMSiMYQwKznsejrUmf+2IdA+JJRIhaeFte0g3+L?= =?us-ascii?Q?u75/1PmtK652M5edzHmyF2l0sJfzdsM4I2Uj6iaC4weD5vAgKwaLQcDpCyJV?= =?us-ascii?Q?zbCG6ojf3MP9SGLB3UsGj+R0vpM962ZgQ5iorPVv9cpEMe2kToR520MaXcLm?= =?us-ascii?Q?8+UVaTbfXRCwg4ngWCkee0lEruRP+lgcwb9tPHPLior7mepV8TS4LQJziwI5?= =?us-ascii?Q?vKvg2Y=3D?= X-Microsoft-Exchange-Diagnostics: 1; VI1PR07MB1725; 6:tdwyXl5lHbmwqsWj3GISc+QJDK3ORKNW/+OR2bLHZODazLksnp65/e0+4OBe17/vVvfzbmh0czQonFBJ3uAg0UeArDAKtNvnW5UvwXwXwROlzButIEDY7sxjfdy9hIc5kupbSA3LegzTCy7Bj4GBJXF8zfCtiKlSOzAM44e6ckMNfY/A6JdKpRLDvEfbQ1xTRFmOBu/Atqzzx5itSkDwOJnQl4yg1GIzCNb6TIdNXDyTOo3Wab0OfEoe6b1NJWs82LcQqdHYfNodnU1BZHbp0oN7l1GKHfXYInFdYRd6KP6grAsk4UeVW9rObkMXcXh+KSL9lGkkhiZjbDWbTsb0DzaKe17TDyalA/u6tcAF/T5pwZOky2/Si7PxGyq+FXCGeTAE0nIqDGYpzdYr6ZocfW7OI8ZOXg2WH+KpM+OjuQX19h8x1r5v+O9jNoI5bhWoUm0AK7l7n2o0MEaOD+eNMtKpZo0Ifm8hNPRRvcWTqV0wt5AISo7iglDRmLLMpGYVD+eRGUFzpP8nJBmBbrtTQA==; 5:mW0O9IJ8ZiehIACfJFiElzgFj+vmE8lP++GH+mnqs4bBCmgRejDDgp3jtmujz/I8EB+knaOVopI3aNLgFl/30fwrkaoVjoTR/KYi31yG33JjWZl/+ty1Q1uiwIjv5NqAUCt1YjV5FZT7IqkiEFuAug==; 24:albiqUCvEyXsyAcMEAs6QHZ/8h0KGDqGMTxKU8FIz0gVZOSR4eUjbIWHDFym08Y/TQ8L0k7db9Rc0UtKhfspucL6XXoNr8pCtGO+p7yPPBE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR07MB1725; 7:DhquvvHugbpmokYL3uGehh8/yw2ZybdhmyqkeDwzLMM8Vh8gawreOaTN+ii4XpShTnjENXkmaRhIlxE4TlrgU5yWmeemy/NYcN/lgsMs2Oy3Vw/jxqoQSJuP1vjXgpDNSN7LR9sMT27oJ8TDc1jNHXggCuNLoJmrhwiqaF6j5i3xog3Xp5w4r7byCTB4k30yMfvh8EM0dVYuZYlAxvQYubRPhOhzqDPrKltEZkCDRceMNafyKvISMl7GEbk0Sv3syzKsTgb5vsVa6cGk1f+XGb8+nW5s7XfZO1TIxzFqjCMXCyOYvg+nyU6s4CRjKyqrzUD4SZxHLMkkVgnzOrL5PQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2017 19:32:53.7587 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB1725 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes As Pedro commented on the patch "Change field separator in gdbarch.sh", this commented out definition is probably not useful and should be removed. It has been commented out for basically forever, and it probably serves the same intent as addressable_memory_unit_size. gdb/ChangeLog: * gdbarch.sh: Remove commented out definition of TARGET_CHAR_BIT. --- gdb/gdbarch.h | 6 +----- gdb/gdbarch.sh | 4 ---- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h index 442bef165a..15a81418b0 100644 --- a/gdb/gdbarch.h +++ b/gdb/gdbarch.h @@ -128,11 +128,7 @@ extern const struct target_desc * gdbarch_target_desc (struct gdbarch *gdbarch); extern int gdbarch_bits_big_endian (struct gdbarch *gdbarch); extern void set_gdbarch_bits_big_endian (struct gdbarch *gdbarch, int bits_big_endian); -/* Number of bits in a char or unsigned char for the target machine. - Just like CHAR_BIT in but describes the target machine. - v;TARGET_CHAR_BIT;int;char_bit;;;;8 * sizeof (char);8;;0; - - Number of bits in a short or unsigned short for the target machine. */ +/* Number of bits in a short or unsigned short for the target machine. */ extern int gdbarch_short_bit (struct gdbarch *gdbarch); extern void set_gdbarch_short_bit (struct gdbarch *gdbarch, int short_bit); diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh index 68163a1947..753819f321 100755 --- a/gdb/gdbarch.sh +++ b/gdb/gdbarch.sh @@ -351,10 +351,6 @@ i;const struct target_desc *;target_desc;;;;;;;host_address_to_string (gdbarch-> # and such. Conceptually, it's quite separate from byte/word byte order. v;int;bits_big_endian;;;1;(gdbarch->byte_order == BFD_ENDIAN_BIG);;0 -# Number of bits in a char or unsigned char for the target machine. -# Just like CHAR_BIT in but describes the target machine. -# v;TARGET_CHAR_BIT;int;char_bit;;;;8 * sizeof (char);8;;0; -# # Number of bits in a short or unsigned short for the target machine. v;int;short_bit;;;8 * sizeof (short);2*TARGET_CHAR_BIT;;0 # Number of bits in an int or unsigned int for the target machine.