diff mbox

[RFA,10/10] Call wrap_hint in one more spot in py-framefilter.c

Message ID 20170425194113.17862-11-tom@tromey.com
State New, archived
Headers

Commit Message

Tom Tromey April 25, 2017, 7:41 p.m. UTC 
  PR python/16486 notes that "bt" output is still wrapped differently
when a frame filter is in use.  This patch brings it a bit closer by
adding one more wrap_hint call, in a place where stack.c does this as
well.

ChangeLog
2017-04-25  Tom Tromey  <tom@tromey.com>

	PR python/16486:
	* python/py-framefilter.c (py_print_args): Call wrap_hint.
---
 gdb/ChangeLog               | 5 +++++
 gdb/python/py-framefilter.c | 1 +
 2 files changed, 6 insertions(+)

Comments

Phil Muldoon April 28, 2017, 3:09 p.m. UTC | #1 
On 25/04/17 20:41, Tom Tromey wrote:
> PR python/16486 notes that "bt" output is still wrapped differently
> when a frame filter is in use.  This patch brings it a bit closer by
> adding one more wrap_hint call, in a place where stack.c does this as
> well.
> 
> ChangeLog
> 2017-04-25  Tom Tromey  <tom@tromey.com>
> 
> 	PR python/16486:
> 	* python/py-framefilter.c (py_print_args): Call wrap_hint.

Thanks for catching this. LGTM

Cheers

Phil
Pedro Alves June 27, 2017, 5:35 p.m. UTC | #2 
On 04/28/2017 04:09 PM, Phil Muldoon wrote:
> On 25/04/17 20:41, Tom Tromey wrote:
>> PR python/16486 notes that "bt" output is still wrapped differently
>> when a frame filter is in use.  This patch brings it a bit closer by
>> adding one more wrap_hint call, in a place where stack.c does this as
>> well.
>>
>> ChangeLog
>> 2017-04-25  Tom Tromey  <tom@tromey.com>
>>
>> 	PR python/16486:
>> 	* python/py-framefilter.c (py_print_args): Call wrap_hint.
> 
> Thanks for catching this. LGTM

To me too.

Thanks,
Pedro Alves
diff mbox

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b6c3f40..406b561 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@ 
 2017-04-25  Tom Tromey  <tom@tromey.com>
 
+	PR python/16486:
+	* python/py-framefilter.c (py_print_args): Call wrap_hint.
+
+2017-04-25  Tom Tromey  <tom@tromey.com>
+
 	* python/py-framefilter.c (py_print_single_arg): Return
 	EXT_LANG_BT_ERROR from catch.
 
diff --git a/gdb/python/py-framefilter.c b/gdb/python/py-framefilter.c
index 73f2a31..7114030 100644
--- a/gdb/python/py-framefilter.c
+++ b/gdb/python/py-framefilter.c
@@ -864,6 +864,7 @@  py_print_args (PyObject *filter,
 
   TRY
     {
+      out->wrap_hint ("   ");
       annotate_frame_args ();
       if (! out->is_mi_like_p ())
 	out->text (" (");