From patchwork Wed Apr 12 18:06:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 19997 Received: (qmail 101005 invoked by alias); 12 Apr 2017 18:06:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 100344 invoked by uid 89); 12 Apr 2017 18:06:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=essentially X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Apr 2017 18:06:37 +0000 Received: from ESESSHC019.ericsson.se (Unknown_Domain [153.88.183.75]) by (Symantec Mail Security) with SMTP id A1.A4.26215.CAC6EE85; Wed, 12 Apr 2017 20:06:36 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.75) with Microsoft SMTP Server (TLS) id 14.3.339.0; Wed, 12 Apr 2017 20:06:35 +0200 Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=ericsson.com; Received: from elxcz23q12-y4.ca.am.ericsson.se (192.75.88.130) by AM4PR07MB1713.eurprd07.prod.outlook.com (2603:10a6:200:26::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.5; Wed, 12 Apr 2017 18:06:32 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH 1/2] Remove dead code and "current" field from MI thread output doc Date: Wed, 12 Apr 2017 14:06:09 -0400 Message-ID: <20170412180610.2565-1-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: CY4PR19CA0030.namprd19.prod.outlook.com (2603:10b6:903:103::16) To AM4PR07MB1713.eurprd07.prod.outlook.com (2603:10a6:200:26::21) X-MS-Office365-Filtering-Correlation-Id: efdd66a3-5c6f-4686-12dc-08d481cea73a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:AM4PR07MB1713; X-Microsoft-Exchange-Diagnostics: 1; AM4PR07MB1713; 3:wqSZdC233pnC6fIXjH0fIxvQ8oTfb2Yl6ESSiCTvm6HUtZCha48QE14aKOnseEdVc4jxFXITrIt1zFN+NmyCE2KiBH9Zc/opxa0ttikIRRSWNdKSyA2IrA1bgDBjNTPTl/UIKW5rLzlB4F66+4xg5FA490uyfU4KT9Ky0cew5JxftxwpyaIejJju765OIy9nsjAi3UdJVD3/352vtkqGIrjdiabdh/K2WuK5IoPvzv8hpIAOV22KmYLBGftNOzy99GOkrfYgey2swPXYsbT/bnEau2nIfPftoc+l1fJVNf1Re50kZOyeUkZHUlJr+arggNsK8z4fIKaPwwHKIcG5PQ==; 25:nwjxMYD0LGlvtwm1jr7QxUCqreBCuK4/hx5gIS+gqG7voOxMYwWTyrpzBWaKTa4dQoxZEkUb8ZJZvETITamTST/s7NLSOWDsR8xRO+LhCmNgbfzUvWtBwLRHTK5BROFLwh7daSNGJQ8t3x8qBScvuGqx7cbRcu8EndV+Aaps2fBP7hXE7jBUbJhDlR8HE2kpKK3Otq8AXtiGFrxQ9MD2qhJGi7zmOKHmwVpwKxCRABfAkQdl1aWjwBuUnqmZVxxO0L2imywPG5GFJLCE+3jAXYcA/3qPRxPB6JVSs95EGMGl4S9v+D6p9JdBDRqx57cA2ypFZn9pFphC97ClTBCETrhzlEkxAEN/kdPYbg+LwvaBpL25nsKL3Mj0kA4KdxghAsdBmHLMj1gx/V2gceCTgUThL4Ls4rdBYqEYYbZsN0yrJ7nPYGZmXa2lwUnRB46JLUf7Qc6JZg6n2RNA9kWDyhpqIRSZrLA/JQ/jrYHsESQ= X-Microsoft-Exchange-Diagnostics: 1; AM4PR07MB1713; 31:4AK9AMH/C7NwgjdZJqfT9NZu/OJ8IgJSnPt0rDq8koNUkRek52aDxNVjp9Dq/Jv59CI00ZQLryiR2qVf4ISRRzcs0+26iARMcNgerufknLkVACDNtwjno4VXpKx4n6nvCkBPGV5Y5YCNH5/jhbWnwcAIObxO8ZFAKhZd88woaA/vXO8eXkfnj91o3Fd4HturAhnDxuXeHLeClEEWWfXGzYo9BXxDhmsudEwYVhoz1Fg=; 20:GJuVCvjn/JUHS23Y7II+4snAN8uJVtUph5wxfSsfTKVksUu7gRfYvA7mPuihBTuQH2xGEDaXc5VoeM8cTCxd77QsICcXlxroStjgk6BAWCgFFOH439xeFoEKNj2dl0CEBy5cGhOp+ZxGRu+rgCkYfkQZ0u91z+IdSYytlDl4gJQ3//aENQW9uWy9UQPJq9ydC02+9ki7mqhiuSEuHHr1Llgae5d5ZnQ7PjhRnMsSQA80TwJzF8+3fuhVauhBiQsJfIc0+VahonCh6G+uITM3pOzJU3/xFDyz7WPz8d4z67COUu5z//qgsUlzY1npET/N32Cd6J7YPkneLHVog/iIHq6M4wRtSBghnn7l06GSNiFs7efP1aFkQc/ndfguLaevDjBBOK97h4TcD+xLybH403BwbOTogAikBJ2uFnFf+oWoFHGYhXE8lEYvQH3AD/rPqNzn3nNl5qXrWVJQ8ylAGp9fccXjGDmKxUf1zvNY+YzYHboXoI25wK3M2QBxCT5b X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(20161123560025)(20161123555025)(20161123562025)(6072148); SRVR:AM4PR07MB1713; BCL:0; PCL:0; RULEID:; SRVR:AM4PR07MB1713; X-Microsoft-Exchange-Diagnostics: 1; AM4PR07MB1713; 4:ZCqzvZhHepO0bIGijgy81xS4RRLKl35v2kKwLXtbqQTXQLDour6v/JwSbSIxKU2qA5Xo6EsXMmFU38oFrblLCcvoBn3aRw6ccraoCNCJXnGFSy5kK2dKc2tBa2+5pnV3QEPzOOERVRAzQpwiGe92KJlk/MMrcZXzy6jAd/gYWxEV3MhQN/dnGpO32z9Wp6gbDwfvICK7CXRFgI8Ze4RGVHG+TnNHyP6Sx0U3A0Zlu1jaoq9qXLDJFYEc6/B4ALmVd4ndY1GV6zaUaJveg/C6JRS6C1hr6uscyl+vb7Iway7+5uK7HiFkqt8cvZtjbT04Fi3YbNM2XD4ztKlFDeIPzQmWE4bbUsX2NiRvagYQOjGTp4R3tVisoMZuABVaMTdjR57lc4vf4ndKA1jKlVaZ+JhVdJviKUHPltpD0v+FsBIrbHATI3XWBSQqAvQW/ZHjEQJ/b0hLxltS6NLXr26oFYFkMsHOpa/wiYmvWhBCUQ+psmWNl5ymWhJ8nNQs5nLy6wJgK032RdTHej6O/STWNtvKst8TxpXXJAiXQMOkWCa4sPq10NRGSldelsBG2G6E02rL/Zsp4KqhgiLIVYhd4C/qNNraye8TI0DT/sX8Sd2cQs2EugqLFDjSAe8AJY8TMSMLIA06qv06+y/WtS3GmGL3BXsYupm5HAfP5YYRzs49Sw1qH7bAuMukzO9dn281vuv7LssU+u2S8v8gWnUMr85Nmwk6Pb023aucmdnmp34= X-Forefront-PRVS: 027578BB13 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39410400002)(39450400003)(39840400002)(39400400002)(39860400002)(39850400002)(54534003)(5003940100001)(2906002)(50986999)(5660300001)(107886003)(110136004)(7736002)(50466002)(50226002)(38730400002)(189998001)(36756003)(8676002)(81166006)(42186005)(2351001)(6666003)(6916009)(48376002)(33646002)(4326008)(305945005)(1076002)(53936002)(575784001)(86362001)(6512007)(25786009)(6486002)(6506006)(3846002)(6116002)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR07MB1713; H:elxcz23q12-y4.ca.am.ericsson.se; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM4PR07MB1713; 23:kLLmLtkGX8K3dpXLrX/QOkACTRQ64KYweI7MUhd6D?= =?us-ascii?Q?6cvDBJ3VTSLb5jaOPNcYNz7kgdGr8HLSo1/0HFxyPPIEKw7OulIkivPFMpT1?= =?us-ascii?Q?Lpg+pRwPK/D0e3+V6Vcq6qhDpbohhPv1stS9qyoMGVc0F4F7FYEmnKufTbyP?= =?us-ascii?Q?euu03W6kdBOISuYat8zRc9VnBPFzySelNCHu27H5PJZa8jRIFL9TWYCzJmb5?= =?us-ascii?Q?UoNVM6Qf19Ama8Q7B9ibNF7uu6AF01MvrItM0wav7Oaclydp/gBjAVRW/+3N?= =?us-ascii?Q?rRZy5pblEuKQtIXf5yGh7SY8+HfDzu5S3AsNwirP0fnTiJu1nJbBE2aYVGN2?= =?us-ascii?Q?cFGCdhARXPG9CBipLqjAxbNc/n4//rPBOL8z4ufop6txlfT5Ggo6W5kn4Kl3?= =?us-ascii?Q?+91KcF5FSRLf7PyUekP4H/an8nu8YwQbuqwBp9PvRkQJxu0ms5fRopDeQufp?= =?us-ascii?Q?NBKKjNXkEr4sDsqGYWB2lLaKvdTVKxzf558G+aUXs8fLT2T/NxZY7ZvIbeTB?= =?us-ascii?Q?R3nyT+ZR+yKcOjS8jQfD6TBgnTq/QbUmUePTof/ENphbfi85cJfcUcLnRxee?= =?us-ascii?Q?AKSl5EVRCj/5bmMRTMkqaaQBNNgHevlwD8K7MQq+sjg7sHTJ/c5t/EgQTQye?= =?us-ascii?Q?wUnJreHQ31rb/bCsGcXWieuBXjtf7hRvPDVHt5fLe2593PqvQhekG4hQJaVF?= =?us-ascii?Q?qW9kmTVreTFYrUyBaTa4b1gJZqQrbDa2GQ44W48kkDP1WWILxeiMYZJ5P+v3?= =?us-ascii?Q?oStiWoDIPRiMWoXsZO/kEkBOn3ODtY8CzYstA946IhaliZe6gvOK0GSzB6fC?= =?us-ascii?Q?Dr4YEl5Z5MWMj7NdM34Y4td7ZS4l4sYcs2HIC/HzTcxDnSEz5Cf+IyFM1pTt?= =?us-ascii?Q?1FHxRhMKZlrf+owEPnVOAjw3YO91FhwzDd1dHXBBBPAhS3ehNORt6WOc41t6?= =?us-ascii?Q?yH/fdYllFZ2UNujnt+1DkLsbluwJnay8S+IyW58sn9Y0p0KlS3kqePWacCb5?= =?us-ascii?Q?EiFX2G8XDgKMjQ0zHwtBHMM0c3cFHLqVckvpEoWTB/b/43WQwwdNpazh3bT6?= =?us-ascii?Q?Q9x+JxYDnZVmiZDZbUBZIhHopDU?= X-Microsoft-Exchange-Diagnostics: 1; AM4PR07MB1713; 6:6YKH5PvkFml8QNDaimEsJDjhc6Dpf1lJ7MHzIY2PAAl68Uo3Fg6mbBECN96GjEvhNznDZ6tyllRygC1LaRwCo4HJGDEpg3ZpIeBicP92himpKaRQ0Qn9vxuquqjSwLSsz08Kk7tpWpgZKNx+SVP9yFA4hA0qnbCRJus4tG0/Yx1qi50kPuJZ2dTmyBw+0uTS1fsnlN6nsJxFYKFAhnb5hM3TnSU+js7yOyOkfbYdAHRqauxi9CvsnRK/uG/YCiey93Mg072s9+d+YQwI0qAGFjwhalsMx9Uv+5WkCrxeezrzDYSDUx3NC7RG3KwQu1QEjaOsWbVe06GtFOsSFMNzQmppmXIBiY6bQ43MOJIH1RPy2FYzYCXvb+SSEWqyLa8ME4jp3xf4KM8awjEFISueCoQRAH12vsadWh/mJVy0GfzwFQmeT+ECkYRVEfoaQ/34IroPFyPWBqw+V13XeAwH3Q==; 5:huge+Gm9MhY5b+o8o6CMv+Mw5FbJvuFwisZ4E+BYwcw3x3cEQJVbwK+jhYTq2q6i+Z/KHdV0xHlgI55Aq4IBpUB27ylbQT2p4sLtDX0REScZ/Ew6lLuHgUqwX/sppR6M5zUS8g1BwiuuXjaSphf3veKZtMiBv5PZ6PnVsr9qa0g=; 24:9g3Q5SzoEyfZEMU+CQVfYqxWkxxrY0A1g/vNSYR921MRnGUzGMxSh/h8NY+T1VqsxkmLOT62VUdZl2iJ9KEbfhBKRebqlZpD8VgSgfYsQIo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM4PR07MB1713; 7:FmsDSzTfrCvIOlJS2QfTglLkEX0mn6e/4SP5sLAc1aWKHPgCeqzEZd9Md4Unnyolyc2e4jzUsHDJo02XTjpybnBrH8OdOFVmEruDxAlQS6jl9TmqRD/ZBAgke1VWArQxZUg8KKLRgak3EQ8xZDYWBBVHAWZNn5cWitBLEm5YIRZH47DoMLFGKp5miJReSlpmdFghzqHBMn3LCPggVldK5Xf9LoX29ZKjHcAUK4+3vLDGoqZCF4B7WegVEDkIBIs2NPkDTtlaxZT+hZ92c4ledScxv46gL43PHyqFIBGdYj7z8OdBb1HLJrZO3E1uvzurnMr6n8+mU6Aza8UocpGhDg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2017 18:06:32.4591 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR07MB1713 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes The MI documentation says that -thread-info output contains a "current" field in the current thread tuple, with the value "*". Current GDB master does not do this, and I couldn't find any GDB version that did. I suspect that it was never the case. The code that would correspond to this in print_thread_info_1 is essentially dead code. The calls to uiout->text end up in mi_out::do_text, which is empty. This patch removes the documentation bit and the dead code. This "current" field is not necessary, since -thread-info outputs a "current-thread-id" field. gdb/ChangeLog: * thread.c (print_thread_info_1): Remove dead code. gdb/doc/ChangeLog: * gdb.texinfo (GDB/MI Thread Commands): Remove "current" field from -thread-info output. --- gdb/doc/gdb.texinfo | 3 --- gdb/thread.c | 10 +--------- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 300d78eefb..9e872763b2 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -28088,9 +28088,6 @@ The result is a list of threads. The following attributes are defined for a given thread: @table @samp -@item current -This field exists only for the current thread. It has the value @samp{*}. - @item id The global identifier that @value{GDBN} uses to refer to the thread. diff --git a/gdb/thread.c b/gdb/thread.c index abfce71eda..74d0d65e02 100644 --- a/gdb/thread.c +++ b/gdb/thread.c @@ -1283,15 +1283,7 @@ print_thread_info_1 (struct ui_out *uiout, char *requested_threads, chain2 = make_cleanup_ui_out_tuple_begin_end (uiout, NULL); - if (uiout->is_mi_like_p ()) - { - /* Compatibility. */ - if (tp->ptid == current_ptid) - uiout->text ("* "); - else - uiout->text (" "); - } - else + if (!uiout->is_mi_like_p ()) { if (tp->ptid == current_ptid) uiout->field_string ("current", "*");