From patchwork Tue Apr 11 15:01:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 19968 Received: (qmail 130153 invoked by alias); 11 Apr 2017 15:02:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 128911 invoked by uid 89); 11 Apr 2017 15:02:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gproxy3.mail.unifiedlayer.com Received: from gproxy3-pub.mail.unifiedlayer.com (HELO gproxy3.mail.unifiedlayer.com) (69.89.30.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Apr 2017 15:02:14 +0000 Received: from CMOut01 (unknown [10.0.90.82]) by gproxy3.mail.unifiedlayer.com (Postfix) with ESMTP id EA53640736 for ; Tue, 11 Apr 2017 09:01:23 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id 731L1v01Z2f2jeq0131Pk3; Tue, 11 Apr 2017 09:01:23 -0600 X-Authority-Analysis: v=2.2 cv=cpDrqxwi c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=AzvcPWV-tVgA:10 a=zstS-IiYAAAA:8 a=cB27HPSkQZKSPL9AxukA:9 a=4G6NA9xxw8l3yy4pmD5M:22 Received: from 75-166-65-226.hlrn.qwest.net ([75.166.65.226]:50042 helo=bapiya.Home) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cxxIG-0007Ml-FW; Tue, 11 Apr 2017 09:01:20 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA v2 07/17] Fix up wchar_iterator comment Date: Tue, 11 Apr 2017 09:01:02 -0600 Message-Id: <20170411150112.23207-8-tom@tromey.com> In-Reply-To: <20170411150112.23207-1-tom@tromey.com> References: <20170411150112.23207-1-tom@tromey.com> X-BWhitelist: no X-Exim-ID: 1cxxIG-0007Ml-FW X-Source-Sender: 75-166-65-226.hlrn.qwest.net (bapiya.Home) [75.166.65.226]:50042 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== This fixes up a comment in charset.h that has been obsolete for a while. gdb/ChangeLog 2017-04-11 Tom Tromey * charset.h (wchar_iterator): Fix comment. --- gdb/ChangeLog | 4 ++++ gdb/charset.h | 6 ++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index c50eaa8..6f16318 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2017-04-11 Tom Tromey + * charset.h (wchar_iterator): Fix comment. + +2017-04-11 Tom Tromey + * charset.c (iconv_wrapper): New class. (cleanup_iconv): Remove. (convert_between_encodings): Use it. diff --git a/gdb/charset.h b/gdb/charset.h index 9e8ca4a..51180e3 100644 --- a/gdb/charset.h +++ b/gdb/charset.h @@ -93,10 +93,8 @@ class wchar_iterator buffer. CHARSET is the name of the character set in which INPUT is encoded. WIDTH is the number of bytes in a base character of CHARSET. - - This function either returns a new character set iterator, or calls - error. The result can be freed using a cleanup; see - make_cleanup_wchar_iterator. */ + + This constructor can throw on error. */ wchar_iterator (const gdb_byte *input, size_t bytes, const char *charset, size_t width);