From patchwork Tue Apr 4 18:32:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 19843 Received: (qmail 83953 invoked by alias); 4 Apr 2017 18:32:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 82886 invoked by uid 89); 4 Apr 2017 18:32:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Apr 2017 18:32:55 +0000 Received: from ESESSHC003.ericsson.se (Unknown_Domain [153.88.183.27]) by (Symantec Mail Security) with SMTP id EC.18.13281.6D6E3E85; Tue, 4 Apr 2017 20:32:54 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.27) with Microsoft SMTP Server (TLS) id 14.3.339.0; Tue, 4 Apr 2017 20:32:52 +0200 Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=ericsson.com; Received: from elxcz23q12-y4.ca.am.ericsson.se (192.75.88.130) by VI1PR07MB1728.eurprd07.prod.outlook.com (10.166.143.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.8; Tue, 4 Apr 2017 18:32:50 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH 1/2] ptid_{lwp,tid}_p: Remove unnecessary checks Date: Tue, 4 Apr 2017 14:32:34 -0400 Message-ID: <20170404183235.10589-1-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: BN6PR03CA0031.namprd03.prod.outlook.com (10.175.124.17) To VI1PR07MB1728.eurprd07.prod.outlook.com (10.166.143.24) X-MS-Office365-Filtering-Correlation-Id: 9f9433a4-be93-46b5-d6c7-08d47b890044 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:VI1PR07MB1728; X-Microsoft-Exchange-Diagnostics: 1; VI1PR07MB1728; 3:5+LYYLJmMn6WmAsIxGyviB5JOTqIyRhnmo4GLfxmk6oMsv5vYX+77vDHvUin21yWTwI7HXL8X8zgxhMYFw3u7Gf1KKlySIi85CPzofeQMFo0ltFIHLuOMobModWWQU0T5tBO/J+aLGZrVgM+367JcBAFBkR+A9DveE5p4q9omyT+8QU932QNDy7lnuKs2Vsh+dM8ti+fOCUQa8x88R2Voxeq7B/SV7MbT8q1v/TfOUVgktBC/UfrIbY1hDzxxZACFAfRt//zXjlAZnydX0qeERRJLg78cOBEIVdBGJmxFdm9EjbN+N6GxRLM+8XF55IsRfGg7MnUxDcjZY2AkeCk0A==; 25:SejH8tNoRIUCdwEmDOvAzeProBdebIXT5JzZrLyExn2lbVa9YSHLx9i2VQDAaqJyBgCX+TVdeAk/yfCJWFPqBbhnSegV3Pp62b5+TZFFq6H31H9xab8Z6p67FYm3Y32C+8w7fufPpzI5DogXVQ+9gaZvggxYwFpPHgBRdzjhuQv57oq7Vv8J/Qk4qiKjNxSvS8Akc7uQZxnH/3BhBtMRN8eS3gdb6fVzbZTP499ISpEHPsUksnILqvVAS0X7GSzXhcP0OM3kxRvJJhb19UV8ee3F8bBzz/tQ7SWeQXYBtxVVvOKygktDK0s+RpWrZIW7AaXpZmHmZSTxUFX2NK1m0QBVopyS6rB53NChxDh9BpMGBQkNfa6zhgMlT5HKFKEMDMx0fbNLiYvjvO/OYdYZW25isElyS0LO09l2maec+VCzEQOO8KKmqyZPKD4sM0ADpIVTCsO7i5/odQ+njWo80w== X-Microsoft-Exchange-Diagnostics: 1; VI1PR07MB1728; 31:JIntfwvv+BirqIlJdZpRf6Bxu35z8TioCfFAdcVEucKOBTtUog6cVpDtS/2o8SU6hxtYtvEPnq84FaskLHybOQihi+b+aL9FrfjS4OsM5tA65HwgkTia2lMCNYveAbbNJoisChDDQBCFtubN4KpD1RJ4M/big8LGUXyW/XJ+QhDsLCofy3LovJLfPrOZpKT2Lpi6CmkJDvNka+KbsnSZjGTOIcF9l3iEEo6WsplJBI4bjKh0zTjJ9MMHDHnCEauY; 20:HYtHYeTg6PGsD8GiUReBFy+jMxWCJQqAQo4dB6mWNaUDteoDQK/Sn2gr8Xfg5OLcLmVjaUUYW1qpGwBkDSTYEEMl1lOXTZtFFANkmWNm5r/SqlO+hn4F9sggGu8hq7MV/CJigXSFCMiFrIqI5AkgKCX5T/15J0rdYOPJiQr+xF1RIgI5Clc/521teUlUbwC5za/7DcR74e8uD/IFO8dAhRpm12SKKaq8Qd+o6ZY/NSScaO4QnfyU+norR8R3XdNeTLvxbNMtV+HKQbQZnMBN+P2szGDoU8c67JRl/HNJUlcW5xE4919PNyEwre03+wWqH/Abh9/q5ZTicObaa1tltjqyFRksSF70H54BqkVbva6/TR3QztVgN/FqootDiaBAJsXPHbe2Sx7AhEPn0gP6iTLWoCyuPoc35PvYmWk67Jwczi6bb1wPRlFLLyuCvO6UO2xPiRT9ZSBh4UkPkAKlGUaAJtkJ0gvbMtcQsji8GY/DzN4a8D6iGt3Ocl1zwAbS X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123555025)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(20161123564025)(6072148); SRVR:VI1PR07MB1728; BCL:0; PCL:0; RULEID:; SRVR:VI1PR07MB1728; X-Microsoft-Exchange-Diagnostics: 1; VI1PR07MB1728; 4:P2yTxbmIL7Z35O2t4oO7jHKXd28tpQGE8p7wdc4EMZXd47JUtNTsp2H0UjrpRKHr0WPAmSkJzI08LiFNGxcD2bsjbrvN3/g48qqRNi9x4yERpSzU7yPrC4JASB11oOC0AGjeCt6ZqSt6dpXH5UmEXcdzipZwTzfuNreZSoEyy0E8VxTJt+vBxbGQVW4Ob0fpsxB+x3KjgZdj/OFGjxPenegTiuVdxS4KOoYM+at8GEA+M8Uzy+ZimQBbrAuW6zvJyV37hV9jJVNQQ7XEhvt31/gUh+mw4R5GRrp//6SMuD5e0fu/xvk9LHQ3LcVEoazJuWoOMpTxXeHq5tfg5i0eXTEayjwJjU+6tVDLdME0QN6j3Je8ittRnRhsRcOwtSTUt1V6wvtMMKL6Vh6xELTz4MOyiS6SzSAnjWAewYRE8VgSYm4pFjFJhx3szJdLQD+sEQD2oJ5JCIP/Gc63RaESpyJas6g53cIpznk2FqFLO7DXUVtZbmFGtLvs257Y5F+8X4bAopRZ89g4RDpR2aWpCuCusQxoUuZzZLYMWChdGuW+sdZk0jYYnpKigqK/Elojx57UEpAnFAO8A5wW2lmluIejQtRqqoWrkecoQwdoverpwo6k3BTNB1BzDlSzsikcAaTSDg5XNyPIpXMyzbhi5wTe62R60ObLm3etZ/oL0imrLEcpwH5h5Kf40KeR2z4pIIyJqr1FybGNLRBJUJ894A== X-Forefront-PRVS: 0267E514F9 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39860400002)(39450400003)(39840400002)(39850400002)(39410400002)(39400400002)(54534003)(33646002)(36756003)(5003940100001)(2351001)(66066001)(6486002)(4326008)(107886003)(38730400002)(110136004)(42186005)(86362001)(50466002)(6116002)(575784001)(6506006)(6666003)(2906002)(3846002)(48376002)(5660300001)(6512007)(53936002)(47776003)(6916009)(1076002)(50986999)(8676002)(81166006)(25786009)(189998001)(50226002)(305945005)(7736002)(142933001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR07MB1728; H:elxcz23q12-y4.ca.am.ericsson.se; FPR:; SPF:None; MLV:nov; PTR:InfoNoRecords; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR07MB1728; 23:pYvd/aG+fvdL/t7jNOJPoy0w825uUFYBRIvo6/JD5?= =?us-ascii?Q?ETD3CmWOLbsYyZUbPst5n508DzsNn6vLigGhTXPkVrUUZcPh89RJtPc0/49s?= =?us-ascii?Q?XIeAOuM7hNb6m2o8rtLsM/enwGciNfGX/IuU4zPxkocmJ/kXxI1Ru/XS+pDu?= =?us-ascii?Q?QvT6x28UFeHoYXe4+pphSo2HBe81quQ6c4UORTth8uWdPwnDMGzP6poAap4k?= =?us-ascii?Q?14/ll9u+1ElJ5jFBMi7ftEN5bE3crfGwBOCy7oz7S8wgITchlh/R+YQEtr7c?= =?us-ascii?Q?SORZXlYnedTPZSRQgPeGnTSafQBBBMMpCo3YypH8tCfepODO/t3xZXB9v1fu?= =?us-ascii?Q?eoyXdR/KiW4gMreS1CXxQBLc8Onc9ub8MPE2qK94il6kq6xDMM6hlG5B+oF4?= =?us-ascii?Q?YziREZAeAx9g1+ZaD5CEgnTZAa4Hny+AQn3uG6AhoCF7Sia3JDl0G7LZTfa5?= =?us-ascii?Q?NUn0PPnKEJRXeGsXs39b6yMH6xKHo89p722r2DPuuQcoRIx7xWkBzLLybew1?= =?us-ascii?Q?Igb3DnLKu2HP8Z986iOHnouwTNC7XEOYamOu7i8eQk2NncwZnywg78FUYANx?= =?us-ascii?Q?4N+3han1pxDhW0jfqeKFGQ1bg/S/T/IOodBKRf8hbVN6BJw5MTYobgLeDwWX?= =?us-ascii?Q?VCQvkEZgdKs1bRTbYsW2lxnEooA01KxcXHWAHHwHveTaDj/Wa3muRNIaRZlS?= =?us-ascii?Q?9VmTWbpRnPodlJte6Aw4b7ooneqej7ouBodmSjENs4CTEnnFE9AfBxyQHpsI?= =?us-ascii?Q?u0KXW1yZVEwPwes62R1LDGIRP5vUZjIkmvfc33BeibqDdfp8DK8wTcu4vckY?= =?us-ascii?Q?NkhmIquu4J6aEZVGRcwQi6Aw/O2qVY+BE09J2mr5xH5k8KZVqa9h0OMfbLF6?= =?us-ascii?Q?tb3FtSPgKBoBqA86KKQi1hvb1XqV2yvR/JXWlQMt5IZ4wJux7nyRkpuI2o9g?= =?us-ascii?Q?pdnbnrtThYU4BM8JyM+JQPh0D4UTvUPuJm3TiTwF0N+b8KaHRN0RgCTJj/rH?= =?us-ascii?Q?5dLyYolpQSsf0QFHP3OQgejP20ZkNq4rR0wZ3Odtn3EMHsx403yWDMqhFZl5?= =?us-ascii?Q?4s3zbE5sw69VtT07wXvR9+oydP+YH+yLbTHkcm9yPdh2oEK9MZqM0hgkwQKJ?= =?us-ascii?Q?3kmdIq4BJY=3D?= X-Microsoft-Exchange-Diagnostics: 1; VI1PR07MB1728; 6:c3mD6VYIZ+MOpW6zXKqGQQ00b/UIct/i3VMfF1KMCDi+RczD8AjxV+7dVaYVBJIffsAkQkzTxSlmb3GajzFEnHBbmTcbu5Fx5B+2UZiQG+eaMw2zoAf6zUDBtdbZRDC+AtYOFQSCS+K16aBJlKqiOR2OxEfHuHpdbiOpDgEodqnd/48pjFSwN8UbengZA4g/3iVUEFwsGoXTB4l+kFt8uC2J888WrUGUNxqWuSG4axBberkZ5mwzBei5kPDt2ER7MJrnZnS8gXfLhKqXGOVvYHSxsxM7EwsHPYVDGIaKvzF32kx+NYJ1NvF0dlEP4QAYnaswZ+MaHKCujly3OnKtEsTQsB0GH9mvj/fe+x0Aw8vaQrbvU7lIwt4AvTfzQgvFft4o5UJawYxJLu5RIsG2GVSOifo14M3PE/0tmudhB12aIcE1L/SjefOEgCYVJG1WNbg9aCbJ9b6OPj9G94VygA==; 5:WkLvPXMjh5+S7brUAY8rkguGePAor+LTdEjCpBQy5oA4Iae+9l3t/9thW9oQoPJDw6Mu3EDks0baxSuevblBKNCXRa86CNBvB0S3iEchBtkMNfVvA8MUiAv+rnyoGI//bjY0dVhxP4u0TTfJyCwVFQ==; 24:T0bVDbIVohSuPRzfI4YuyDWtu2dZsQaOZFw/8nxy3fZlkOc8nQ5ddIFXnXoWkxHfqZGMnJ8jQgwju/+cl0WNBqTO6LUF8AVpCmhe7YcMU0o= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR07MB1728; 7:0xxao3a8o9aTZyoJIIPrZVMTgjaWwrzSFPMalX4knywpOkAVFFtCSNnD4g+sk/jPrX1mUJXjWYbv/KEN2o6yDKT9a4etHj5h1yUU9V3ju0OZUtkDcgKClPAWMI8Eu7Aa+eLpHB78a44ct0AvONsL0hKng97Sl8YtBT4ICKfhIUXQ4WoCVlGdGlXaxJHsdfgFv1JUH9+Q+SjN82ofawZkw7PaeDpY7LEB1bAUIkjAGA//ai2/axk9FH/FnQHa7uvBAVWhlzA4jhPMU/bOZnmIP+pt9HkH3EEJMbKgdvMn9HLtkWHzHpD4J/Rlumd4EJ3I9OwrgUZJnJtHFdU1hn6ISg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2017 18:32:50.6015 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB1728 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes The calls to ptid_equal in ptid_lwp_p and ptid_tid_p that compare the argument to minus_one_ptid and null_ptid are not necessary. The calls in question are: if (ptid_equal (minus_one_ptid, ptid) || ptid_equal (null_ptid, ptid)) return 0; minus_one_ptid is { .pid = -1, .lwp = 0, .tid = 0 } null_ptid is { .pid = 0, .lwp = 0, .tid = 0 } If the ptid argument is either of them, the statements return (ptid_get_lwp (ptid) != 0); and return (ptid_get_tid (ptid) != 0); will yield the same result (0/false). gdb/ChangeLog: * common/ptid.c (ptid_lwp_p, ptid_tid_p): Remove comparison with minus_one_ptid and null_ptid. --- gdb/common/ptid.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/gdb/common/ptid.c b/gdb/common/ptid.c index 05c0db17dd..b56971b9af 100644 --- a/gdb/common/ptid.c +++ b/gdb/common/ptid.c @@ -97,10 +97,6 @@ ptid_is_pid (ptid_t ptid) int ptid_lwp_p (ptid_t ptid) { - if (ptid_equal (minus_one_ptid, ptid) - || ptid_equal (null_ptid, ptid)) - return 0; - return (ptid_get_lwp (ptid) != 0); } @@ -109,10 +105,6 @@ ptid_lwp_p (ptid_t ptid) int ptid_tid_p (ptid_t ptid) { - if (ptid_equal (minus_one_ptid, ptid) - || ptid_equal (null_ptid, ptid)) - return 0; - return (ptid_get_tid (ptid) != 0); }