From patchwork Fri Mar 3 18:06:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 19427 Received: (qmail 3163 invoked by alias); 3 Mar 2017 18:06:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 3145 invoked by uid 89); 3 Mar 2017 18:06:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-22.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, UNWANTED_LANGUAGE_BODY autolearn=ham version=3.3.2 spammy=agent X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Mar 2017 18:06:49 +0000 Received: from ESESSHC002.ericsson.se (Unknown_Domain [153.88.183.24]) by (Symantec Mail Security) with SMTP id 66.21.31774.6B0B9B85; Fri, 3 Mar 2017 19:06:47 +0100 (CET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.24) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 3 Mar 2017 19:06:46 +0100 Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=ericsson.com; Received: from elxcz23q12-y4.ca.am.ericsson.se (192.75.88.130) by VI1PR07MB1726.eurprd07.prod.outlook.com (10.166.143.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.961.8; Fri, 3 Mar 2017 18:06:44 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH obv] Use range-based for loop in remote_add_target_side_commands Date: Fri, 3 Mar 2017 13:06:29 -0500 Message-ID: <20170303180629.25785-1-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: CY4PR13CA0010.namprd13.prod.outlook.com (10.168.161.148) To VI1PR07MB1726.eurprd07.prod.outlook.com (10.166.143.22) X-MS-Office365-Filtering-Correlation-Id: 5407cfd0-07a8-4336-d677-08d462600dc5 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:VI1PR07MB1726; X-Microsoft-Exchange-Diagnostics: 1; VI1PR07MB1726; 3:0BXCd7A39qQybQ1s/sw/nnUbY2ViRag5lB9kCduwL1CKKiL2zPQlAjxb+RlCd/DhNGLT5a0KnPfWQaJYOlPobQgxC0KHliUJXg/z4eFnGQiogp1MKks+TlANmRPDbW0PViBq2MEf3E1HvvocLMTglkp+dvRC+JgZVN8Q7NZEBt9Q4zdlOtIkwT4fn2omFyrPqCbnkHXSB6yWYH7QTyzbbEyRZL8MxHMIdmJ28WkkuJaPMJEJC2N/9A/hw/3s9PIJcKE300K3Ksbemv/+kSjNAw==; 25:k7WO9JYT82zV0F2XBIiM0n+SF1LtJhuM2P4J9vnoUh3O+4f51PztMMACXmWtM0+1Wiw12nuzicqsx/PvUgw5OmS/X1QRWeg2xdwcjVmJSOO3BFhtm9Gqlbd4iZeGjyA1ojRDS3usJHACtflxyfGW/+VOmjkNLbhs4lblLxmaWDgyb9jxU8enKmI8bDA3cRBzqqe5yJzeQP+B7EueCXzs2ohFqyEo03ZD6twPMAjJhx2OdUjJxmWoaeO18yh2cVeHiI9Y712EMQoZGSRSI9s9STK0eMR/RVFIUIVlkh1ygvK+fpyKgCZmdv7lwFqtQUqGQrSp5YZELl81VwF3KnVxrOXlmrVmSaddCfaqVMWuY4Ksg7TAsCRFv/2kfPF3ftfjlB9JoxkZydhjJNC//u59rVREBf0HJUs4cTIUDZ34rSWzF/7kq9mDAMU4tEOnnBjLTQsC2sfLy9LSUlkoaOPkng== X-Microsoft-Exchange-Diagnostics: 1; VI1PR07MB1726; 31:p7xprNDrIxk3Nq1O0LutfujhcQHtlNAfHZAc06UHiTnJPHg50Cza+mYjjqXI4rfJBXrggBzt6ZKuWKSAYeGBKBIfc8xZAulFUZrKnCObvAt5dZ1tld2nuMdlqYUDunNZkiFy3hStfaDF8+oCj4peOQKJXyKwGQLgF9kNKz/zMo3JebhHuGsJELlghwDkK7Z49Wsl/CBcDhr+JY6bSEoDOlz3od5z7rtFDejH78/ZyPs=; 20:m9pQYBQ+/RnwTPJ3mrpH/KU6f3uYixZJIO2afqhWOJ4OZUwd/eIYsAFc65zMIEE7qKeh7IGQF4tiJ8t5oUxZFCoRFfPZ9/CT4wETdQ5NleBouu6cO2JMwlblKkfpFWubS6DGGGmt8apH21u9iXz+C/165wn5oUTD3VqXtIP3k0i0rhwhIkwnbVKymrEOJxsFnmBbYYVAtOcx3yEc7EU4OKN7fv4IxbX7k7DZmzhqKcauw5Bp1DFYE+UIVGvuO5ozsDjop28AELuTcq2oCgMFLfFrpBdxvqjXlKBIMUMMA7RHkjs/30YIn/kV8d07pajxBHWPVSZwx4upbattKh9NzhaZkNreo+AztuHGoXLvHo7/wsaGOan+RUE/FXnICnCWf99Tt5/BEWLWyUS0C+U4ReXmeDz++IETECtKr/MqeFfIEV37uCSg3jhtTj9gWs4HefaiDbW2pjrt482PFW+5q3i/CGzWcPFMgzzOeyTI0u7Mi5ihlhEoN9CrRFUNLX0u X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123564025)(20161123555025)(20161123560025)(20161123562025)(20161123558025)(6072148); SRVR:VI1PR07MB1726; BCL:0; PCL:0; RULEID:; SRVR:VI1PR07MB1726; X-Microsoft-Exchange-Diagnostics: 1; VI1PR07MB1726; 4:je5DzpJCtoj0xJIF6lf2KUZywjR1G12PCfG6hIpGKkLbMvZHTqZumE0BkGKUlBuRakcFvYECSMHByk5PqAaz/FmdNrNACV588YAFYDZoLNGzn6OaFmEaoEWPrRN6AE8bDJaMbrV4GfUipkLsk+BcCudkl1VzeW0gIehl7SUWoXvYorAkqV1oqUTahdk+jOq8CMqfj4sZ13BP6P2+yU5vuwDAOO75SWAM0jkyTFvMKPIl2O5K7uLmDc/HWJFR1F7+j3/o/nXyPpDkrOOx1n10mCH2P66pKAki6R7bd4ex+ZTfeKtg9VP06SgqO8cIUos2gLnVejP5TBKWz5O2E1xkzwnC0OsHt6+gysd3IdG/S3c1RtjrlhzlaPWGfjGG/BlnblJh3iuHbn0a6pfll3UK8k8BwtEb+8eKtxTRun66IFTBF89bYZTfhOZQovy3gyMm2OB6/M5aHYIlmAVf0uV2CjrhLXi1dO5j2MyH/jqQm9nnav40YGKA0AnrxnazDEIpi4AlCZd1HuposVj2SKRfeb5gqDkjBE9pCTY2fQKsbkHqHmC4hT7FuEhRuAL2s/jN54WxjJjQnYqpvy4VBFxNwHv61Avosf8h4b4W7HBKWYfeETWUIkEam+fwJiusxnLj/lhNXWkthl/Uex4MuRi64Q== X-Forefront-PRVS: 0235CBE7D0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(69234005)(377424004)(54534003)(4326008)(33646002)(38730400002)(110136004)(53936002)(3846002)(189998001)(81166006)(8676002)(2351001)(42186005)(107886003)(50226002)(50986999)(92566002)(50466002)(86362001)(48376002)(47776003)(2906002)(66066001)(6116002)(7736002)(36756003)(305945005)(5003940100001)(450100001)(6512007)(6506006)(25786008)(1076002)(6486002)(5660300001)(6666003)(6916009); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR07MB1726; H:elxcz23q12-y4.ca.am.ericsson.se; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR07MB1726; 23:17z7PPOLqefcNXyB03u4ftJRYiyt7PHrkW9Uqv276?= =?us-ascii?Q?5kFE8R8vdDaAL9uSHG1KYg+Intb/v56IGbcnZCJkvPUiHd3WyyCLqfwXx4xT?= =?us-ascii?Q?GczGBiEZiFYnYHQmAIsbm/5Msfc5xDo1oMeGYcHwa0B6HXIhW3V6cD27m1UD?= =?us-ascii?Q?azjiCJAV2+yu1DRSqLAyrwMjDDzh+rPGF+LAHIhGmLtNKeJqUXl0fPrAFyih?= =?us-ascii?Q?Xvs0l00dVEMJAsFqMdky/hyagNNNWy4M3QD0cgejtZAAvIDBKxDLgwA81B3r?= =?us-ascii?Q?1wqp4zKLCCBfHuhoRUqM8k2qoBKhGV4JkoVYWQs9T07teE7zlab7icZRd97o?= =?us-ascii?Q?mnSAVBPpAzukHQpXmpWt1MVSzWSozPVwHqFIv9IbisD2b4eHhS/Tq15mg41j?= =?us-ascii?Q?vd+UOEL2t9xyRebypbOZE0WQEq86wDJMxPUcKiPFQ4pdRRoYAaQfyxfzsqFa?= =?us-ascii?Q?0Zr+tlZi4Kwnbqb9o+z46H7RrTEPku/63aX+Onpqgcl91P7Ycb23q3Qolu86?= =?us-ascii?Q?kH2qsbad4vCVeD5nPQ+HLxOzwKaKB7LF5YsknnJvnJvpGY7VJvvUggEu/V9F?= =?us-ascii?Q?cn35tWOCh3mLL1W3uYZei3wvQrut8v6IUqgkAV7MTwReMC00Ppo27ll0LUR2?= =?us-ascii?Q?Rsk0O+ruhiJLKOOHmHzoXNeVUBcqDVfYnf2CvTPqJt0N9hv7WWxsF5BJRkHV?= =?us-ascii?Q?DmDeJU+rEbVP2Lz0MoHJP+aOBIIub1sXzqz4j5nQ1HMMggEy5Rn/VdT3Dub2?= =?us-ascii?Q?r0l5slshVDyyhMFV+qJV2zKHZqT6oY/MFzu0qzOr7Jrts2qS7AKWJcTkP9Tl?= =?us-ascii?Q?9vodEt8IYIwUl445OU+7gVJyFXQlP+GjR81UQCYYxyQbM+UKrq1A7RneRgzL?= =?us-ascii?Q?KweHL+F4jH+LVh+TuZuYuVVUWIeQio7zE5TyklF0YNklqkbT2zJ/EsAD+WDd?= =?us-ascii?Q?+hQ5CDZ8s3A2D/FnAtnNWceaemA90So93/WtVLI8uhH6FdtSh/YSNLYq8bPj?= =?us-ascii?Q?N2mvpMmnrgKmolPiuQ+53UewiPIzAYlH15SpIpDPuh7jA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; VI1PR07MB1726; 6:MHk6cqbJzpHc4eWwbZPaVR5dA1P+fKJKnw1XsU1xOkfQyayojPAkkRZO3rYk+iQ7ZAlzPAB3iYGxa0PSGy4Ey6Lqof3m12ttw0quVltagT489p+vzFioSIX4yxsyvE75AbfLeDsCSv6E3hgRGGxuA2Id7wzTO0rKGoGZhxMgTw2hsiKNTAhVnNGA6OSc4Y/n13b8ZUlzQuQ122vLEl5QgJZ3xrTnIPGZGz8zVkFnNiVpTl9+lzmRUCVqPe3fqKRpHRE0ND6fX1eIxmwF3hWuE6UPTeibMP3tXhHo41TcptzevGqwbevO+XdGvMHLeDaJfe5F8yWR11ZpCqNZ259/UlwSV2orHimJXumLCFnlX+eDCamMhbK4drTA7A5OfkHa8TgDIC2giAEAj5Ge+AYl9Q==; 5:JBZE/pdj56Qt5OGMpctC4jAFWtwqvo1hIY4w+XwG6GXjfIti0DKzTKZPBf8R59wPcDYGdqsO2V/zJo/bMaUEHpFcPZ2ItfOwtPa7SsNeabPiPB/YLUloW3yloR0M/Jq41UpV2M33afc7rbehjisiCw==; 24:yxG39Ee3T0zDNQF+5f6408a7l2ka2P+jnUxz4ZwqH0Ubq3IYRda+ugKGgXMqgv3/TLAPLO/b7IIOWk5bN96HMP4BVoYcmCn/x5TiWlCQk78= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR07MB1726; 7:pTGREJfHDB0ZYsnsBRT5lSy67+OGGkGsWWXf4/15BwbPPGFUd8Qm28mhAxFzhcNaWOF1UN5p8M/YuV3McvS/PQRHBwp51Ghzx5iDLFoThKp54ASA7uM/7wruxUakv2fOoyg4qVKhI6c5hp4ssKHGpIgbc7yROaBMUMtcs7v1NDwtSt0+N74vsYPPFZmIFZef1ICAJvFLkP/CwC2y5fooMlx56KoKv0Yyph/M9tyRjZci/wcedHpCrq8Fg85sI75wLI4L8vwxeo+XVJMvnhopwZmUEZ5KmwIgR2QfHhka4feR/dzPOz9zq4GJdy8J1T1RElYeAJkslCe3IkuUB8MEng== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2017 18:06:44.5877 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB1726 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes FYI, I just pushed this as obvious. gdb/ChangeLog: * remote.c (remote_add_target_side_commands): Use range-based for loop. --- gdb/ChangeLog | 5 +++++ gdb/remote.c | 4 +--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 368b24c93e..ccca5bfbe3 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-03-03 Simon Marchi + + * remote.c (remote_add_target_side_commands): Use range-based + for loop. + 2017-03-03 Yao Qi PR gdb/21165 diff --git a/gdb/remote.c b/gdb/remote.c index 5da8319823..2f34c4c300 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -9690,10 +9690,8 @@ remote_add_target_side_commands (struct gdbarch *gdbarch, /* Concatenate all the agent expressions that are commands into the cmds parameter. */ - for (int ix = 0; ix < bp_tgt->tcommands.size (); ix++) + for (agent_expr *aexpr : bp_tgt->tcommands) { - struct agent_expr *aexpr = bp_tgt->tcommands[ix]; - sprintf (buf, "X%x,", aexpr->len); buf += strlen (buf); for (int i = 0; i < aexpr->len; ++i)