From patchwork Tue Feb 21 23:15:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kratochvil X-Patchwork-Id: 19324 Received: (qmail 10597 invoked by alias); 21 Feb 2017 23:15:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 10560 invoked by uid 89); 21 Feb 2017 23:15:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1411 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Feb 2017 23:15:34 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 441B33D941 for ; Tue, 21 Feb 2017 23:15:34 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-221.ams2.redhat.com [10.36.116.221]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1LNFUqn017923 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 21 Feb 2017 18:15:33 -0500 Date: Wed, 22 Feb 2017 00:15:29 +0100 From: Jan Kratochvil To: gdb-patches@sourceware.org Cc: Pedro Alves , Keith Seitz Subject: [commit] Fix a regression by: Code cleanup: Split dwarf2_ranges_read to a callback Message-ID: <20170221231529.GA32665@host1.jankratochvil.net> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes On some Fedora 23 systems an internal error has been printed. gdb/ChangeLog 2017-02-21 Jan Kratochvil * dwarf2read.c (dwarf2_record_block_ranges): Add forgotten BASEADDR. --- gdb/ChangeLog | 4 ++++ gdb/dwarf2read.c | 2 ++ 2 files changed, 6 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 1e0e50e..3ac5170 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2017-02-21 Jan Kratochvil + + * dwarf2read.c (dwarf2_record_block_ranges): Add forgotten BASEADDR. + 2017-02-21 Simon Marchi * common/enum-flags.h (enum_flags::enum_flags): Initialize diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index 8a6e1f3..9654fa5 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -12577,6 +12577,8 @@ dwarf2_record_block_ranges (struct die_info *die, struct block *block, dwarf2_ranges_process (offset, cu, [&] (CORE_ADDR start, CORE_ADDR end) { + start += baseaddr; + end += baseaddr; start = gdbarch_adjust_dwarf2_addr (gdbarch, start); end = gdbarch_adjust_dwarf2_addr (gdbarch, end); record_block_range (block, start, end - 1);