From patchwork Thu Feb 2 03:56:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 19089 Received: (qmail 69149 invoked by alias); 2 Feb 2017 03:56:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 68961 invoked by uid 89); 2 Feb 2017 03:56:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.5 required=5.0 tests=AWL, BAYES_50, RCVD_IN_DNSWL_NONE, SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=D*polymtl.ca, Hx-spam-relays-external:sk:cable-1, H*RU:sk:cable-1, H*r:sk:cable-1 X-HELO: barracuda.ebox.ca Received: from barracuda.ebox.ca (HELO barracuda.ebox.ca) (96.127.255.19) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 Feb 2017 03:56:05 +0000 X-ASG-Debug-ID: 1486007763-0c856e65d41415db0001-fS2M51 Received: from smtp.electronicbox.net (smtp.electronicbox.net [96.127.255.82]) by barracuda.ebox.ca with ESMTP id 3V4NU0m6t0qlifMA (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 01 Feb 2017 22:56:03 -0500 (EST) X-Barracuda-Envelope-From: simon.marchi@polymtl.ca X-Barracuda-RBL-Trusted-Forwarder: 96.127.255.82 Received: from simark.lan (cable-11.246.173-162.electronicbox.net [173.246.11.162]) by smtp.electronicbox.net (Postfix) with ESMTP id E7782440E7C; Wed, 1 Feb 2017 22:56:02 -0500 (EST) From: Simon Marchi X-Barracuda-Effective-Source-IP: cable-11.246.173-162.electronicbox.net[173.246.11.162] X-Barracuda-Apparent-Source-IP: 173.246.11.162 X-Barracuda-RBL-IP: 173.246.11.162 To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH obv] Remove unused file_string parameter in gdb_disassembly Date: Wed, 1 Feb 2017 22:56:01 -0500 X-ASG-Orig-Subj: [PATCH obv] Remove unused file_string parameter in gdb_disassembly Message-Id: <20170202035601.9073-1-simon.marchi@polymtl.ca> X-Barracuda-Connect: smtp.electronicbox.net[96.127.255.82] X-Barracuda-Start-Time: 1486007763 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://96.127.255.19:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 3427 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.50 X-Barracuda-Spam-Status: No, SCORE=0.50 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=8.0 tests=BSF_RULE7568M, BSF_SC0_MISMATCH_TO X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.36266 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 BSF_SC0_MISMATCH_TO Envelope rcpt doesn't match header 0.50 BSF_RULE7568M Custom Rule 7568M X-IsSubscribed: yes FYI, I have just pushed this as obvious. The file_string parameter was added in 8f0eea0 (sorry, no title back then) and has never actually been used. gdb/ChangeLog: * disasm.h (gdb_disassembly): Remove file_string parameter. * disasm.c (gdb_disassembly): Likewise. * cli/cli-cmds.c (print_disassembly): Adapt. * mi/mi-cmd-disas.c (mi_cmd_disassemble): Likewise. * stack.c (do_gdb_disassembly): Likewise. --- gdb/ChangeLog | 8 ++++++++ gdb/cli/cli-cmds.c | 2 +- gdb/disasm.c | 2 +- gdb/disasm.h | 2 +- gdb/mi/mi-cmd-disas.c | 1 - gdb/stack.c | 2 +- 6 files changed, 12 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 8638ebabc3..72d33e34f4 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,11 @@ +2017-02-01 Simon Marchi + + * disasm.h (gdb_disassembly): Remove file_string parameter. + * disasm.c (gdb_disassembly): Likewise. + * cli/cli-cmds.c (print_disassembly): Adapt. + * mi/mi-cmd-disas.c (mi_cmd_disassemble): Likewise. + * stack.c (do_gdb_disassembly): Likewise. + 2017-02-01 Andreas Arnez * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): For diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c index 119f2202ce..b5c9d0ba78 100644 --- a/gdb/cli/cli-cmds.c +++ b/gdb/cli/cli-cmds.c @@ -1148,7 +1148,7 @@ print_disassembly (struct gdbarch *gdbarch, const char *name, paddress (gdbarch, low), paddress (gdbarch, high)); /* Dump the specified range. */ - gdb_disassembly (gdbarch, current_uiout, 0, flags, -1, low, high); + gdb_disassembly (gdbarch, current_uiout, flags, -1, low, high); printf_filtered ("End of assembler dump.\n"); gdb_flush (gdb_stdout); diff --git a/gdb/disasm.c b/gdb/disasm.c index 897f2f1412..9d36f151f3 100644 --- a/gdb/disasm.c +++ b/gdb/disasm.c @@ -815,7 +815,7 @@ gdb_disassembler::print_insn (CORE_ADDR memaddr, void gdb_disassembly (struct gdbarch *gdbarch, struct ui_out *uiout, - char *file_string, int flags, int how_many, + int flags, int how_many, CORE_ADDR low, CORE_ADDR high) { struct ui_file *stb = mem_fileopen (); diff --git a/gdb/disasm.h b/gdb/disasm.h index 7bbfa31da4..7374dbfe2d 100644 --- a/gdb/disasm.h +++ b/gdb/disasm.h @@ -92,7 +92,7 @@ struct disasm_insn }; extern void gdb_disassembly (struct gdbarch *gdbarch, struct ui_out *uiout, - char *file_string, int flags, int how_many, + int flags, int how_many, CORE_ADDR low, CORE_ADDR high); /* Print the instruction at address MEMADDR in debugged memory, diff --git a/gdb/mi/mi-cmd-disas.c b/gdb/mi/mi-cmd-disas.c index 2247d2c3e0..9338f7bdec 100644 --- a/gdb/mi/mi-cmd-disas.c +++ b/gdb/mi/mi-cmd-disas.c @@ -187,7 +187,6 @@ mi_cmd_disassemble (char *command, char **argv, int argc) } gdb_disassembly (gdbarch, uiout, - file_string, disasm_flags, how_many, low, high); diff --git a/gdb/stack.c b/gdb/stack.c index 4c9e14e48e..f48433109a 100644 --- a/gdb/stack.c +++ b/gdb/stack.c @@ -770,7 +770,7 @@ do_gdb_disassembly (struct gdbarch *gdbarch, TRY { - gdb_disassembly (gdbarch, current_uiout, 0, + gdb_disassembly (gdbarch, current_uiout, DISASSEMBLY_RAW_INSN, how_many, low, high); }